CalvinBackup/HackBrowserData
1
0
Fork 0
mirror of https://github.com/moonD4rk/HackBrowserData.git synced 2026-05-21 19:06:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor(browser): publicize key-injection capability api (#597)

Browse Source 
Promote keyRetrieversSetter to public KeyManager and lift
keychainPasswordSetter from browser_darwin.go into browser.go as
KeychainPasswordReceiver. Engines already implement these methods;
only type-assertion sites switch to the public interface names.
This commit is contained in:
Roger
2026-05-16 12:26:57 +08:00
committed by GitHub
parent f8bd391923
commit 00be145044
4 changed files with 16 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browser/browser_darwin.go
+5 -17
View File
@@ -155,20 +155,8 @@ func resolveKeychainPassword(flagPassword string) string {
return password
}
// keychainPasswordSetter is an optional capability interface satisfied by
// Safari, which reads InternetPassword records directly from the login keychain.
type keychainPasswordSetter interface {
SetKeychainPassword(string)
}
// newPlatformInjector returns a closure that injects the Chromium master-key
// retriever and the Safari Keychain password into each Browser.
//
// Resolution is lazy: the keychain password prompt and retriever construction
// are deferred until the first Browser that actually needs them passes through
// the closure. Browsers that satisfy neither setter interface (e.g. Firefox)
// short-circuit without ever touching the keychain, so `-b firefox` on macOS
// no longer triggers a password prompt.
// newPlatformInjector lazily wires retrievers (and the macOS keychain password) into each Browser;
// `-b firefox` never triggers a keychain prompt because lazy resolution skips browsers that need neither.
func newPlatformInjector(opts PickOptions) func(Browser) {
var (
password string
@@ -176,8 +164,8 @@ func newPlatformInjector(opts PickOptions) func(Browser) {
resolved bool
)
return func(b Browser) {
rs, needsRetrievers := b.(keyRetrieversSetter)
kps, needsKeychainPassword := b.(keychainPasswordSetter)
km, needsRetrievers := b.(KeyManager)
kps, needsKeychainPassword := b.(KeychainPasswordReceiver)
if !needsRetrievers && !needsKeychainPassword {
return
}
@@ -187,7 +175,7 @@ func newPlatformInjector(opts PickOptions) func(Browser) {
resolved = true
}
if needsRetrievers {
rs.SetKeyRetrievers(retrievers)
km.SetKeyRetrievers(retrievers)
}
if needsKeychainPassword {
kps.SetKeychainPassword(password)