refactor: pass golang-ci lint check

internal/browser/browser.go

@@ -119,14 +119,11 @@ const (
 	chromeBetaName = "Chrome Beta"
 	chromiumName   = "Chromium"
 	edgeName       = "Microsoft Edge"
-	speed360Name   = "360speed"
-	qqBrowserName  = "QQ"
 	braveName      = "Brave"
 	operaName      = "Opera"
 	operaGXName    = "OperaGX"
 	vivaldiName    = "Vivaldi"
 	coccocName     = "CocCoc"
 	yandexName     = "Yandex"
-
-	firefoxName = "Firefox"
+	firefoxName    = "Firefox"
 )

internal/browser/browser_windows.go

@@ -6,6 +6,11 @@ import (
 	"hack-browser-data/internal/item"
 )
 
+const (
+	speed360Name  = "360speed"
+	qqBrowserName = "QQ"
+)
+
 var (
 	chromiumList = map[string]struct {
 		name        string

internal/browser/chromium/chromium.go

@@ -32,7 +32,7 @@ func New(name, storage, profilePath string, items []item.Item) ([]*chromium, err
 	if err != nil {
 		return nil, err
 	}
-	var chromiumList []*chromium
+	chromiumList := make([]*chromium, 0, len(multiItemPaths))
 	for user, itemPaths := range multiItemPaths {
 		chromiumList = append(chromiumList, &chromium{
 			name:      fileutil.BrowserName(name, user),

internal/browser/chromium/chromium_darwin.go

@@ -28,10 +28,9 @@ func (c *chromium) GetMasterKey() ([]byte, error) {
 	)
 	// don't need chromium key file for macOS
 	defer os.Remove(item.TempChromiumKey)
-	// defer os.Remove(item.TempChromiumKey)
 	// Get the master key from the keychain
 	// $ security find-generic-password -wa 'Chrome'
-	cmd = exec.Command("security", "find-generic-password", "-wa", c.storage)
+	cmd = exec.Command("security", "find-generic-password", "-wa", strings.TrimSpace(c.storage)) //nolint:gosec
 	cmd.Stdout = &stdout
 	cmd.Stderr = &stderr
 	err := cmd.Run()

internal/browser/chromium/chromium_windows.go

@@ -24,14 +24,14 @@ func (c *chromium) GetMasterKey() ([]byte, error) {
 	}
 	defer os.Remove(keyFile)
 	encryptedKey := gjson.Get(keyFile, "os_crypt.encrypted_key")
-	if encryptedKey.Exists() {
-		pureKey, err := base64.StdEncoding.DecodeString(encryptedKey.String())
-		if err != nil {
-			return nil, errDecodeMasterKeyFailed
-		}
-		c.masterKey, err = decrypter.DPApi(pureKey[5:])
-		log.Infof("%s initialized master key success", c.name)
-		return c.masterKey, err
+	if !encryptedKey.Exists() {
+		return nil, nil
 	}
-	return nil, nil
+	pureKey, err := base64.StdEncoding.DecodeString(encryptedKey.String())
+	if err != nil {
+		return nil, errDecodeMasterKeyFailed
+	}
+	c.masterKey, err = decrypter.DPAPI(pureKey[5:])
+	log.Infof("%s initialized master key success", c.name)
+	return c.masterKey, err
 }

internal/browser/firefox/firefox.go

@@ -35,7 +35,8 @@ func New(name, storage, profilePath string, items []item.Item) ([]*firefox, erro
 	if err != nil {
 		return nil, err
 	}
-	var firefoxList []*firefox
+
+	firefoxList := make([]*firefox, 0, len(multiItemPaths))
 	for name, itemPaths := range multiItemPaths {
 		firefoxList = append(firefoxList, &firefox{
 			name:      fmt.Sprintf("firefox-%s", name),