docs: drop RFC citations and what-comments, fix stale refs

Apply the no-internal-citation and WHY-not-WHAT rules to source
comments; correct stale identifiers (NewBrowser, PBKDF2Key) and RFC
facts (Yandex ciphertext, Firefox PBKDF2 password).
This commit is contained in:
moonD4rk
2026-06-13 21:13:07 +08:00
parent 2b1283af18
commit 64836e9b3c
30 changed files with 82 additions and 92 deletions
+2 -2
View File
@@ -72,7 +72,7 @@ func TestDiscoverSafariProfiles_OrphanUUIDWithoutDBEntry(t *testing.T) {
// Profile directory with a History.db exists on disk but is absent from
// SafariTabs.db. When the DB is readable and doesn't mention it, we trust
// the DB — the orphan stays hidden because production filters profiles
// with no resolvable data in NewBrowsers anyway. Here we assert discovery
// with no resolvable data in NewBrowser anyway. Here we assert discovery
// returns only what the DB declares.
const dbUUID = "AAAAAAAA-BBBB-CCCC-DDDD-EEEEEEEEEEEE"
const orphanUUID = "11111111-2222-3333-4444-555555555555"
@@ -182,7 +182,7 @@ func TestDiscoverSafariProfiles_DefaultProfileSentinelIgnored(t *testing.T) {
func TestDiscoverSafariProfiles_EmptyProfileDirectoryFiltersOutInNewBrowsers(t *testing.T) {
// Matches the real 4E2D8DD0 orphan on the author's Mac: a profile dir
// listed in neither SafariTabs.db nor containing any extractable data.
// Discovery without the DB surfaces it; NewBrowsers then drops it when
// Discovery without the DB surfaces it; NewBrowser then drops it when
// resolveSourcePaths yields zero matches.
const uuid = "4E2D8DD0-A7D2-4684-939A-898B7675C700"
library := t.TempDir()