chore: remove abandoned linter

.golangci.yml

@@ -8,7 +8,6 @@ run:
 linters:
   enable:
     - 'asciicheck'
-    - 'deadcode'
     - 'depguard'
     - 'dogsled'
     - 'errorlint'
@@ -29,7 +28,6 @@ linters:
     - 'revive'
     - 'typecheck'
     - 'unconvert'
-    - 'varcheck'
     - 'whitespace'
   disable:
 # unsupported lint with golang 1.18+ ref: https://github.com/golangci/golangci-lint/issues/2649
@@ -42,6 +40,8 @@ linters:
     - 'stylecheck'
     - 'unused'
     - 'errcheck'
+    - 'deadcode'
+    - 'varcheck'
 
 issues:
   exclude-use-default: false
@@ -60,10 +60,8 @@ issues:
     - G502
     - G505
   exclude-rules:
-    - path: internal/browser/browser\.go
+    - path: internal/provider/provider\.go
       linters:
-        - 'deadcode'
-        - 'varcheck'
         - 'unused'
   max-issues-per-linter: 0
   max-same-issues: 0

internal/provider/provider.go

@@ -1,4 +1,4 @@
-package browser
+package provider
 
 import (
 	"os"
@@ -6,23 +6,16 @@ import (
 	"sort"
 	"strings"
 
-	"hack-browser-data/internal/browingdata"
+	"hack-browser-data/internal/browser"
-	"hack-browser-data/internal/browser/chromium"
-	"hack-browser-data/internal/browser/firefox"
 	"hack-browser-data/internal/log"
+	"hack-browser-data/internal/provider/chromium"
+	"hack-browser-data/internal/provider/firefox"
 	"hack-browser-data/internal/utils/fileutil"
 	"hack-browser-data/internal/utils/typeutil"
 )
 
-type Browser interface {
+func PickBrowsers(name, profile string) ([]browser.Browser, error) {
-	// Name is browser's name
+	var browsers []browser.Browser
-	Name() string
-	// BrowsingData returns all browsing data in the browser.
-	BrowsingData() (*browingdata.Data, error)
-}
-
-func PickBrowser(name, profile string) ([]Browser, error) {
-	var browsers []Browser
 	clist := pickChromium(name, profile)
 	for _, b := range clist {
 		if b != nil {
@@ -38,8 +31,8 @@ func PickBrowser(name, profile string) ([]Browser, error) {
 	return browsers, nil
 }
 
-func pickChromium(name, profile string) []Browser {
+func pickChromium(name, profile string) []browser.Browser {
-	var browsers []Browser
+	var browsers []browser.Browser
 	name = strings.ToLower(name)
 	if name == "all" {
 		for _, v := range chromiumList {
@@ -77,8 +70,8 @@ func pickChromium(name, profile string) []Browser {
 	return browsers
 }
 
-func pickFirefox(name, profile string) []Browser {
+func pickFirefox(name, profile string) []browser.Browser {
-	var browsers []Browser
+	var browsers []browser.Browser
 	name = strings.ToLower(name)
 	if name == "all" || name == "firefox" {
 		for _, v := range firefoxList {

internal/provider/provider_darwin.go

@@ -1,6 +1,6 @@
 //go:build darwin
 
-package browser
+package provider
 
 import (
 	"hack-browser-data/internal/item"

internal/provider/provider_linux.go

@@ -1,6 +1,6 @@
 //go:build linux
 
-package browser
+package provider
 
 import (
 	"hack-browser-data/internal/item"

internal/provider/provider_windows.go

@@ -1,6 +1,6 @@
 //go:build windows
 
-package browser
+package provider
 
 import (
 	"hack-browser-data/internal/item"