From 1ff17cc6a8bc8d5d8718568f6643342fbb327fe4 Mon Sep 17 00:00:00 2001
From: ggman12 <goodejonah@gmail.com>
Date: Wed, 18 Feb 2026 16:49:02 -0500
Subject: [PATCH] allow adsb to fail for when adsb.lol hasen't uploaded file
 yet.

---
 .../openairframes-daily-release.yaml          | 21 ++++++++++++-------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/openairframes-daily-release.yaml b/.github/workflows/openairframes-daily-release.yaml
index 17f23be..e8ee045 100644
--- a/.github/workflows/openairframes-daily-release.yaml
+++ b/.github/workflows/openairframes-daily-release.yaml
@@ -191,11 +191,10 @@ jobs:
     needs: [resolve-dates, build-faa, adsb-to-aircraft, build-community, build-adsbexchange-json, build-mictronics-db]
     if: github.event_name != 'schedule' && !cancelled()
     steps:
-      - name: Require adsb-to-aircraft success
+      - name: Check adsb-to-aircraft status
         if: needs.adsb-to-aircraft.result != 'success'
         run: |
-          echo "adsb-to-aircraft result was '${{ needs.adsb-to-aircraft.result }}', expected 'success'"
-          exit 1
+          echo "WARNING: adsb-to-aircraft result was '${{ needs.adsb-to-aircraft.result }}', will continue without ADS-B artifacts"
 
       - name: Checkout for gh CLI
         uses: actions/checkout@v4
@@ -212,6 +211,8 @@ jobs:
 
       - name: Download ADS-B artifacts
         uses: actions/download-artifact@v5
+        if: needs.adsb-to-aircraft.result == 'success'
+        continue-on-error: true
         with:
           name: openairframes_adsb-${{ needs.resolve-dates.outputs.adsb_date }}
           path: artifacts/adsb
@@ -276,9 +277,6 @@ jobs:
           if [ -z "$CSV_FILE_FAA" ] || [ ! -f "$CSV_FILE_FAA" ]; then
             MISSING_FILES="$MISSING_FILES FAA_CSV"
           fi
-          if [ -z "$CSV_FILE_ADSB" ] || [ ! -f "$CSV_FILE_ADSB" ]; then
-            MISSING_FILES="$MISSING_FILES ADSB_CSV"
-          fi
           if [ -z "$ZIP_FILE" ] || [ ! -f "$ZIP_FILE" ]; then
             MISSING_FILES="$MISSING_FILES FAA_ZIP"
           fi
@@ -288,6 +286,11 @@ jobs:
           
           # Optional files - warn but don't fail
           OPTIONAL_MISSING=""
+          if [ -z "$CSV_FILE_ADSB" ] || [ ! -f "$CSV_FILE_ADSB" ]; then
+            OPTIONAL_MISSING="$OPTIONAL_MISSING ADSB_CSV"
+            CSV_FILE_ADSB=""
+            CSV_BASENAME_ADSB=""
+          fi
           if [ -z "$ZIP_FILE_MICTRONICS" ] || [ ! -f "$ZIP_FILE_MICTRONICS" ]; then
             OPTIONAL_MISSING="$OPTIONAL_MISSING MICTRONICS_ZIP"
             ZIP_FILE_MICTRONICS=""
@@ -305,7 +308,9 @@ jobs:
           
           # Get basenames for display
           CSV_BASENAME_FAA=$(basename "$CSV_FILE_FAA")
-          CSV_BASENAME_ADSB=$(basename "$CSV_FILE_ADSB")
+          if [ -n "$CSV_FILE_ADSB" ]; then
+            CSV_BASENAME_ADSB=$(basename "$CSV_FILE_ADSB")
+          fi
           CSV_BASENAME_COMMUNITY=$(basename "$CSV_FILE_COMMUNITY" 2>/dev/null || echo "")
           ZIP_BASENAME=$(basename "$ZIP_FILE")
           JSON_BASENAME_ADSBX=$(basename "$JSON_FILE_ADSBX")
@@ -360,7 +365,7 @@ jobs:
 
             Assets:
             - ${{ steps.meta.outputs.csv_basename_faa }}
-            - ${{ steps.meta.outputs.csv_basename_adsb }}
+            ${{ steps.meta.outputs.csv_basename_adsb && format('- {0}', steps.meta.outputs.csv_basename_adsb) || '' }}
             - ${{ steps.meta.outputs.csv_basename_community }}
             - ${{ steps.meta.outputs.zip_basename }}
             - ${{ steps.meta.outputs.json_basename_adsbx }}