CalvinBackup/SpotiFLAC-Mobile
1
0
Fork 0
mirror of https://github.com/zarzet/SpotiFLAC-Mobile.git synced 2026-09-03 08:40:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(downloads): hide unknown byte totals in notifications

Browse Source
This commit is contained in:
zarzet
2026-08-30 18:58:19 +07:00
parent 892d152e5c
commit 2e0a5f7b9c
4 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/app/src/main/kotlin/com/zarz/spotiflac/DownloadService.kt
+6 -2
View File
@@ -89,10 +89,14 @@ class DownloadService : Service() {
internal const val NATIVE_REPLAYGAIN_JOURNAL_FILE = "native_replaygain_journal.json"
internal const val NATIVE_WORKER_CONTRACT_VERSION = NativeDownloadFinalizer.NATIVE_WORKER_CONTRACT_VERSION
internal const val NOTIFICATION_PERCENT_TOTAL = 10_000L
private const val LEGACY_NOTIFICATION_PERCENT_TOTAL = 100L
internal val NATIVE_WORKER_STATE_FILE_LOCK = Any()
internal val NATIVE_REPLAYGAIN_JOURNAL_FILE_LOCK = Any()
private var isRunning = false
internal fun isPercentOnlyNotificationTotal(total: Long): Boolean =
total == NOTIFICATION_PERCENT_TOTAL || total == LEGACY_NOTIFICATION_PERCENT_TOTAL
fun isServiceRunning(): Boolean = isRunning
@@ -1818,7 +1822,7 @@ class DownloadService : Service() {
val visibleProgress = when {
total <= 0L -> "indeterminate"
total == NOTIFICATION_PERCENT_TOTAL ->
isPercentOnlyNotificationTotal(total) ->
"percent:${(progress * 100 / total).toInt()}"
else -> {
// buildNotification renders one decimal place for MB and an
@@ -1909,7 +1913,7 @@ class DownloadService : Service() {
"Preparing download..."
} else if (currentArtistName.isNotEmpty() && queueCount <= 1) {
currentArtistName
} else if (total == NOTIFICATION_PERCENT_TOTAL) {
} else if (isPercentOnlyNotificationTotal(total)) {
val progressPercent = (progress * 100 / total).toInt()
"$progressPercent%"
} else if (total > 0) {
android/app/src/test/kotlin/com/zarz/spotiflac/NativeWorkerPolicyTest.kt
+8
View File
@@ -6,6 +6,14 @@ import org.junit.Assert.assertTrue
import org.junit.Test
class NativeWorkerPolicyTest {
@Test
fun percentOnlyNotificationTotalsDoNotRenderAsBytes() {
assertTrue(DownloadService.isPercentOnlyNotificationTotal(10_000L))
assertTrue(DownloadService.isPercentOnlyNotificationTotal(100L))
assertFalse(DownloadService.isPercentOnlyNotificationTotal(72L * 1024L * 1024L))
assertFalse(DownloadService.isPercentOnlyNotificationTotal(0L))
}
@Test
fun rateLimitRetriesExactlyOnce() {
assertTrue(