CalvinBackup/SpotiFLAC-Mobile
1
0
Fork 0
mirror of https://github.com/zarzet/SpotiFLAC-Mobile.git synced 2026-08-15 15:40:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: MP3 download returns 403 - download FLAC first then convert

Browse Source 
When user selects MP3 quality, the app was sending 'MP3' directly to
Tidal/Qobuz APIs which don't support MP3 as a quality parameter,
resulting in 403 Forbidden errors.

Fix: Convert quality 'MP3' to 'LOSSLESS' before sending to backend,
then convert the downloaded FLAC to MP3 using FFmpeg (existing logic).
This commit is contained in:
zarzet
2026-01-31 07:53:13 +07:00
parent 0c7b8a68d9
commit 3f7fa19cdf
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/providers/download_queue_provider.dart
+9 -5
View File
@@ -1667,6 +1667,10 @@ class DownloadQueueNotifier extends Notifier<DownloadQueueState> {
); );
final quality = item.qualityOverride ?? state.audioQuality; final quality = item.qualityOverride ?? state.audioQuality;
// For MP3, we need to download FLAC first then convert
// Servers don't support MP3 quality directly
final downloadQuality = quality == 'MP3' ? 'LOSSLESS' : quality;
// Fetch extended metadata (genre, label) from Deezer if available // Fetch extended metadata (genre, label) from Deezer if available
String? genre; String? genre;
@@ -1717,7 +1721,7 @@ class DownloadQueueNotifier extends Notifier<DownloadQueueState> {
if (useExtensions) { if (useExtensions) {
_log.d('Using extension providers for download'); _log.d('Using extension providers for download');
_log.d( _log.d(
'Quality: $quality${item.qualityOverride != null ? ' (override)' : ''}', 'Quality: $quality${item.qualityOverride != null ? ' (override)' : ''}${quality == 'MP3' ? ' (downloading as LOSSLESS for conversion)' : ''}',
); );
_log.d('Output dir: $outputDir'); _log.d('Output dir: $outputDir');
result = await PlatformBridge.downloadWithExtensions( result = await PlatformBridge.downloadWithExtensions(
@@ -1730,7 +1734,7 @@ class DownloadQueueNotifier extends Notifier<DownloadQueueState> {
coverUrl: trackToDownload.coverUrl, coverUrl: trackToDownload.coverUrl,
outputDir: outputDir, outputDir: outputDir,
filenameFormat: state.filenameFormat, filenameFormat: state.filenameFormat,
quality: quality, quality: downloadQuality,
trackNumber: trackToDownload.trackNumber ?? 1, trackNumber: trackToDownload.trackNumber ?? 1,
discNumber: trackToDownload.discNumber ?? 1, discNumber: trackToDownload.discNumber ?? 1,
releaseDate: trackToDownload.releaseDate, releaseDate: trackToDownload.releaseDate,
@@ -1744,7 +1748,7 @@ class DownloadQueueNotifier extends Notifier<DownloadQueueState> {
} else if (state.autoFallback) { } else if (state.autoFallback) {
_log.d('Using auto-fallback mode'); _log.d('Using auto-fallback mode');
_log.d( _log.d(
'Quality: $quality${item.qualityOverride != null ? ' (override)' : ''}', 'Quality: $quality${item.qualityOverride != null ? ' (override)' : ''}${quality == 'MP3' ? ' (downloading as LOSSLESS for conversion)' : ''}',
); );
_log.d('Output dir: $outputDir'); _log.d('Output dir: $outputDir');
result = await PlatformBridge.downloadWithFallback( result = await PlatformBridge.downloadWithFallback(
@@ -1757,7 +1761,7 @@ class DownloadQueueNotifier extends Notifier<DownloadQueueState> {
coverUrl: trackToDownload.coverUrl, coverUrl: trackToDownload.coverUrl,
outputDir: outputDir, outputDir: outputDir,
filenameFormat: state.filenameFormat, filenameFormat: state.filenameFormat,
quality: quality, quality: downloadQuality,
trackNumber: trackToDownload.trackNumber ?? 1, trackNumber: trackToDownload.trackNumber ?? 1,
discNumber: trackToDownload.discNumber ?? 1, discNumber: trackToDownload.discNumber ?? 1,
releaseDate: trackToDownload.releaseDate, releaseDate: trackToDownload.releaseDate,
@@ -1780,7 +1784,7 @@ class DownloadQueueNotifier extends Notifier<DownloadQueueState> {
coverUrl: trackToDownload.coverUrl, coverUrl: trackToDownload.coverUrl,
outputDir: outputDir, outputDir: outputDir,
filenameFormat: state.filenameFormat, filenameFormat: state.filenameFormat,
quality: quality, quality: downloadQuality,
trackNumber: trackToDownload.trackNumber ?? 1, trackNumber: trackToDownload.trackNumber ?? 1,
discNumber: trackToDownload.discNumber ?? 1, discNumber: trackToDownload.discNumber ?? 1,
releaseDate: trackToDownload.releaseDate, releaseDate: trackToDownload.releaseDate,