From 4c80fe39dfd493dc2d3d52e9978fa0aeb83c180a Mon Sep 17 00:00:00 2001 From: zarzet <42882290+zarzet@users.noreply.github.com> Date: Fri, 23 Oct 2026 22:44:42 +0700 Subject: [PATCH] style(settings): keep the song.link regions as a const list The packed split string saved only formatter-forced data lines and broke the const, one-literal-per-code style used elsewhere. showAppConfirmDialog also asserts that message and content are not both passed. --- .../settings/download_settings_page.dart | 196 +++++++++++++++++- lib/widgets/app_alert_dialog.dart | 1 + 2 files changed, 186 insertions(+), 11 deletions(-) diff --git a/lib/screens/settings/download_settings_page.dart b/lib/screens/settings/download_settings_page.dart index 20d8fcbcb..810e5441b 100644 --- a/lib/screens/settings/download_settings_page.dart +++ b/lib/screens/settings/download_settings_page.dart @@ -447,17 +447,191 @@ class _DownloadSettingsPageState extends ConsumerState { WidgetRef ref, String current, ) { - final regions = - ('AD AE AG AL AM AO AR AT AU AZ BA BB BD BE BF BG BH BI BJ BN BO ' - 'BR BS BT BW BZ CA CD CG CH CI CL CM CO CR CV CW CY CZ DE DJ DK ' - 'DM DO DZ EC EE EG ES ET FI FJ FM FR GA GB GD GE GH GM GN GQ GR ' - 'GT GW GY HK HN HR HT HU ID IE IL IN IQ IS IT JM JO JP KE KG KH ' - 'KI KM KN KR KW KZ LA LB LC LI LK LR LS LT LU LV LY MA MC MD ME ' - 'MG MH MK ML MN MO MR MT MU MV MW MX MY MZ NA NE NG NI NL NO NP ' - 'NR NZ OM PA PE PG PH PK PL PS PT PW PY QA RO RS RW SA SB SC SE ' - 'SG SI SK SL SM SN SR ST SV SZ TD TG TH TJ TL TN TO TR TT TV TW ' - 'TZ UA UG US UY UZ VC VE VN VU WS XK ZA ZM ZW') - .split(' '); + const regions = [ + 'AD', + 'AE', + 'AG', + 'AL', + 'AM', + 'AO', + 'AR', + 'AT', + 'AU', + 'AZ', + 'BA', + 'BB', + 'BD', + 'BE', + 'BF', + 'BG', + 'BH', + 'BI', + 'BJ', + 'BN', + 'BO', + 'BR', + 'BS', + 'BT', + 'BW', + 'BZ', + 'CA', + 'CD', + 'CG', + 'CH', + 'CI', + 'CL', + 'CM', + 'CO', + 'CR', + 'CV', + 'CW', + 'CY', + 'CZ', + 'DE', + 'DJ', + 'DK', + 'DM', + 'DO', + 'DZ', + 'EC', + 'EE', + 'EG', + 'ES', + 'ET', + 'FI', + 'FJ', + 'FM', + 'FR', + 'GA', + 'GB', + 'GD', + 'GE', + 'GH', + 'GM', + 'GN', + 'GQ', + 'GR', + 'GT', + 'GW', + 'GY', + 'HK', + 'HN', + 'HR', + 'HT', + 'HU', + 'ID', + 'IE', + 'IL', + 'IN', + 'IQ', + 'IS', + 'IT', + 'JM', + 'JO', + 'JP', + 'KE', + 'KG', + 'KH', + 'KI', + 'KM', + 'KN', + 'KR', + 'KW', + 'KZ', + 'LA', + 'LB', + 'LC', + 'LI', + 'LK', + 'LR', + 'LS', + 'LT', + 'LU', + 'LV', + 'LY', + 'MA', + 'MC', + 'MD', + 'ME', + 'MG', + 'MH', + 'MK', + 'ML', + 'MN', + 'MO', + 'MR', + 'MT', + 'MU', + 'MV', + 'MW', + 'MX', + 'MY', + 'MZ', + 'NA', + 'NE', + 'NG', + 'NI', + 'NL', + 'NO', + 'NP', + 'NR', + 'NZ', + 'OM', + 'PA', + 'PE', + 'PG', + 'PH', + 'PK', + 'PL', + 'PS', + 'PT', + 'PW', + 'PY', + 'QA', + 'RO', + 'RS', + 'RW', + 'SA', + 'SB', + 'SC', + 'SE', + 'SG', + 'SI', + 'SK', + 'SL', + 'SM', + 'SN', + 'SR', + 'ST', + 'SV', + 'SZ', + 'TD', + 'TG', + 'TH', + 'TJ', + 'TL', + 'TN', + 'TO', + 'TR', + 'TT', + 'TV', + 'TW', + 'TZ', + 'UA', + 'UG', + 'US', + 'UY', + 'UZ', + 'VC', + 'VE', + 'VN', + 'VU', + 'WS', + 'XK', + 'ZA', + 'ZM', + 'ZW', + ]; final normalizedCurrent = current.trim().toUpperCase(); showAppScrollableBottomSheet( context: context, diff --git a/lib/widgets/app_alert_dialog.dart b/lib/widgets/app_alert_dialog.dart index 3a6149afd..e86049339 100644 --- a/lib/widgets/app_alert_dialog.dart +++ b/lib/widgets/app_alert_dialog.dart @@ -85,6 +85,7 @@ Future showAppConfirmDialog( ButtonStyle? confirmStyle, bool barrierDismissible = true, }) async { + assert(message == null || content == null, 'Pass message or content.'); final result = await showAppDialog( context: context, barrierDismissible: barrierDismissible,