CalvinBackup/SpotiFLAC-Mobile
1
0
Fork 0
mirror of https://github.com/zarzet/SpotiFLAC-Mobile.git synced 2026-07-12 07:16:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use audio_conversion_utils in downloaded_album_screen

Browse Source 
- Replace inline format detection with convertibleAudioSourceFormat()
- Replace inline conversion rules with canConvertAudioFormat()
- Add unit tests for Dolby format detection and conversion rules
This commit is contained in:
zarzet
2026-05-14 15:49:27 +07:00
parent ff86869c33
commit 60f1df1488
2 changed files with 72 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/models_and_utils_test.dart
+44
View File
@@ -7,6 +7,7 @@ import 'package:spotiflac_android/models/track.dart';
import 'package:spotiflac_android/services/app_remote_config_service.dart';
import 'package:spotiflac_android/services/download_request_payload.dart';
import 'package:spotiflac_android/utils/artist_utils.dart';
import 'package:spotiflac_android/utils/audio_conversion_utils.dart';
import 'package:spotiflac_android/utils/mime_utils.dart';
import 'package:spotiflac_android/utils/path_match_keys.dart';
import 'package:spotiflac_android/utils/string_utils.dart';
@@ -426,6 +427,49 @@ void main() {
});
});
group('audio conversion utils', () {
test('detects Dolby formats from stored scan format before file extension', () {
expect(
convertibleAudioSourceFormat(
storedFormat: 'eac3',
filePath: 'content://media/song.m4a',
),
'EAC3',
);
expect(
convertibleAudioSourceFormat(fileName: 'Song.ac-3'),
'AC3',
);
expect(
convertibleAudioSourceFormat(storedFormat: 'ac4'),
'AC4',
);
});
test('allows Dolby sources only for lossy batch conversion targets', () {
expect(
canConvertAudioFormat(sourceFormat: 'EAC3', targetFormat: 'MP3'),
isTrue,
);
expect(
canConvertAudioFormat(sourceFormat: 'EAC3', targetFormat: 'Opus'),
isTrue,
);
expect(
canConvertAudioFormat(sourceFormat: 'EAC3', targetFormat: 'AAC'),
isTrue,
);
expect(
canConvertAudioFormat(sourceFormat: 'EAC3', targetFormat: 'FLAC'),
isFalse,
);
expect(
canConvertAudioFormat(sourceFormat: 'EAC3', targetFormat: 'ALAC'),
isFalse,
);
});
});
group('string utils', () {
test('normalizes optional strings and cover references', () {
expect(normalizeOptionalString(null), isNull);