From 90165d471cfbaaa4c4f4f62a50966fed4769fed4 Mon Sep 17 00:00:00 2001
From: zarzet <42882290+zarzet@users.noreply.github.com>
Date: Tue, 6 Oct 2026 21:59:18 +0700
Subject: [PATCH] test(providers): keep notifier fixture counters private

---
 .../mornye_screens_performance_test.dart      | 10 +++----
 test/download_queue_feedback_test.dart        | 12 ++++-----
 test/local_library_lazy_loading_test.dart     | 26 +++++++++----------
 3 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/integration_test/mornye_screens_performance_test.dart b/integration_test/mornye_screens_performance_test.dart
index e7b54d5d..356b8ddd 100644
--- a/integration_test/mornye_screens_performance_test.dart
+++ b/integration_test/mornye_screens_performance_test.dart
@@ -241,7 +241,7 @@ void main() {
         await probe.wait(const Duration(milliseconds: 100));
       }
       await probe.wait(const Duration(milliseconds: 900));
-      expect(search.resultCount, greaterThan(0));
+      expect(search._resultCount, greaterThan(0));
       await tester.tap(find.byTooltip('Clear').hitTestable());
       await probe.wait(const Duration(milliseconds: 400));
       expect(field.controller.text, isEmpty);
@@ -292,7 +292,7 @@ void main() {
         'maximumBrowseLimit': requests
             .map((request) => request.limit)
             .reduce((a, b) => a > b ? a : b),
-        'searchRequests': search.requests,
+        'searchRequests': search._requests,
         'settingsUnchanged': true,
         'databaseCalls': databaseCalls.length,
       },
@@ -440,8 +440,8 @@ class _Profile extends UserProfileNotifier {
 }
 
 class _Search extends TrackNotifier {
-  int requests = 0;
-  int get resultCount => state.tracks.length;
+  int _requests = 0;
+  int get _resultCount => state.tracks.length;
 
   @override
   Future<void> customSearch(
@@ -451,7 +451,7 @@ class _Search extends TrackNotifier {
     String? selectedFilter,
     bool allowVerificationRetry = true,
   }) async {
-    requests++;
+    _requests++;
     state = TrackState(
       hasSearchText: true,
       searchExtensionId: 'example',
diff --git a/test/download_queue_feedback_test.dart b/test/download_queue_feedback_test.dart
index d8876863..cd089519 100644
--- a/test/download_queue_feedback_test.dart
+++ b/test/download_queue_feedback_test.dart
@@ -6,8 +6,8 @@ import 'package:spotiflac_android/providers/download_queue_provider.dart';
 import 'package:spotiflac_android/widgets/download_queue_feedback.dart';
 
 class _Queue extends DownloadQueueNotifier {
-  int retryCalls = 0;
-  bool? retriedNetworkOnly;
+  int _retryCalls = 0;
+  bool? _retriedNetworkOnly;
 
   @override
   DownloadQueueState build() => const DownloadQueueState();
@@ -20,8 +20,8 @@ class _Queue extends DownloadQueueNotifier {
 
   @override
   Future<void> retryAllFailed({bool networkOnly = false}) async {
-    retryCalls++;
-    retriedNetworkOnly = networkOnly;
+    _retryCalls++;
+    _retriedNetworkOnly = networkOnly;
   }
 }
 
@@ -65,8 +65,8 @@ void main() {
       expect(find.text(l10n.queueNetworkFailedOffline(3)), findsOneWidget);
       await tester.tap(find.text(l10n.dialogRetry));
       await tester.pumpAndSettle();
-      expect(queue.retryCalls, 1);
-      expect(queue.retriedNetworkOnly, isTrue);
+      expect(queue._retryCalls, 1);
+      expect(queue._retriedNetworkOnly, isTrue);
       queue.progressSnapshot();
       await tester.pumpAndSettle();
       expect(find.byType(SnackBar), findsNothing);
diff --git a/test/local_library_lazy_loading_test.dart b/test/local_library_lazy_loading_test.dart
index 739ada89..dcf381a1 100644
--- a/test/local_library_lazy_loading_test.dart
+++ b/test/local_library_lazy_loading_test.dart
@@ -31,12 +31,12 @@ class _Settings extends SettingsNotifier {
 }
 
 class _Local extends LocalLibraryNotifier {
-  int builds = 0;
-  int reloads = 0;
+  int _builds = 0;
+  int _reloads = 0;
 
   @override
   LocalLibraryState build() {
-    builds++;
+    _builds++;
     return LocalLibraryState();
   }
 
@@ -46,19 +46,19 @@ class _Local extends LocalLibraryNotifier {
 
   @override
   Future<void> reloadFromStorage() async {
-    reloads++;
+    _reloads++;
   }
 }
 
 class _History extends DownloadHistoryNotifier {
-  int reloads = 0;
+  int _reloads = 0;
 
   @override
   DownloadHistoryState build() => DownloadHistoryState();
 
   @override
   Future<void> reloadFromStorage() async {
-    reloads++;
+    _reloads++;
   }
 }
 
@@ -154,10 +154,10 @@ void main() {
       }
 
       await settle();
-      expect(local.builds, 0);
+      expect(local._builds, 0);
       container.read(settingsProvider.notifier).setLocalLibraryEnabled(true);
       await settle();
-      expect(local.builds, 1);
+      expect(local._builds, 1);
       final enabledQueries = queries;
       local.publishIndexChange();
       await settle();
@@ -171,7 +171,7 @@ void main() {
       expect(queries, disabledQueries);
       container.read(settingsProvider.notifier).setLocalLibraryEnabled(true);
       await settle();
-      expect(local.builds, 1);
+      expect(local._builds, 1);
       expect(queries, greaterThan(disabledQueries));
     },
   );
@@ -214,15 +214,15 @@ void main() {
         ),
       );
       await tester.pumpAndSettle();
-      expect(history.reloads, greaterThan(0));
-      expect(local.builds, 0);
-      expect(local.reloads, 0);
+      expect(history._reloads, greaterThan(0));
+      expect(local._builds, 0);
+      expect(local._reloads, 0);
       final container = ProviderScope.containerOf(
         tester.element(find.byType(QueueTab)),
       );
       container.read(settingsProvider.notifier).setLocalLibraryEnabled(true);
       await tester.pumpAndSettle();
-      expect(local.builds, 1);
+      expect(local._builds, 1);
       container.read(settingsProvider.notifier).setLocalLibraryEnabled(false);
       await tester.pumpAndSettle();
       final disabledQueries = queries;