From 95a8802e42a565b32fc741f91fe17fedaf5aa00f Mon Sep 17 00:00:00 2001 From: zarzet <42882290+zarzet@users.noreply.github.com> Date: Sun, 18 Oct 2026 22:02:15 +0700 Subject: [PATCH] docs(contributing): name every third_party fork and scope the ffmpeg override The boundaries table left out the two audioplayers forks and the encrypted Discord SDK, and the test prerequisites implied SPOTIFLAC_TEST_FFMPEG applies to every ffmpeg test when only the automix renderer test reads it. --- CONTRIBUTING.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b7970aa7..50423d2a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -135,7 +135,8 @@ android/ Android platform bridge and foreground worker ios/ iOS platform bridge and application project test/ Flutter unit and widget tests integration_test/ Device and emulator tests (including performance drivers) -third_party/ Vendored and patched packages (audio_service, Discord bridge) +third_party/ Vendored and patched packages (audio_service, audioplayers forks, + Discord bridge and encrypted SDK) assets/ Images, fonts, and bundled resources docs/ Local documentation and migration archives (gitignored) scripts/ Reproducible project build helpers @@ -188,7 +189,8 @@ fvm flutter test ``` Some Dart tests render audio and need `ffmpeg` and `ffprobe` on `PATH`. Set -`SPOTIFLAC_TEST_FFMPEG` to an `ffmpeg` binary to override the lookup. +`SPOTIFLAC_TEST_FFMPEG` to an `ffmpeg` binary to override the path used by the +automix renderer test; the other ffmpeg tests read `PATH` directly. Performance drive runs need a dedicated emulator, `--profile` on Android and `--debug` on iOS simulators. See the header of