perf(ui): retain platform link lookup across rebuilds

Keep the platform lookup Future in widget state and replace it only when track identifiers change. Theme rebuilds retain loaded content without another native call. Add widget regressions for theme and identifier changes.
2026-09-18 07:42:22 +02:00 · 2026-09-06 14:04:05 +07:00
parent 4a4de098c8
commit a89f786960
2 changed files with 91 additions and 5 deletions
@@ -0,0 +1,60 @@
+import 'dart:async';
+import 'package:flutter/material.dart';
+import 'package:flutter/services.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:spotiflac_android/l10n/app_localizations.dart';
+import 'package:spotiflac_android/widgets/open_on_platform_sheet.dart';
+
+void main() {
+  TestWidgetsFlutterBinding.ensureInitialized();
+  testWidgets(
+    'theme rebuild retains completed lookup; identifiers replace it',
+    (tester) async {
+      const channel = MethodChannel('com.zarz.spotiflac/backend');
+      final calls = <MethodCall>[];
+      final pending = Completer<Map<String, dynamic>>();
+      tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(channel, (
+        call,
+      ) async {
+        calls.add(call);
+        if (calls.length == 1) {
+          return {
+            'platforms': {'spotify': 'https://example.test/one'},
+          };
+        }
+        return pending.future;
+      });
+      addTearDown(
+        () => tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
+          channel,
+          null,
+        ),
+      );
+      Widget app(Brightness brightness, String id) => MaterialApp(
+        theme: ThemeData(brightness: brightness),
+        localizationsDelegates: AppLocalizations.localizationsDelegates,
+        supportedLocales: AppLocalizations.supportedLocales,
+        home: Scaffold(body: OpenOnPlatformSheet(spotifyId: id)),
+      );
+      await tester.pumpWidget(app(Brightness.light, 'one'));
+      await tester.pumpAndSettle();
+      expect(find.text('Spotify'), findsOneWidget);
+      await tester.pumpWidget(app(Brightness.dark, 'one'));
+      await tester.pumpAndSettle();
+      expect(calls.length, 1);
+      expect(find.text('Spotify'), findsOneWidget);
+      expect(find.byType(CircularProgressIndicator), findsNothing);
+      await tester.pumpWidget(app(Brightness.dark, 'two'));
+      await tester.pump();
+      expect(calls.length, 2);
+      expect(calls.last.arguments, {'spotify_id': 'two', 'isrc': ''});
+      expect(find.byType(CircularProgressIndicator), findsOneWidget);
+      pending.complete({
+        'platforms': {'appleMusic': 'https://example.test/two'},
+      });
+      await tester.pumpAndSettle();
+      expect(find.text('Apple Music'), findsOneWidget);
+      expect(find.text('Spotify'), findsNothing);
+    },
+  );
+}