From c6ee9cda3589b0b5c31d13e06af9175bbacd44a2 Mon Sep 17 00:00:00 2001 From: zarzet Date: Sat, 7 Feb 2026 11:58:46 +0700 Subject: [PATCH] fix: resolve Go staticcheck warnings in audio_metadata.go and qobuz.go --- go_backend/audio_metadata.go | 22 ++++++++-------------- go_backend/qobuz.go | 7 +++---- 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/go_backend/audio_metadata.go b/go_backend/audio_metadata.go index 33056507..c84efbef 100644 --- a/go_backend/audio_metadata.go +++ b/go_backend/audio_metadata.go @@ -430,11 +430,12 @@ func extendedHeaderSize(data []byte, version byte) int { return 0 } var size int - if version == 3 { + switch version { + case 3: size = int(binary.BigEndian.Uint32(data[:4])) - } else if version == 4 { + case 4: size = syncsafeToInt(data[:4]) - } else { + default: return 0 } if size <= 0 { @@ -624,14 +625,6 @@ func readOggPageWithHeader(file *os.File) (*oggPage, error) { }, nil } -func readOggPage(file *os.File) ([]byte, error) { - page, err := readOggPageWithHeader(file) - if err != nil { - return nil, err - } - return page.data, nil -} - func collectOggPackets(file *os.File, maxPackets, maxPages int) ([][]byte, error) { const maxPacketSize = 10 * 1024 * 1024 var packets [][]byte @@ -930,11 +923,12 @@ func extractMP3CoverArt(filePath string) ([]byte, string, error) { } var frameSize int - if majorVersion == 2 { + switch majorVersion { + case 2: frameSize = int(tagData[pos+3])<<16 | int(tagData[pos+4])<<8 | int(tagData[pos+5]) - } else if majorVersion == 4 { + case 4: frameSize = int(tagData[pos+4])<<21 | int(tagData[pos+5])<<14 | int(tagData[pos+6])<<7 | int(tagData[pos+7]) - } else { + default: frameSize = int(tagData[pos+4])<<24 | int(tagData[pos+5])<<16 | int(tagData[pos+6])<<8 | int(tagData[pos+7]) } diff --git a/go_backend/qobuz.go b/go_backend/qobuz.go index 140e8ffd..a74a1ea1 100644 --- a/go_backend/qobuz.go +++ b/go_backend/qobuz.go @@ -764,10 +764,9 @@ type qobuzAPIResult struct { // Qobuz API timeout configuration // Mobile networks are more unstable, so we use longer timeouts const ( - qobuzAPITimeoutDesktop = 15 * time.Second - qobuzAPITimeoutMobile = 25 * time.Second - qobuzMaxRetries = 2 // Number of retries per API - qobuzRetryDelay = 500 * time.Millisecond + qobuzAPITimeoutMobile = 25 * time.Second + qobuzMaxRetries = 2 // Number of retries per API + qobuzRetryDelay = 500 * time.Millisecond ) // getQobuzAPITimeout returns appropriate timeout based on platform