mirror of
https://github.com/zarzet/SpotiFLAC-Mobile.git
synced 2026-09-24 18:40:43 +02:00
perf(memory): drop disposable caches on pressure
This commit is contained in:
@@ -87,6 +87,13 @@ var (
|
||||
coverFetch = fetchCoverBytes
|
||||
)
|
||||
|
||||
func clearCoverMemoryCache() {
|
||||
coverMu.Lock()
|
||||
coverCache = map[string]*coverCacheEntry{}
|
||||
coverCacheBytes = 0
|
||||
coverMu.Unlock()
|
||||
}
|
||||
|
||||
// fetchCoverCached returns cover bytes for a final URL, collapsing concurrent
|
||||
// requests for the same URL into a single fetch (singleflight) and caching
|
||||
// results in memory for the duration of an album batch. The returned slice is
|
||||
|
||||
@@ -36,7 +36,25 @@ func metadataAcceptLanguage() string {
|
||||
// when backgrounded, so the Go side's RSS doesn't sit at its high-water mark
|
||||
// after large downloads/tag writes.
|
||||
func ReleaseMemory() {
|
||||
releaseMemory(false)
|
||||
}
|
||||
|
||||
// ReleaseMemoryUnderPressure additionally drops disposable live caches. It is
|
||||
// reserved for an OS memory-pressure signal; ordinary backgrounding keeps
|
||||
// network-backed caches warm.
|
||||
func ReleaseMemoryUnderPressure() {
|
||||
releaseMemory(true)
|
||||
}
|
||||
|
||||
func releaseMemory(underPressure bool) {
|
||||
drainAllIsolatedRuntimePools()
|
||||
CloseIdleConnections()
|
||||
if underPressure {
|
||||
clearCoverMemoryCache()
|
||||
globalLyricsCache.ClearAll()
|
||||
clearPrivateIPCache()
|
||||
clearExtensionHealthCache()
|
||||
}
|
||||
debug.FreeOSMemory()
|
||||
}
|
||||
|
||||
|
||||
@@ -52,6 +52,12 @@ var (
|
||||
extensionHealthCache = map[string]cachedExtensionHealthResult{}
|
||||
)
|
||||
|
||||
func clearExtensionHealthCache() {
|
||||
extensionHealthCacheMu.Lock()
|
||||
extensionHealthCache = map[string]cachedExtensionHealthResult{}
|
||||
extensionHealthCacheMu.Unlock()
|
||||
}
|
||||
|
||||
func CheckExtensionHealthJSON(extensionID string) (string, error) {
|
||||
manager := getExtensionManager()
|
||||
ext, err := manager.GetExtension(extensionID)
|
||||
|
||||
@@ -181,6 +181,12 @@ var (
|
||||
privateIPCacheMu sync.RWMutex
|
||||
)
|
||||
|
||||
func clearPrivateIPCache() {
|
||||
privateIPCacheMu.Lock()
|
||||
privateIPCache = make(map[string]privateIPCacheEntry)
|
||||
privateIPCacheMu.Unlock()
|
||||
}
|
||||
|
||||
func newExtensionRuntime(ext *loadedExtension) *extensionRuntime {
|
||||
jar, _ := newSimpleCookieJar()
|
||||
|
||||
|
||||
@@ -0,0 +1,44 @@
|
||||
package gobackend
|
||||
|
||||
import (
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
func TestReleaseMemoryUnderPressureClearsDisposableCaches(t *testing.T) {
|
||||
clearCoverMemoryCache()
|
||||
coverCachePut("https://example.com/cover.jpg", []byte("cover"))
|
||||
globalLyricsCache.ClearAll()
|
||||
globalLyricsCache.Set("artist", "track", 120, &LyricsResponse{PlainLyrics: "lyrics"})
|
||||
|
||||
privateIPCacheMu.Lock()
|
||||
privateIPCache["example.com"] = privateIPCacheEntry{expiresAt: time.Now().Add(time.Hour)}
|
||||
privateIPCacheMu.Unlock()
|
||||
extensionHealthCacheMu.Lock()
|
||||
extensionHealthCache["extension"] = cachedExtensionHealthResult{expiresAt: time.Now().Add(time.Hour)}
|
||||
extensionHealthCacheMu.Unlock()
|
||||
|
||||
ReleaseMemoryUnderPressure()
|
||||
|
||||
coverMu.Lock()
|
||||
coverEntries, coverBytes := len(coverCache), coverCacheBytes
|
||||
coverMu.Unlock()
|
||||
if coverEntries != 0 || coverBytes != 0 {
|
||||
t.Fatalf("cover cache retained %d entries/%d bytes", coverEntries, coverBytes)
|
||||
}
|
||||
if globalLyricsCache.Size() != 0 {
|
||||
t.Fatalf("lyrics cache retained %d entries", globalLyricsCache.Size())
|
||||
}
|
||||
privateIPCacheMu.RLock()
|
||||
privateEntries := len(privateIPCache)
|
||||
privateIPCacheMu.RUnlock()
|
||||
if privateEntries != 0 {
|
||||
t.Fatalf("private IP cache retained %d entries", privateEntries)
|
||||
}
|
||||
extensionHealthCacheMu.Lock()
|
||||
healthEntries := len(extensionHealthCache)
|
||||
extensionHealthCacheMu.Unlock()
|
||||
if healthEntries != 0 {
|
||||
t.Fatalf("health cache retained %d entries", healthEntries)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user