An unexpected runtime error between the open and the image check left
the descriptor open, so a binder thread of the cover provider could leak
it. The descriptor is now closed in a finally block whenever no image
type was found.
The car's queue view loads each queue item's icon URI in its own process,
so a local song's app-private file:// cover showed nothing there, while
its browse entry already shows the cover through the cover provider.
audio_service gains AudioServicePlugin.setQueueArtResolver (recorded in
MORNYE_PATCHES.md). raw2queue applies it to each QueueItem description
only; the item's MediaMetadataCompat, the metadata cache, the playing
item, the notification and the lock screen keep the original artwork.
A null answer, a resolver that throws, or no resolver keeps the
description as it was.
The app's resolver maps a file:// or plain absolute path that names a
cover directly in the provider's folders, read from the path alone with
the same per-folder name rules, to the provider URI its browse entry
gets, so the car's cache sees one URI per cover.
The cover folders also hold files that are not covers: `.source`
sidecars with the user's audio file paths and `.current` pointers next
to the covers, the regenerate marker, and staging files. Only the image
signature check kept them out. Each folder now also names its covers by
their endings (cover store `.image`; Library thumbnails `.jpg`, `.png`
and `.image`; embedded artwork `.jpg`), so those files are refused by
name before anything is opened.
The provider checked one open of the file and served another. It now
opens the resolved file once with O_NOFOLLOW (and O_CLOEXEC from API
27), checks that descriptor with fstat for a regular file and pread for
an image signature, and serves a dup of that same descriptor; getType
reads its type the same way. The signatures are written as byte values,
so the source stays ASCII.
Android Auto loads browse item artwork from the item's icon URI in its
own process, so it cannot open the app's private cover files and local
covers were left out of every browse list.
CoverContentProvider serves them as content://<applicationId>.covers/
<folder>/<file>. A car cannot hold a permission, so the provider is
exported, and in exchange it only reads: openFile accepts mode "r" only,
insert/update/delete throw, query lists nothing. CoverProviderFiles
resolves a URI to a file only when its path is an allowed folder name
and a plain file name, the canonical file sits directly in the
canonical folder (no "..", encoded "/" or symbolic link out), and it is
a regular file starting with a known image signature.
The allowed folders are the ones browse lists name: the cover store
(files/covers), Library thumbnails (files/library_covers) and embedded
artwork extracted from downloads (cache/embedded_cover_previews). The
covers channel hands Dart the authority and folder paths, registered on
the shared engine so a car-started engine has it too.
Scan thumbnails were named by a 32-bit djb2 hash of "path|size|mtime" (or
the document key) and an existing file was reused without checking its
source, so two songs whose keys collided showed one cover. The Android
document scan had its own copy of the same hash.
Thumbnails are now named cover_<first 128 bits of SHA-256 of the key>, in
Rust for every scan and through library_cover_slot for the Kotlin document
scan, so reuse by name is safe. Rows that name older files keep working;
those files are not looked up again and are pruned once unreferenced.
A forced rescan can touch a .regenerate marker in the cover folder:
thumbnails older than it are extracted again under the same name instead
of being reused, and the newer of a .jpg and .png sibling wins.
Albums, singles and playlists, online and in the Library, end with
"Suggested songs": up to ten songs like the ones above that the collection
does not hold yet, each with a preview, an add button and a click or tap
that downloads it. On a user playlist the add button adds the song there
and it leaves the suggestions; elsewhere it opens the playlist picker.
Phones list the songs as rows, desktop in the page's song table.
Suggestions come from a new optional extension method, getRelatedTracks,
which extensions declare with the relatedTracks capability: it takes up to
three of the collection's songs and returns songs in the shape of search
results. The extension most seeds came from is preferred so it can use
their IDs. Without such an extension, the first metadata provider is
searched by the collection's artists. A refresh button starts from other
songs, and loaded suggestions stay for ten minutes.
Offer cover and LRC export for accessible imported songs. Publish Android SAF sidecars beside the audio document without requiring download history, reuse cached artwork when needed, and clean temporary outputs on every exit path.
Validation: 36 Flutter tests, one Android SAF instrumentation test, scoped analysis, formatting checks, and git diff --check passed.
Publish all split tracks and their visibility rule atomically while preserving the original files and playlist rows. Keep the rule across rescans, restore originals when outputs leave the visible Library, and stabilize Android SAF identities and artwork caching.
Validation: 84 Flutter tests, 19 native Library tests, scoped analyzer, formatting checks, and Android Kotlin compilation passed.
A microphone button in the empty search field listens to the room and
names the song, on phones and desktop.
- The audio fingerprint and the Shazam request run in Rust behind a new
recognize_song data job, so every platform shares one path.
- Listening sends the audio so far at 4, 8 and 12 seconds and stops at
the first match; quiet or short clips are reported instead of sent.
- A match can be played from the library (by ISRC, then title and
artist), searched in Mornye, or opened in Shazam. Recent matches are
kept in a local history.
- Android asks for the microphone only when listening starts; iOS and
macOS gain the microphone usage description and entitlement. The Linux
package recommends pulseaudio-utils for capture.
Analyze each Library song once in the background, on the device, and
let Autoplay pick songs that sound like the session and flow into each
other.
- Decode two 24 s mono windows at about 30% and 60% of a song with one
FFmpeg thread, describe them natively, and delete the PCM at once.
Documents are opened through FFmpegKit's SAF parameter, not copied.
- Keep features in a small database of their own, keyed by path with
the file's size, modification time and the analysis version. Failed
songs are recorded and tried again only once the file or the version
changes; rows of songs the Library no longer has are removed.
- Sweep one song at a time with rests four times the work, never in
the first 20 s of a song or while AutoMix mixes. Android sweeps only
while charging unless the listener allows battery, desktop sweeps
at that pace, iOS analyzes only the song playing. The song playing
is analyzed 20 s after it starts, on battery too.
- Add a sound signal: up to +5 for sounding like the latest songs,
with timbre weighing most over features standardized across the
songs at hand; each pick loses up to 1.5 for a tempo jump (octaves
folded) and 1.5 for an energy jump, and gains 0.5 for a neighboring
key. Unanalyzed songs score and follow as an average analyzed one.
Android Auto showed only the current queue, had no search, and could not
love songs or browse until the app was opened on the phone: Dart startup
waited for an Activity, so AudioService never configured and the star
had no handler.
- audio_service: add setFlutterEngineConfigurator so the app registers
its playback plugins and a playback subset of the backend channel on
the shared engine whichever component creates it. MainActivity replaces
that handler with the full backend when it attaches. SAF playback
leases now belong to the process.
- Start the player, restore the session and set up the media controls
without an Activity. The star loves songs straight in the collections
database until the app shell takes the controls over.
- Add MediaLibraryBrowser: Songs (with Shuffle library), Albums, Artists
and Playlists (Loved first) tabs, grouped search results, paging, and
voice requests that play songs or the album, artist or playlist asked
for. Choosing a song plays the folder it came from.
- Return the playing song for media resumption after a cold start.
- Move playable media factories, track file resolution, media identity
and locale lookup out of the providers so the headless path shares
them.
Local covers stay out of browse lists because a car cannot open the
app's own files; songs that play keep their artwork.
Phones find Mornye on a computer over mDNS (bonsoir, _mornye._tcp),
pair with its 6-digit PIN and keep a live session with the chosen
desktop.
- Pinned HTTPS: first contact records the presented certificate and
checks it against info and the mDNS fingerprint; later requests and
the WebSocket accept only that SHA-256.
- Pairing posts the PIN proof, maps bad_proof, pairing_closed and 429
to clear errors, saves a Subsonic API-key network connection, adds it
to Library and scans it. Re-pairing replaces the key in place.
- LinkClientSession: Bearer JSON get/post with timeouts and
LinkException mapping, WebSocket hello/welcome, backoff from 1 s
doubling to 30 s, pause in the background, reconnect when discovery
sees the desktop again, address updates when it moves.
- LinkClientController publishes the active session through
linkActiveClientProvider and rescans on catalog.changed.
- Settings entry "Mornye on your computer" on Android and iOS with
nearby and paired computers, PIN and manual address dialogs, forget,
and local network permission, Wi-Fi and certificate warnings.
- iOS NSBonjourServices and the Android multicast permission.
Preserve the system audio mode and speakerphone route when only player settings change. Apply explicit global routing changes using the incoming context instead of the previous defaults.
Verified with three native routing regression tests and 34 Dart player tests. The Android build and audioplayers lint checks pass. Related to #721.
A finished scan only reported how many files it skipped. The Rust
scanner and the Android SAF scan now record the first 100 failed files
with the reader's reason and include them in the finished progress
report.
Library settings show the count under each folder, and its actions
open a sheet listing each file, its folder and the reason. The list is
kept per folder across restarts, cleared by a clean scan and removed
with the folder. Network folders keep only the count.
Validation: provider, model and Rust scan tests, and the full Flutter
suite on a clean tree with only this series applied.
Android Library scans counted a file as an error whenever its tag reader
failed, even when the audio was fine, so mixed folders that other
players list cleanly reported dozens of errors.
- Opus and Vorbis files with a comment header but no title or artist
read as untagged songs instead of failing.
- The comment header is read up to 16 MiB instead of 80 pages, so a
large cover written on small pages no longer hides the tags.
- Raw ADTS .aac files read ID3 or APEv2 tags, a cover, and quality from
their frame headers. MP4 .aac files keep the MP4 reader.
- An ID3v2 tag in front of a FLAC stream is skipped.
- Interrupted and short reads from provider descriptors are retried
instead of failing the read, and the last direct SAF read waits
400 ms before its retry.
Damaged FLAC, MP3 and AAC streams are still rejected.
Validation: 7 new mornye-core format tests (6 fail without this
change), mornye-core, mornye-extensions and mornye-mobile tests, clippy,
and 17 SafMetadataReadPolicyTest cases.
Publish metadata and artwork on the main looper, then refresh the playback media ID while preserving position and playback controls. Cover delayed metadata with playing and paused Android session tests.
Distinguish readable MP3 and MP4 streams without tags from failed metadata reads. Preserve partial ID3 and MP4 tags, use the original display name for tagless documents, and expose parser failures to Android SAF scanning. Cover tagless files, partial tags, invalid data, cancellation, and revoked documents.
Stage content URIs before reading audio for Save LRC, preserve the requested output, and clean up temporary input. Return an explicit failure when the source document is inaccessible.
The Android DSD/WavPack reader built its library row without scannedAt.
Since the native staging validates required fields (d1de8331), one such
file failed the whole import with "Library scan row requires string
scannedAt", so a library containing a .dsf, .dff or .wv file could not
be scanned at all.
Stamp that row in Kotlin and fill a missing scannedAt during native
staging. A row that still cannot be encoded is counted, reported through
invalid_rows, invalid_row_error and invalid_row_paths, and skipped; the
owner logs it and protects the file's previous entry during publication,
as it does for a platform read error, instead of discarding the scan.
"Find lyrics online" in the editor's lyrics section opens a sheet that
asks every enabled provider, extensions included, and lists each
answer in priority order with its timing and a preview. The chosen
lyrics fill the field and are saved with the other edits.
The backend gains getLyricsFromProvider, which asks one enabled
provider directly without the cache or the priority race, and
getEnabledLyricsProviders, wired for desktop, Android and iOS.
Provider display names move to a shared helper.
Add the Mornye brand kit and regenerate the Android and iOS launcher
icons on the Deep Teal background with a dedicated monochrome layer.
Replace the in-app logo assets, point the README banner at the new
lockup, and drop the old README banners. Download notifications now use
the monochrome mark, matching the playback notification.
Rename the Dart package, Android and iOS identifiers, Rust crates, native libraries, and Discord plugin. Preserve legacy data readers and compatibility aliases.
Update localized branding, documentation, artwork, build tooling, and release artifacts. Route Telegram release notifications to @mornyeupdates and link @mornyecommunity.
Phones without tuned haptic primitives often use an eccentric mass motor
that needs tens of milliseconds to spin up. The previous 12 ms on/off
pulses and low-amplitude one-shots were mostly not felt, so only the
loudest hits produced any vibration. On/off motors now play hits from
intensity 0.35 for 25 to 50 ms, and amplitude-controlled motors play
20 to 40 ms pulses with a minimum amplitude.
Analysis keeps every candidate hit with its threshold score, so a new
Sensitivity setting reselects pulses without decoding the song again.
The midpoint reproduces the previous selection exactly. A Strength
setting scales pulse intensity from 0.4x to 1.6x.
Ignore low-memory, resource-reclamation, and ordinary kill exits when recovering Android crash reports. Apply the same policy to saved reports from earlier versions while preserving Java/native crashes, ANRs, and fatal signals.
Include process importance and session duration in confirmed crash diagnostics. Validate with 8 Android unit tests, 9 Flutter tests, analyzer, formatting, and diff checks.
Pass renderer arguments when audio_service creates its cached Flutter engine so existing compatibility rules take effect. Use Skia for Xiaomi 25053PC47I on Android 15 as a scoped workaround for the reported Impeller raster crash.
Add tests that keep the new workaround limited to the affected manufacturer, model, and Android SDK.
Serialize scan notifications and surface failures even when database error persistence fails. Recover interrupted scans independently of auto-scan, retain their checkpoints, and collect matching Android process-exit details on restart.
The two SAF scans repeated the same progress arithmetic and CUE steps.
Only the runs that are identical are shared:
- safScanProgressPct(done, total) is the Int/Int to Double * 100.0
expression all six percent sites used. The incremental scan keeps its
zero-total guard (100.0), the full scan's call sites keep relying on a
non-zero total as before.
- reportScanned() replaces the two identical scanned/error/percent
updates in scanSafTree. The CUE-referenced audio skip keeps its own
update, which never set errorCount.
- reportProcessed() moves above the changed-CUE loop, whose inline copy
of its body it now replaces.
- resolveCueSheetAudio() covers the FILE line extraction plus sibling
lookup that both changed-CUE loops and the unchanged-CUE loop ran.
- scanSafCueTracks() covers the audio name, timestamp, cover key and
scanCueFromUri steps. The scans fall back to different timestamps
when the audio's own cannot be read, so the fallback is a lambda and
still runs only on that failure.
Cancellation checks, checkpoint writes, flushes, the copy/delete of the
temporary CUE file and every counter update stay in place and order;
progress values and the scan output are unchanged.
safExistsBatch and getSafFileModTimes answer per-URI document queries
for library and history checks and do not take part in the scan, so
they move verbatim into SafBatchQueries.kt. The file header of
MainActivitySafScan.kt now describes what is left there.
Child listing (with the provider-loading retry), readable tree
resolution, the listing prefetcher and the ordered read pool are the
I/O layer under both scans and the history inspection, so they move
verbatim into SafTreeListing.kt together with their pool size
constants (4 listing threads, 6 read workers, unchanged).
SafTreeLister and runSafReadsInOrder become internal because the scans
stay behind. The pause poll constant stays with safScanStopRequested.
The CUE sheet helpers used by both SAF scans (FILE line extraction,
the per-directory child lookup cache and the audio sibling resolver)
move verbatim into SafCueScan.kt. rememberCueDirectoryListing becomes
internal because the scans stay behind; the sibling extension list and
the lookup builder are only used in the new file and stay private.
The resumable-scan checkpoint helpers (state file path, load,
reconcile against written rows, row count and output repair) are a
self-contained unit, so they move verbatim into SafScanCheckpoint.kt.
They were file-private and become internal because scanSafTree stays
in MainActivitySafScan.kt. The checkpoint file name, its line format
and the reconciled NDJSON keys are unchanged.
MainActivitySafScan.kt mixes the library scan with unrelated SAF
helpers. resolveSafFile and inspectSafFiles (with its private request
class) serve history file checks, not the scan, so they move verbatim
into SafFileInspection.kt. Signatures and visibility are unchanged.
ExtensionMimeTablesTest fixes the outputs of extFromFileName,
extFromMimeType, SafDownloadHandler.normalizeExt and mimeTypeForExt, and
NativeFinalizationPolicy.normalizeExtension for every table entry plus
unknown, blank, uppercase and dotted inputs. The expected values come
from reading the code; the tables are not inverse maps, so each keeps
its own entries.
The two normalizers trim, lowercase with Locale.ROOT and add one leading
dot, with "" for blank input; checking the dot before or after
lowercasing cannot differ. normalizeExt now delegates to
normalizeExtension, which becomes internal. The test passed against
both original bodies before the delegation.
The MainActivitySafIo helpers declared a MainActivity receiver although
they only use Context members and the core backend. They now take a
Context receiver, and the ones that reach the backend take it as an
explicit first parameter, so a service can call them with its own
backend. buildLibraryCoverCacheKey used neither and is now a plain
function.
Bodies are unchanged apart from passing the backend through to the
helpers they call. Activity callers pass their own coreBackend, so the
same instances reach the same code. The finalizer keeps using
SafDownloadHandler.copyContentUriToTemp; switching it would add the
MediaStore fallback and MIME-based extension, which is a behavior change.
DownloadService and BackgroundWorkService each built the same partial
wake lock (30-minute timeout, 15-minute renew, not reference-counted),
the same dataSync startForeground SDK branch and the same content
PendingIntent to MainActivity. ForegroundWorkLock now holds the lock and
the shared constants, and two small helpers cover the start branch and
the intent.
The renew strategies stay per service: DownloadService renews on its
progress and maintenance calls once 15 minutes have passed, while
BackgroundWorkService re-acquires from a main-thread Handler timer.
Wake-lock tags, channel IDs, notification IDs, intent flags and request
codes are unchanged, and the verification intent keeps its own request
code and extras.
MainActivity.kt is now the dispatcher only. The screen wake,
verification notification, install marker, runtime state, exit,
backend implementation and memory release cases keep their labels and
order in the backend `when` and now call MainActivity.handle<Name>
functions in MainActivityLifecycleCalls.kt; processPendingExtensionCallbacks
stays inline.
Bodies move verbatim. prepareRuntimeState takes the backend that
configureFlutterEngine selected as a parameter, as the case body
captured it before, and flutterBackCallback is widened to internal for
exitApp.