Switching between Lyrics and Up Next in the inspector cross-faded on a
fixed linear 180 ms in both styles. It now uses the effects spring of the
style; reduced motion still cuts.
Reversing the inspector mid-move swapped its curve and jumped. Its value
is now the pane's openness on screen: opening runs on the style's spring
from the current velocity, closing eases back from wherever the pane is,
and the pane beside the content still stops at its width.
Mornye's desktop Now Playing fade ends with the fade instead of waiting
for a movement it does not make. The sidebar tint and artwork, the
artwork hover, the volume popover, row actions, hover scrims, the header
title, the mini player lines and the Now Playing panel cross-fade use the
style's effects springs, and the scroll arrows page on a spring that stops
at its target. A closed Now Playing panel drops its queue at once.
The selection panel collapsed, expanded and returned to its place on a
fixed curve from rest. It now runs on the style's slow spatial spring
from the drag's velocity, and from its own velocity when the handle is
tapped mid-move; it stops at its place instead of rising past it. The
dismissal keeps its short eased exit. The bar's entrance gives the slide
and the fade their own lengths, and reduced motion keeps the fade alone.
The Mornye dialog grows on the fast spring. The orientation fade, the
settings search reveal and the log follow move on the style's presets;
the reveal and the log follow now honour reduced motion.
The three selected destination icons bounced on elasticOut and
easeOutBack, also with reduced motion and in Mornye. They now play on the
fast expressive spatial spring in Material, which overshoots by itself,
with the fade on the fast effects spring; Mornye's tab icons and reduced
motion stay at rest.
The Mornye selection pill and switch thumb moved on a fixed ease that
started from rest. Both now run on the snappy spring from where they are:
a released pill or thumb keeps the finger's velocity, and a new selection
mid-move goes on from the current velocity. The spring starts in build,
after the parent applied the change, so it never heads for the old slot
first. The pill's lens swell moves on the fast spring.
With its controls hidden, the Mornye lyrics view still drew about twelve
frames each second: the two time labels kept rolling their digits
unseen. Hidden controls now turn their animations off, so the view
draws when a lyric line changes.
The list keeps its scroll offset between openings. Without fixed row
heights it then built and laid out every row above that offset: 30 ms
for a place 150 songs down on a profile build on the emulator, growing
with the depth.
The list now remembers the first row it held and a row's height. On the
frame that opens it there, the rows above are empty boxes of that
height, as the Material queue does for its jump to the playing song.
The computer gave no sign that it played together with a phone, and its
Devices sheet still offered the usual choices, which would have moved
the queue under a running session.
While a session runs, the sheet shows a checked Play together row naming
the phone, no device is checked, and choosing this computer or that
phone ends the session there: the computer tells the phone, which stops
the device that was not chosen. This works whichever device owns the
queue. The player bar's Devices button names Play together and, in the
Material style, draws primary.
The row opens and closes with the reveal the phone's timing group uses,
now one widget. With reduced motion it no longer runs a size animation
of no length, which failed inside its own layout.
While the computer owns the queue in Play together, the phone's screens
and media session show the computer, so the volume keys and the player's
volume slider set the computer's volume although the phone sounds too.
Both now set the phone's own volume for as long as the two play together
and return to the computer afterwards.
The message that another phone's songs cannot be changed from here
appeared under the selection sheet, so nothing seemed to happen until
the sheet was closed. No other selection would work on that host, so
the selection ends and the message is seen.
Send to (device) kept its computer icon when the paired host is a
phone. It is a phone with an arrow there now, which also keeps it apart
from Save to this phone beside it; the Mornye player menu uses the
phone symbol.
A phone host changes no files for other phones. Its songs were then
handed to this phone's own file actions, so deleting, converting or
editing one asked for confirmation and ended with a message about
storage access. They stay with the Link action now, which says that
songs on that device cannot be changed from this phone and sends
nothing.
A switch, off by default, at the end of the Link page shares this phone.
While it is on, the page shows the computer page's host rows: name,
address, security code, Pair a phone with its PIN, and the paired phones
with Remove. The client list no longer calls every host a computer, and
this phone's own announcement stays out of it.
Hosts announce their platform and optional features (downloads, opening
links, file changes). The phone remembers them and hides the actions a
host lacks, and shows a phone icon for a phone host. Older hosts that
announce nothing keep every action.
A Beta entry next to the two devices starts it; choosing one device ends it there. The controller shares the queue, starts the session, keeps the connection, ends quietly when it drops, and remembers a phone timing shift per paired computer, set with a slider shown while it runs.
The offset of a song's synced lyrics is now the app-wide offset plus the
song's own. The player's lyrics menu opens a Lyrics timing sheet with
This song above All songs; the settings page keeps only the app-wide one.
Songs are keyed by title and artist, as Library, History and Link match a
song across devices, and a song in sync stores nothing. Every timed reader
uses the sum: the player lyrics in both styles, the lyric line preview,
the desktop mini player, lock screen lyrics, sharing and the mirrored
player.
The More menu of a playlist and of Loved gets Keep on this phone / Stop
keeping on this phone on phones while a computer is paired (and while
kept, so it can be stopped). A kept collection shows Kept on this phone
in its header meta row, fading in on the fast effects spring while the
row resizes on the spatial spring; Mornye and reduced motion stay still.
Playlists, Liked Songs and the Wishlist get the sort button the Library
album pages have. Custom Order is the saved order; Title, Artist, Album and
Latest only change how the page lists and plays the songs. The choice is
kept per collection. Edit order and the M3U export keep using the saved
order, and saving an edited order returns the page to Custom Order.
A Library artist now has an Albums | Songs switch. Songs lists every song
of the artist by title, with Play, Shuffle and Save as playlist: the songs
of the artist's albums and the songs whose artist tag names the artist
beside others. The view chosen last is the one the next artist opens on.
The Albums | Singles switch moves into a shared LibraryViewToggle, and the
genre song reader into library_song_reads so both lists use one query.
One-line doc comments and inline comments that only repeat the name, the
type or the next statement of what they describe, in the Dart, Kotlin and
desktop runner sources. Comments that state a reason, a constraint, a
unit, a value set or a platform quirk stay. No code changes.
Clearing the app cache deletes the previews of embedded covers, but the
pages still open under Storage & Cache kept the deleted files' paths.
Recently downloaded songs, Library tiles, the downloads list and a
downloaded album showed an empty cover until the app was restarted,
while the player, which reads covers another way, still had them.
The resolver now announces a clear once the last file is gone, and the
widgets that keep a resolved path resolve again, which reads the cover
from the song as on a first launch.
The Mornye player faded moving artwork into a gradient taken from the
still cover, so the lower half kept one fixed colour while the video
above it changed. Two more copies of the video's texture now sit over
that fade: the video blurred in place where it fades out, and its lower
edge drawn small, blurred past its own size and stretched back, which
leaves one colour for the controls. Both follow the frames as they
play. The dark layer for the white labels stays on top, and the colour
is shaded a little more for bright videos.
Reduced motion, a video that is not ready and devices that do not draw
continuously filtered effects (mornyeLiquidGlassProvider) keep the
cover-coloured fade. The widget shows the outgoing video until the next
one is prepared, with the rule the artwork itself uses, now shared as
ShownArtworkVideo.
A still cover got the whole 40% layer as soon as a label background
passed white's 4.5:1 limit, and only once the opening animation had
ended, so a mid-tone cover opened bright and then went dark. The layer
now follows the reading: none up to a luminance of 0.25 (white keeps
3.5:1), then as much as brings the background down to it. A cover read
before starts with its layer when the player opens.
A lossless conversion that changes the sample rate could only pick SWR
or SoXR, each at one fixed setting. Add a quality slider under the
resampler choice, moved by dragging or by a tap anywhere on its track,
with the level named beside it and what it uses below.
SWR offers Fast, Medium, High, Very high and Best (16, 32, 64, 128 and
256 filter taps; the two highest also raise the Kaiser window's
rejection). SoXR offers Medium, High, Very high and Best (16, 20, 28 and
33 bits of precision; 20 and 28 are SoX's HQ and VHQ recipes).
The defaults are what a conversion used before: the library's own SWR
filter (Medium) and the most SoXR offers (Best). A conversion sent to a
paired computer carries the level; one from an older phone gets the
default.
Playing on a tap surprised people used to the details page, so the
"Tapping a song" setting now defaults to Details and offers Play as the
choice. Settings saved before the choice existed keep opening details.
The details button showed a circled "i", which read like the circled
error sign of a song with a missing file. Use a page glyph instead, and
make the button smaller than the play button it replaces: a 20dp glyph
in lists, 16dp in desktop tables and a 28dp circle on grid covers. Touch
targets are unchanged.
The scan for an MP3 source approximated the layer 3 filterbank with one
plain lapped transform, which shows the frame grid at 128 kbps and little
above it: on the test set it found 44 of 51 files at 128 kbps, 16 at
192 kbps and none at 320 kbps or V0.
The audio is now analysed with the filterbank the format defines (the
512-tap window into 32 subbands, the 36-point transform per subband and the
alias butterflies) at all 576 granule alignments. At the encoder's own
alignment the coefficients are the stored spectrum again, which shows in
two ways: their sizes sit on the lattice the format quantizes to, and lines
that are loud everywhere else are zero. Both must peak at the same
alignment for a source to count as found. Excerpts with clipped samples
are avoided, since one clipped sample spoils the granules around it.
On 255 decodes of MP3 at 128, 192 and 320 kbps, V2 and V0 all are found,
and none of 317 originals and AAC or Opus decodes is taken for MP3. Other
decoders, mono, a gain, dither, a trimmed start and 24-bit output keep it
found; audio resampled after decoding does not, and the report says so.
The report now carries the score a pattern of the measured kind counts as
found from, so the page shows the right limit for each codec.
Mornye rows marked the current song only through the play button's pause
glyph, which the info button replaces when a tap plays. Show the current
song's title in the accent on Mornye track rows instead, in the Library,
search, playlists and catalog lists.
A CUE virtual track cannot play before it is split, so its tap opens the
details whatever the "Tapping a song" setting, and its button stays the
play button.
With the default Play choice, Library song rows that had both a details
tap and a play button now swap them: a tap does what the play button
did (same queue, pause or resume for the current song, nothing while it
loads) and the button becomes an info button that opens the details.
One shared helper decides per tap, so the lists keep their structure.
Selection, long press, menus, swipes and rows without a play action are
unchanged, and the Details choice keeps the old behaviour.
Share report sends the outcome and every section as plain text through the
system share sheet. Check authenticity, in the library track menu and among
the selection actions, reads the selected FLAC and WAV files one after
another and lists each song with its outcome, a summary of how many need a
look and a note when they differ in bit depth or sample rate; a finished
row opens its full report in place.
The words of a report now come from one place (HiResReportContent), so the
card, the shared text and the list cannot disagree. The new strings are
translated to Indonesian, five strings the first report left unused are
removed, and a C ABI test covers the desktop route of the whole-file
check.
The Mornye full player's title and artist marquees (portrait and the
landscape header, which shares them) looped forever, also while
playback was paused, which breaks the rule that marquees run only while
visible and playing. Pass the playing state to OverflowMarquee from a
small consumer so only the marquee rebuilds on play and pause. The
cycle count is unchanged.
Each second, the Mornye elapsed and remaining labels rolled their
changed digits for 280 ms through AnimatedSwitchers at the display
rate, about 17 frames a second at 60 Hz and 34 at 120 Hz, each a full
player scene. The owner approved moving this to the shared 30 Hz clock
that already paces the other continuous playback decorations. The
labels now step the same slide and fade curves (including reversals on
rapid seeks) from a DecorativePhase, so a roll draws about nine frames
and ends on the first tick past 280 ms.
The Mornye lyrics viewports (portrait and landscape) fade lyrics under
the player controls with a dstIn ShaderMask. Once the controls hide,
the gradient is opaque everywhere and the mask changes no pixel, yet it
still rendered the whole lyric viewport offscreen on every word sweep
frame. A ShaderMask subclass now paints its child directly in that
state, as the selection pill does for its own mask, and stays in the
tree so the lyric list keeps its scroll state. The masked frames on
either side are unchanged, so the fade looks the same.
The Mornye phone player's switch between cover, lyrics and Up Next runs
a 380 ms animation whose builder created a new lyrics section or queue
widget on every frame, so every visible lyric row or queue row rebuilt
for the whole motion. Create both panels once per layout pass and hand
the same instances to the switcher; the fade, slide and header motion
are unchanged.
Every progress event (each 8 songs) rebuilt every open lyrics search page,
which reran its SQL search, flipped it to loading, and rebuilt the whole
results list because the list watched the full progress value.
Lyrics searches are now a notifier that rebuilds when a pass starts, ends or
fails, and in between searches again only when the index revision changes,
keeping the current hits and replacing them only when the result differs.
The results list watches only the loading and failure state; the checked
count is its own Consumer.
The gap dots breathed on an AnimationController at the display rate, so
an intro or instrumental gap kept the lyrics page drawing 60 to 120
frames a second. They now take the shared DecorativePhase clock like the
other continuous playback decorations, starting and stopping where the
controller did and holding while a disabled TickerMode hides them.
SyncedLyricsView marked every row dirty in didUpdateWidget, so any parent
rebuild rebuilt every visible lyric row, even with the same inputs. The
lyrics section builds a new view, credits widget and share callback each
time it builds, and the desktop panel motion, the Mornye page switch and
resize frames rebuild it per frame.
The rows are now marked dirty only when an input they read changes: the
color scheme, activity, word animation, supplements, seek preview, whether
a long press is offered (the row reads the current callback when it
fires) and the credits by value. New lyrics already reset the rows. The
ambient direction joins the row inputs, since a line without a strong
character follows it and no longer gets a rebuild from every parent build.
The repaint test edited live lyrics in place and relied on that rebuild;
the app always passes new lyrics, so the test now changes a row input
with each in-place edit.
Every desktop album and folder tile with a Play action built a full
IconButton subtree (style resolution, ink, tooltip, focus handling) at
opacity 0, so scrolling a large grid built one for every new tile even
though most are never hovered.
The button is now built when the pointer first enters the cover and then
stays, so its fade out runs as before. Until then a bare focus stop of
the same size holds its place in the Tab order; when Tab reaches it the
button is built and takes the focus, so keyboard users still reveal and
press it. The hidden button was already left out of the semantics tree by
its zero opacity, so screen readers see the same nodes.
Under an interface size other than 100% every liquid lens read the whole
MediaQuery to hand the lens the window's size and pixel ratio, so each
keyboard inset frame and each window resize frame rebuilt every lens, and
a lens rebuild always repaints its glass.
Two small wrappers now follow the viewport instead: one gives the lens the
window values, the other restores the app's viewport for the content. The
lens itself reads only the size and pixel ratio, so it rebuilds only when
those change. What the lens and its content see is unchanged.
The Material desktop Now Playing page fills the window, so every frame
of a live resize recorded a new blur picture and rasterized an image of
about a quarter of the window in physical pixels, then disposed the
previous one.
While only the size changes and the box keeps about its shape (within a
quarter either way), the existing blur is stretched over the box, which
shows no difference for a 48 dp blur, and it is drawn again 150 ms
after the size settles. A new cover, pixel ratio, sigma or a larger
shape change still draws at once. The Mornye backdrop, whose blur bakes
a reveal edge at a fixed position, keeps drawing on every size change.
Opening or closing Lyrics or Up Next, and every frame of a window
resize, ran the panel tween builder, which built a new cover column,
lyrics section and Up Next list each time. Through the lyrics section
that rebuilt every visible lyric row, even while hidden behind Up
Next, and the queue rebuilt all of its visible rows.
The lyrics and queue panels are now built once per panel change and
passed into the tween as its child, and the cover column is kept while
its track, scheme and decode size stay the same. The tween only places
them: the column width, the panel opacity and its whole-pixel slide.
The cover sizes itself from the column width with an AspectRatio, so
the column needs no per-frame size. The panel cross-fade still takes
its duration from where the motion stands when the panel changes.
The Material desktop Now Playing page took the artwork scheme without
fadesSurfaceOnly, so every frame of the scheme move on a track change
built a new ThemeData and rebuilt the whole page: backdrop, cover
column, the always mounted lyrics, the Up Next list and the buttons.
It now swaps the scheme in one step and only the page background,
painted by PlayerArtworkSurface, moves on the effects spring, as the
phone Now Playing page does since 7032c7b43. The background of a page
without a track goes through PlayerArtworkSurface too, so it still
fades instead of snapping. The Mornye page is unchanged.
On the phone shell the bottom bar's PlayerArtworkTheme already moves
the whole scheme to the playing cover, and the mini player nested its
own scope for the same artwork. A skip then ran two ColorScheme lerps
and two ThemeData copies per frame, and the MaterialExpressiveScopes in
the mini player missed their cache against a second per-frame theme.
The mini player now reuses an enclosing scope for the same cover that
moves the whole scheme. At rest the theme is equal to before. A skip
between covers follows the same curve frame for frame. A skip to a
track without artwork now follows the bar exactly; before, the mini
player trailed the bar by one or two frames at 120 Hz. The TV shell
and other places without such an ancestor keep their own scope.
The Material mini player title and artist marquees looped forever, also
while paused, so a paused app with a long title kept rendering full
frames (and re-filtering the bar's backdrop blur) every few seconds.
docs/DESIGN.md says marquees run only while visible and playing.
OverflowMarquee takes a playing flag. When it turns false the pass in
flight finishes and the text rests at the start, where the next copy
lines up with the first, so it never freezes cut off or jumps. Playing
again waits the usual pause and keeps the pass count, so the Mornye cap
of two passes per track is unchanged; Material keeps looping while
playing. Reduced motion, hidden routes and app lifecycle behave as
before. The mini player passes the playback state for both styles.
The Hi-Res Authenticity card now reads the whole file and reports, section
by section: the audio against its stored checksum and declared length, the
real resolution shown by the spacing of quiet samples (padding, a scaled
lower-resolution source, a 16-bit grid under low-level noise), where the
spectrum is cut, and the frame grid a lapped-transform codec (AAC, Vorbis,
MP3) leaves in audio that was lossy once. It shows the average spectrum and
says what each test cannot see. The sampled check used by downloads is
unchanged.
The list has no fixed row heights, so jumping to the playing song built and
laid out every earlier row in one frame, each with its swipe controllers and
artwork lookup. After Shuffle library that could be thousands of rows while
the sheet opened.
The rows the jump passes are now empty boxes of the measured row height.
None of them reach the screen, and the ones kept just above the viewport
become real rows on the next frame.
In the widget test a 3,000 song queue playing song 2,501 took about 13 s to
open before and under a second now.
Below the full-screen cover the Mornye player showed the cover again as
a blur, which read as a second faint cover and gave the controls a
different surface from the lyrics and queue pages. The owner asked for
one colour there, the same as with lyrics open. The player now ends in
the two muted tones those pages use, running straight down so the
cover's fade stays a single overlay, and the blur under the controls is
gone (this reverts 14e265fc2 and 4554a1239).
Finish the right-to-left lyrics from PR #844 on the current lyrics code.
A line's direction now follows the Unicode paragraph rule: its first
strong letter decides, so a Latin line with one Arabic word stays left
to right, and digits, punctuation, marks, emoji or a byte order mark
decide nothing. A line without letters (an instrumental "..." or a gap)
takes its neighbour's direction. The scan is a rune loop over sorted
ranges with an ASCII fast path, in lib/utils/text_direction.dart, and
replaces the PR's any-RTL-character regex and its re-export from
player_lyrics.dart.
- The synced view works the directions out once per set of lyrics,
with its line keys, and lays every row out in its line's direction,
so the row cache, reveal, scale, backing vocals and duet alignment
follow it. Mornye's line measurement uses the same directions.
- The word sweep orders a word's runs by the line's direction and
sweeps each run the way it is laid out, so a Latin word inside an
Arabic line fills from its left.
- A translation or pronunciation reads in its own direction and stays
on its line's side, timed or not. Phrase-aligned pronunciation stays
off for right-to-left lines.
- Plain lyrics keep one text when every line shares a direction and get
a text a line when they mix; the directions are cached per lyrics.
- The lyric line under the header reads, and slides, in the line's
direction: a long Arabic line moves right to bring its end in.
- The editor keeps each field's direction in a notifier that changes
only with the first letter's script, instead of rebuilding the field
on every keystroke.
- The share card and mini player use the same rule.
In a right-to-left app a Latin line now reads left to right from the
left edge; the repaint test records that.
Co-authored-by: itzSho3aib <mamomema123@gmail.com>
Resolve per-line TextDirection for RTL scripts (Arabic, Hebrew, Persian, Urdu, Syriac, Thaana, NKo) across word-synced, line-synced, plain, mini-player, editor, and share-card lyrics on both desktop and mobile.
- Skip left-to-right per-word pronunciation Row layout when the lyric or romanization text contains RTL script so Arabic words stay in natural right-to-left order (LyricPronunciationLayout.measure).
- Pass resolved TextDirection into TextPainter and RichText in _WordHighlightedLyricLine and _SweepingTimedLyricText, sort same-row RTL segment boxes right-to-left, and sweep word highlights, feathers, and glows from right to left (box.right to box.left).
- Align synced, unsynced, mini-player, editor, and share-card lyric lines using directional TextDirection so RTL lines align and wrap naturally on both desktop and mobile.
- Add widget and unit tests covering RTL word-by-word sweep direction, pronunciation column bypass, and line measurement.
[Cherry-picked from PR #844 onto the current lyrics code. The synced
view and plain lyrics parts did not apply to the rewritten code and are
redone in the next commit; the test lines use invented phrases.]
The blur below the full-screen cover kept the cover's larger shapes and
was see-through near the screen edges, so it read as a second, faint
cover laid over the sharp one. It is now blurred far past its shapes and
stays opaque up to its edges: the area under the controls is one tone
taken from the cover that shifts slowly down the screen.