Commit Graph
2756 Commits
Author SHA1 Message Date
zarzet 759d7ca488 docs(library): fold the collections JSON export comment
The comment left from the removed map export ran into the JSON export
description; merge them into one paragraph.
2026-10-23 22:43:23 +07:00
zarzet 8a6b774d9f chore(lyrics): move the active lyric reference into its test
Playback queries LyricTimelineIndex; the linear activeLyricIndices only served
as a test oracle. Scenario tests now exercise the production index directly.
2026-10-23 22:43:23 +07:00
zarzet d407d8b374 chore(library): remove the test-only collections map export
Backups embed the worker JSON fragment from exportLibraryCollectionsJson, so
the map export mode and its benchmark only served tests.
2026-10-23 22:43:23 +07:00
zarzet 17b210749f chore(backup): remove test-only legacy envelope helpers
New backups are written as archives; buildEnvelope and encode were only test
fixtures. The legacy restore test now spells out the old JSON envelope.
2026-10-23 22:43:23 +07:00
zarzet f19c3375a3 chore(motion): remove the test-only withMotionArtworkProxy wrapper
The artwork store starts and closes the proxy itself; the test now checks
that close releases the injected client and loopback server directly.
2026-10-23 22:43:23 +07:00
zarzet b696d38e75 chore(library): remove test-only single-item collection mutators
Production removes wishlist, loved, playlist and playlist-track entries through
the batch paths. Device benchmarks now use the production one-item calls as
their per-track baseline.
2026-10-23 22:43:23 +07:00
zarzet b882b01f32 chore(history): remove the unused streaming history restore
Backup restore goes through restoreFromBackupOperation with the native or
upsertBatch codec, so the streamed replaceAll path was only reached by tests.
The iOS restore test now drives the production operation with a seeded fake.
2026-10-23 22:43:22 +07:00
zarzet 86231be479 chore(library): remove unused collection JSON factories
Collections live in SQLite and backup restore feeds the raw maps to the
database, so nothing parses the old JSON shape; the picker summary dates
were also never read.
2026-10-23 22:43:22 +07:00
zarzet 9319d92198 chore(library): remove unused loadPlaylistTracks
Production reads playlist tracks through loadPlaylistTracksSnapshot and the
test fake keeps its own row helper, so the visibleForTesting wrapper had no caller.
2026-10-23 22:43:22 +07:00
zarzet 9917a76f08 test(mornye): find lyric blur snapshots by render object type
Looks the snapshot render object up by its class instead of a widget type
name string, and narrows the LyricBlur doc to the changes that actually drop
the cached image.
2026-10-23 22:43:00 +07:00
zarzet 4815c26bc8 perf(mornye): draw settled lyric blurs from a cached image
With liquid glass every defocused lyric line ran its own blur pass on each
composited frame, all song long while word-synced lyrics play. A line whose
blur has settled is now rasterized once and drawn as an image until it
changes; lines still easing, or rebuilt, blur live as before.
2026-10-23 22:43:00 +07:00
zarzet 72e2b3b1ba perf(mornye): decode the details sheet cover at thumbnail size
The 70 dp artwork in the Mornye details sheet decoded the original cover,
up to about 36 MB for a 3000 px image. Decoding at the display size times
the device pixel ratio keeps it sharp without the large transient bitmap.
2026-10-23 22:43:00 +07:00
zarzet 720f34f193 fix(android): coalesce background work progress notifications 2026-10-23 22:35:26 +07:00
zarzet dfa5e0d994 perf(library): reuse the prepared page data across rebuilds
Each Library rebuild combined every loaded page, filtered playlist tracks
and regrouped the in-memory History snapshot up to three times, so the
section cache never hit and every row's month was formatted again. The
results are now memoized per input identity, with identical output.
2026-10-23 22:31:44 +07:00
zarzet 64d5e66d46 refactor(library): build songs, singles and collection cells once
The Songs and Singles pages wrote the same grid, table, sectioned and list
layouts twice, and the completion-bridge, special collection and playlist
drop-target cells were written once per grid and list. One builder now
serves each pair with the same widget trees.
2026-10-23 22:31:44 +07:00
zarzet ba59251f82 refactor(library): remove the unreachable Mornye page chip row
QueueTab returns MornyeLibraryScreen for the Mornye root Library, and the
page switcher renders only on that root, so its Mornye chip branch and
_FilterChip could never build.
2026-10-23 22:31:43 +07:00
zarzet 632f24ccdd refactor(library): share the staged ingestion steps
Incremental upserts and full source replacement created, filled and merged
their temp stage with the same code. One set of helpers now does it, with the
source replacement delete still first inside the merge transaction.
2026-10-23 22:28:48 +07:00
zarzet 0af9ac4bed chore: remove unused library database write wrappers
The single-row and batch upserts, replaceAll, the replaceSourceStream
wrapper, delete, getAllFilePaths and searchFtsTable have no callers in lib,
test or integration_test; scans use the staged ingestion paths instead.
2026-10-23 22:28:47 +07:00
zarzet f70c93ac3c refactor(library): share queue store sort terms, paging and counts
Track and album sort modes differ only in the name and key columns, and the
History shadowing anti-join, page query and count summing were written out
several times. The pinned SQL test shows the generated statements and
arguments are unchanged apart from whitespace.
2026-10-23 22:28:47 +07:00
zarzet ebd973f0c1 perf(mornye): keep position ticks and lyric control fades local
Synced lyrics depended on the covered height that animates while the
controls fade, rebuilding the whole list every frame; only the loading
and empty states read it now. Position ticks and digit rolls re-recorded
the entire player because rebuilds under the body LayoutBuilder relayout
it and the seek slider's unused LayoutBuilder relaid out up to the
scaffold; the slider drops it, and the body content and timeline keep
their own layers.
2026-10-23 22:28:23 +07:00
zarzet 26695a8d34 refactor(player): share the current queue index rule
The Mornye player layout and its queue repeated the same "reported index
while it still names the current item, else first match" rule; one
provider now derives it, with a test for stale, shuffled and empty queues.
2026-10-23 22:28:23 +07:00
zarzet e049a2b436 perf(mornye): share the bar read with resting side capsules
Compact chrome took five backdrop reads on every scroll frame: the bar
batch plus two stacked reads per side capsule. While folding, each capsule
now has a batch of its own (three reads); at rest the capsules join the
player's batch (one read). A GlobalKey keeps their lenses mounted.
2026-10-23 22:23:57 +07:00
zarzet 424311bf37 perf(mornye): compose standalone glass lenses into one backdrop read
A lens outside any batch took two backdrop reads (a stock blur, then the
shader). Each one now takes a batch key of its own, so the package composes
blur and refraction into one read, as overlays and the bar already did. The
home filter chips never overlap and share one read for the whole row.
2026-10-23 22:23:56 +07:00
zarzet 9845550839 perf(mornye): compute glass tint only for translucent surfaces
Opaque glass, such as every home search result row, discarded the HSL and
blend math. The translucent result is unchanged.
2026-10-23 22:23:56 +07:00
zarzet 56c1a27ea4 refactor(mornye): drop unused filter chip glass options
Every MornyeFilterChip caller passed glass: false, so the glass branch and
its blurEnabled option were dead. The chip is now a plain StatelessWidget.
2026-10-23 22:23:56 +07:00
zarzet 96e3f249c8 perf(desktop): summarize downloads in one pass for the toolbar ring
The toolbar button copied the active downloads and rebuilt on every queue
change; it now selects the count and progress, so it rebuilds only when the
ring or the count changes.
2026-10-23 22:22:25 +07:00
zarzet 14b885a07b perf(library): skip the no-op rebuild after a scanned cover checks out
A local artwork cell rebuilt once more after confirming its scanned cover
exists, although nothing it shows had changed.
2026-10-23 22:22:25 +07:00
zarzet 8d7b3d634f perf(desktop): sort the song table once per input and scope row hover
The table re-sorted every row on each build, including a selection click,
and the quality comparator parsed both labels in every comparison. Sort keys
are now computed once and the order is kept while the rows and sort stay
the same; hovering a row rebuilds only its fading actions.
2026-10-23 22:22:25 +07:00
zarzet 4e1a6a2a94 chore(l10n): remove unused homeSupports and selectionShareCount keys
No screen reads either string any more; the only reference was a test
asserting the share label is absent, which now cannot render.
2026-10-23 22:22:04 +07:00
zarzet cc15c723ba refactor: use switch expressions in format and model mappers
Return-only switch statements in the conversion, MIME, error type,
logger and model helpers become switch expressions with the same
cases and defaults, and the log summary switch drops redundant breaks.
2026-10-23 22:22:04 +07:00
zarzet fc7f80d0da refactor(bridge): share channel invoke helpers in PlatformBridge
Fire-and-forget calls, cast results, decoded results and event stream
accessors now go through small async helpers, so each wrapper is one
expression with the same channel names, payloads, casts and decoders.
2026-10-23 22:22:04 +07:00
zarzet 2899be8a53 fix(android): keep background playback resumable
Keep the media service foreground while paused, release CPU wake locks on pause, and demote the service on stop. Await native state publication before requesting audio focus, honor focus denial, and apply the initial MediaPlayer wake mode.

Validated with 141 playback tests and an Android 17 screen-off pause, resume, and stop integration test.
2026-10-23 20:52:10 +07:00
zarzet 309d7bf659 feat(desktop): adjust volume by scrolling over its controls 2026-10-23 20:47:26 +07:00
zarzet 2defae21eb chore(palette): skip the unused sample copy and document the builder
The premultiplied buffer goes to the background job only when the host
quantizer needs it. The cache comment now covers failed readbacks, and the
theme README lists CoverSourceColorBuilder.
2026-10-23 19:21:28 +07:00
zarzet e6bf80cc18 fix(mornye): tint album surfaces from the player's source colour
The player now resolves only the cover source colour, so album pages opened
from it no longer found a cached dark scheme and started gray. Album surfaces
read the shared source colour cache first and fall back as before.
2026-10-23 19:21:28 +07:00
zarzet f200a9383c perf(mornye): shade the player from the cover source colour only
The player background, its actions menu and the lyrics share card read only
the source colour, yet waited for one or two colour schemes during the
player's open slide. They now use the source colour path with the same final
colour.
2026-10-23 19:21:28 +07:00
zarzet 82b10e71f8 perf(palette): read cover samples once and add a source colour path
Palette extraction now reads both pixel buffers from one decode and scores
the seed and the source colour in a single background job, instead of a seed
isolate plus a pixel loop on the UI isolate. resolveSourceColor gives
surfaces that only shade from the cover the same colour without quantizing
or building a colour scheme.
2026-10-23 19:21:28 +07:00
zarzet 2c910f4869 chore(mornye): remove the glass warmup re-export
The services file only re-exported the controller, so its two importers
now import the controller directly.
2026-10-23 19:17:37 +07:00
zarzet f2204b27b7 perf(mornye): remember Cupertino icon lookups
IconData overrides ==, so the switch tested up to 187 patterns in turn on
every icon build. A map keeps the first result per icon, which the switch
computes the same way each time.
2026-10-23 19:17:37 +07:00
zarzet 50cd9e7d94 perf(navigation): keep keyboard insets from hidden tabs
Hidden tabs stay laid out, so every keyboard frame rebuilt and relaid out
their scaffolds although nothing of them paints. They now see no bottom
inset until shown, and keep the same state as before.
2026-10-23 19:17:37 +07:00
zarzet 4127ac1e82 refactor(material): share expressive press squish and disabled fill
The button group and playback transport duplicated the press state and
squish spring, and two icon buttons repeated the disabled color pair. Also
drop three Material Symbols entries no icon in the app uses.
2026-10-23 19:17:37 +07:00
zarzet 0a8f13d32e perf(material): stop flat wavy progress indicators from ticking
The theme draws determinate waves flat below 10% and above 95%, where the
wave phase is invisible, yet the package kept repainting every frame.
Muting the ticker there keeps the same pixels and stops idle frames.
2026-10-23 19:17:37 +07:00
zarzet b6ef41c842 perf(mornye): reuse artist surface themes across page rebuilds
MornyeArtistSurface derived three new ThemeData instances on every page
rebuild (selection, load more, title flips). It now keeps them until the base
theme or the artwork-derived colors change, so the subtree sees the same theme.
2026-10-23 19:17:00 +07:00
zarzet b768b860c3 perf(mornye): rebuild layout slivers only when their layout value changes
SliverLayoutBuilder passes the full SliverConstraints, which change with the
scroll offset, so library and Explore grids, album, artist and desktop
toolbars, and the extension overview rebuilt on every scroll frame. A small
SliverLayoutInfoBuilder rebuilds only when the width or collapsed flag it
selects changes; the header back buttons are built once, and headers can take
a title listenable so a title flip rebuilds only the title.
2026-10-23 19:17:00 +07:00
zarzet aad3496fb2 chore: remove unused history lookups and restore wrapper
findExisting, updateAudioMetadata, getAllFilePaths, the notifier's sync
getBySpotifyId/getByIsrc and restoreFromBackup had no callers; production
restore goes through restoreFromBackupOperation.
2026-10-23 19:16:30 +07:00
zarzet 4e90afa2de perf(startup): overlap the SAF grant check with the install marker read
Android SAF users waited for two sequential platform round trips before the
first frame. The checks are independent; after an installation reset the
settings are reloaded and the check restarts, as before.
2026-10-23 19:16:30 +07:00
zarzet f5b603ed52 refactor(history): share schema column, backfill and single-row helpers
History and Library migrations repeated the same add-column, backfill and
first-row query boilerplate. The helpers issue the same statements in the
same order, and a new v1 upgrade test pins the resulting history schema.
2026-10-23 19:16:30 +07:00
zarzet 24054bfd58 perf(history): extend lookup indexes when a download is prepended
Each completion rebuilt all three history lookup maps over every loaded
item, so a long batch did quadratic key normalization. A prepended item only
wins its own keys, so copying the maps and writing those keys gives the same
lookups.
2026-10-23 19:16:30 +07:00
zarzet 26e027fbe1 refactor(settings): route setters through one commit helper
Every setter repeated the state assignment followed by a save. A private
synchronous _commit keeps that order and the returned save future, while
guards, normalization and backend syncs stay where they were.
2026-10-23 19:15:36 +07:00
zarzet a0eac85eab refactor(settings): reuse the shared library quality label normalizer
SettingsNotifier kept a private copy of normalizeLibraryQualityLabelMode
with the same switch arms and fallback, so call the util instead.
2026-10-23 19:15:36 +07:00