Files
SpotiFLAC-Mobile/test/platform_bridge_lookup_cache_test.dart
zarzet 48ba08976a perf(bridge): reduce metadata copies and decode large JSON off the UI isolate
Keep decoded cache objects private and copy only at public return boundaries. Decode large metadata and persisted JSON in a worker, and read spill files in the decoding isolate with cleanup on failure.

Protect replacement in-flight requests from stale cleanup. Cover nested mutation isolation, coalescing, invalidation, restoration, spill cleanup and retries.
2026-09-20 17:21:11 +07:00

207 lines
6.8 KiB
Dart

import 'dart:async';
import 'dart:convert';
import 'dart:io';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:shared_preferences/shared_preferences.dart';
import 'package:spotiflac_android/services/platform_bridge.dart';
void main() {
TestWidgetsFlutterBinding.ensureInitialized();
const channel = MethodChannel('com.zarz.spotiflac/backend');
final messenger =
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger;
setUp(() async {
SharedPreferences.setMockInitialValues({});
messenger.setMockMethodCallHandler(channel, (_) async => null);
await PlatformBridge.clearTrackCache();
});
tearDown(() async {
messenger.setMockMethodCallHandler(channel, (_) async => null);
await PlatformBridge.clearTrackCache();
messenger.setMockMethodCallHandler(channel, null);
});
Map<String, dynamic> collection([int count = 2]) => {
'type': 'album',
'album_info': {'name': 'Album 音楽'},
'track_list': List.generate(
count,
(index) => {
'id': 'track-$index',
'name': 'Lagu $index — 日本語',
'external_links': {'example': 'https://example.invalid/track/$index'},
},
),
};
Future<Map<String, dynamic>> load() =>
PlatformBridge.getProviderMetadata('example', 'album', 'collection');
void mutate(Map<String, dynamic> value) {
(value['album_info'] as Map<String, dynamic>)['name'] = 'Changed';
final first = (value['track_list'] as List).first as Map<String, dynamic>;
(first['external_links'] as Map<String, dynamic>)['example'] = 'Changed';
}
for (final count in [2, 3000]) {
test(
'coalesced and cached metadata isolate nested mutations ($count)',
() async {
final value = collection(count);
final response = Completer<String>();
final started = Completer<void>();
var calls = 0;
messenger.setMockMethodCallHandler(channel, (call) async {
expect(call.method, 'getProviderMetadata');
calls++;
if (!started.isCompleted) started.complete();
return response.future;
});
final first = load();
await started.future;
final second = load();
await Future<void>.delayed(Duration.zero);
response.complete(jsonEncode(value));
final results = await Future.wait([first, second]);
expect(results[0], value);
mutate(results[0]);
expect(results[1], value);
mutate(results[1]);
final cached = await load();
expect(cached, value);
mutate(cached);
expect(await load(), value);
expect(calls, 1);
},
);
}
test(
'a cleared request cannot remove a replacement in-flight lookup',
() async {
final requests = <Completer<String>>[];
messenger.setMockMethodCallHandler(channel, (call) async {
if (call.method == 'clearTrackCache') return null;
expect(call.method, 'getProviderMetadata');
final pending = Completer<String>();
requests.add(pending);
return pending.future;
});
final old = load();
await Future<void>.delayed(Duration.zero);
expect(requests, hasLength(1));
await PlatformBridge.clearTrackCache();
final replacement = load();
await Future<void>.delayed(Duration.zero);
expect(requests, hasLength(2));
requests[0].complete('{"version":"old"}');
expect(await old, {'version': 'old'});
final joined = load();
await Future<void>.delayed(Duration.zero);
// Complete unexpected calls too, so a failed assertion leaves no waiters.
for (final request in requests.skip(1)) {
request.complete('{"version":"new"}');
}
expect(await replacement, {'version': 'new'});
expect(await joined, {'version': 'new'});
expect(requests, hasLength(2));
expect(await load(), {'version': 'new'});
},
);
test(
'large persisted metadata restores without exposing its stored objects',
() async {
final value = collection(3000);
final prefs = await SharedPreferences.getInstance();
await prefs.setString(
'bridge_metadata_lookup_cache_v1',
jsonEncode({
'example:album:collection': {
'expires_at': DateTime.now()
.add(const Duration(minutes: 5))
.millisecondsSinceEpoch,
'value': value,
},
}),
);
messenger.setMockMethodCallHandler(channel, (call) async {
fail('Restored metadata must not query native: ${call.method}');
});
final restored = await load();
expect(restored, value);
mutate(restored);
expect(await load(), value);
},
);
for (final nullable in [false, true]) {
test(
'large spill file is decoded and deleted (nullable=$nullable)',
() async {
final directory = await Directory.systemTemp.createTemp(
'bridge-decode-',
);
addTearDown(() => directory.delete(recursive: true));
final file = File('${directory.path}/response.json');
final value = collection(3000);
await file.writeAsString(jsonEncode(value));
messenger.setMockMethodCallHandler(
channel,
(_) async => {'__json_file': file.path},
);
final result = nullable
? await PlatformBridge.handleURLWithExtension(
'https://example.invalid/album',
)
: await load();
expect(result, value);
expect(await file.exists(), isFalse);
mutate(result!);
final cached = nullable
? await PlatformBridge.handleURLWithExtension(
'https://example.invalid/album',
)
: await load();
expect(cached, value);
},
);
}
test('invalid spill file is deleted and does not poison retry', () async {
final directory = await Directory.systemTemp.createTemp('bridge-invalid-');
addTearDown(() => directory.delete(recursive: true));
final file = File('${directory.path}/response.json');
await file.writeAsString('{broken');
var calls = 0;
messenger.setMockMethodCallHandler(
channel,
(_) async =>
++calls == 1 ? {'__json_file': file.path} : jsonEncode(collection()),
);
await expectLater(load(), throwsFormatException);
expect(await file.exists(), isFalse);
expect(await load(), collection());
expect(calls, 2);
});
test(
'nullable URL responses preserve null and reject encoded scalar strings',
() async {
for (final raw in ['null', jsonEncode(jsonEncode(collection()))]) {
messenger.setMockMethodCallHandler(channel, (_) async => raw);
expect(
await PlatformBridge.handleURLWithExtension(
'https://example.invalid/value',
),
isNull,
);
}
},
);
}