mirror of
https://github.com/zarzet/SpotiFLAC-Mobile.git
synced 2026-07-29 15:28:48 +02:00
zarzet
2fa4aa5b70
Stability: - transient timeouts no longer classified as ISP blocking; they fall through to retry backoff (hard blocks - DNS/RST/cert - still abort) - connectivity change now closes idle Go connections in every network mode (debounced), so pooled sockets from the old interface are not reused after a wifi/cellular handoff - download body reads get a 60s stall watchdog that cancels and surfaces a retryable network error instead of hanging; distinct from user cancellation - ResponseHeaderTimeout 45s on all transports; IdleConnTimeout 90->60s; dial timeout 30->10s; retry backoff gains full jitter; Retry-After honored on 5xx and Deezer 429 Data usage / speed: - cover downloads deduplicated with singleflight plus a 24MB/15min in-memory cache keyed by final URL (album batches fetched the same 1800px cover once per track before) - song.link availability cached (30min positive / 5min negative) in front of the 9-req/min rate limiter - uTLS Cloudflare path now pools one HTTP/2 connection per host with a shared TLS session cache instead of a full handshake per request Deezer artist track-count N+1 kept: counts feed the discography download UI and are already amortized by the artist TTL cache.
266 lines
9.7 KiB
Go
266 lines
9.7 KiB
Go
package gobackend
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"strings"
|
|
"sync/atomic"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
type roundTripFunc func(*http.Request) (*http.Response, error)
|
|
|
|
func (fn roundTripFunc) RoundTrip(req *http.Request) (*http.Response, error) {
|
|
return fn(req)
|
|
}
|
|
|
|
func TestGetRetryAfterDurationMissingHeaderReturnsZero(t *testing.T) {
|
|
resp := &http.Response{
|
|
Header: make(http.Header),
|
|
}
|
|
|
|
if got := getRetryAfterDuration(resp); got != 0 {
|
|
t.Fatalf("getRetryAfterDuration() = %v, want 0", got)
|
|
}
|
|
}
|
|
|
|
func resetTrackAvailabilityCache() {
|
|
trackAvailabilityCacheMu.Lock()
|
|
trackAvailabilityCache = map[string]trackAvailabilityCacheEntry{}
|
|
trackAvailabilityCacheMu.Unlock()
|
|
}
|
|
|
|
func TestCheckTrackAvailabilityFromSpotifyViaResolveAPI(t *testing.T) {
|
|
resetTrackAvailabilityCache()
|
|
origRetryConfig := songLinkRetryConfig
|
|
defer func() { songLinkRetryConfig = origRetryConfig }()
|
|
|
|
client := &SongLinkClient{
|
|
client: &http.Client{
|
|
Transport: roundTripFunc(func(req *http.Request) (*http.Response, error) {
|
|
if req.URL.Host == "api.zarz.moe" && req.URL.Path == "/v1/resolve" && req.Method == "POST" {
|
|
body := `{"success":true,"isrc":"USRC12345678","songUrls":{"Spotify":"https://open.spotify.com/track/testspotifyid","Deezer":"https://www.deezer.com/track/908604612","AmazonMusic":"https://music.amazon.com/albums/B086Q2QNLH?trackAsin=B086Q41M9C","Tidal":"https://listen.tidal.com/track/134858527","Qobuz":"https://open.qobuz.com/track/195125822","YouTubeMusic":"https://music.youtube.com/watch?v=testvideoid1"}}`
|
|
return &http.Response{
|
|
StatusCode: 200,
|
|
Header: make(http.Header),
|
|
Body: io.NopCloser(strings.NewReader(body)),
|
|
Request: req,
|
|
}, nil
|
|
}
|
|
t.Fatalf("unexpected request: %s %s", req.Method, req.URL.String())
|
|
return nil, nil
|
|
}),
|
|
},
|
|
}
|
|
|
|
availability, err := client.CheckTrackAvailability("testspotifyid", "")
|
|
if err != nil {
|
|
t.Fatalf("CheckTrackAvailability() error = %v", err)
|
|
}
|
|
|
|
if availability.SpotifyID != "testspotifyid" {
|
|
t.Fatalf("SpotifyID = %q, want %q", availability.SpotifyID, "testspotifyid")
|
|
}
|
|
if !availability.Deezer || availability.DeezerID != "908604612" {
|
|
t.Fatalf("Deezer availability = %+v, want DeezerID 908604612", availability)
|
|
}
|
|
if !availability.Amazon || !availability.Tidal || !availability.Qobuz || !availability.YouTube {
|
|
t.Fatalf("availability flags = %+v, want Amazon/Tidal/Qobuz/YouTube true", availability)
|
|
}
|
|
if availability.YouTubeID != "testvideoid1" {
|
|
t.Fatalf("YouTubeID = %q, want %q", availability.YouTubeID, "testvideoid1")
|
|
}
|
|
}
|
|
|
|
func TestCheckTrackAvailabilityFromSpotifyResolveAPIFailure(t *testing.T) {
|
|
resetTrackAvailabilityCache()
|
|
origRetryConfig := songLinkRetryConfig
|
|
songLinkRetryConfig = func() RetryConfig {
|
|
return RetryConfig{MaxRetries: 0, InitialDelay: 0, MaxDelay: 0, BackoffFactor: 1}
|
|
}
|
|
defer func() { songLinkRetryConfig = origRetryConfig }()
|
|
|
|
var hitSongLink bool
|
|
|
|
client := &SongLinkClient{
|
|
client: &http.Client{
|
|
Transport: roundTripFunc(func(req *http.Request) (*http.Response, error) {
|
|
// Resolve proxy returns 500
|
|
if req.URL.Host == "api.zarz.moe" && req.URL.Path == "/v1/resolve" {
|
|
return &http.Response{
|
|
StatusCode: 500,
|
|
Header: make(http.Header),
|
|
Body: io.NopCloser(strings.NewReader("internal error")),
|
|
Request: req,
|
|
}, nil
|
|
}
|
|
// SongLink fallback should be called
|
|
if req.URL.Host == "api.song.link" {
|
|
hitSongLink = true
|
|
body := `{"linksByPlatform":{"spotify":{"url":"https://open.spotify.com/track/testspotifyid"},"deezer":{"url":"https://www.deezer.com/track/908604612"},"tidal":{"url":"https://listen.tidal.com/track/134858527"}}}`
|
|
return &http.Response{
|
|
StatusCode: 200,
|
|
Header: make(http.Header),
|
|
Body: io.NopCloser(strings.NewReader(body)),
|
|
Request: req,
|
|
}, nil
|
|
}
|
|
t.Fatalf("unexpected request: %s %s", req.Method, req.URL.String())
|
|
return nil, nil
|
|
}),
|
|
},
|
|
}
|
|
|
|
availability, err := client.CheckTrackAvailability("testspotifyid", "")
|
|
if err != nil {
|
|
t.Fatalf("expected SongLink fallback to succeed, got error: %v", err)
|
|
}
|
|
if !hitSongLink {
|
|
t.Fatal("expected fallback request to SongLink API, but it was never called")
|
|
}
|
|
if !availability.Deezer || availability.DeezerID != "908604612" {
|
|
t.Fatalf("Deezer availability via fallback = %+v, want DeezerID 908604612", availability)
|
|
}
|
|
}
|
|
|
|
func TestCheckTrackAvailabilityFromSpotifyViaResolveAPIMixedSongURLShapes(t *testing.T) {
|
|
resetTrackAvailabilityCache()
|
|
origRetryConfig := songLinkRetryConfig
|
|
defer func() { songLinkRetryConfig = origRetryConfig }()
|
|
|
|
client := &SongLinkClient{
|
|
client: &http.Client{
|
|
Transport: roundTripFunc(func(req *http.Request) (*http.Response, error) {
|
|
if req.URL.Host == "api.zarz.moe" && req.URL.Path == "/v1/resolve" && req.Method == "POST" {
|
|
body := `{"success":true,"isrc":"TCAHA2367688","songUrls":{"Spotify":"https://open.spotify.com/track/5glgyj6zH0irbNGfukHacv","Deezer":"https://www.deezer.com/track/2248583177","Tidal":"https://tidal.com/browse/track/290565315","AppleMusic":"https://geo.music.apple.com/us/album/example?i=1","YouTubeMusic":null,"YouTube":"https://www.youtube.com/watch?v=wD_e59XUNdQ","AmazonMusic":"https://music.amazon.com/tracks/B0C35TG38Y/?ref=dm_ff_amazonmusic_3p","Beatport":null,"BeatSource":null,"SoundCloud":null,"Qobuz":null,"Other":[]}}`
|
|
return &http.Response{
|
|
StatusCode: 200,
|
|
Header: make(http.Header),
|
|
Body: io.NopCloser(strings.NewReader(body)),
|
|
Request: req,
|
|
}, nil
|
|
}
|
|
t.Fatalf("unexpected request: %s %s", req.Method, req.URL.String())
|
|
return nil, nil
|
|
}),
|
|
},
|
|
}
|
|
|
|
availability, err := client.CheckTrackAvailability("5glgyj6zH0irbNGfukHacv", "")
|
|
if err != nil {
|
|
t.Fatalf("CheckTrackAvailability() error = %v", err)
|
|
}
|
|
|
|
if availability.SpotifyID != "5glgyj6zH0irbNGfukHacv" {
|
|
t.Fatalf("SpotifyID = %q, want %q", availability.SpotifyID, "5glgyj6zH0irbNGfukHacv")
|
|
}
|
|
if !availability.Deezer || availability.DeezerID != "2248583177" {
|
|
t.Fatalf("Deezer availability = %+v, want DeezerID 2248583177", availability)
|
|
}
|
|
if !availability.Tidal || availability.TidalID != "290565315" {
|
|
t.Fatalf("Tidal availability = %+v, want TidalID 290565315", availability)
|
|
}
|
|
if availability.Qobuz {
|
|
t.Fatalf("Qobuz should remain false when resolve response contains null, got %+v", availability)
|
|
}
|
|
}
|
|
|
|
func TestCheckTrackAvailabilityCachesResult(t *testing.T) {
|
|
resetTrackAvailabilityCache()
|
|
origRetryConfig := songLinkRetryConfig
|
|
defer func() { songLinkRetryConfig = origRetryConfig }()
|
|
|
|
var calls int32
|
|
client := &SongLinkClient{
|
|
client: &http.Client{
|
|
Transport: roundTripFunc(func(req *http.Request) (*http.Response, error) {
|
|
atomic.AddInt32(&calls, 1)
|
|
body := `{"success":true,"songUrls":{"Spotify":"https://open.spotify.com/track/cachedid","Deezer":"https://www.deezer.com/track/111"}}`
|
|
return &http.Response{
|
|
StatusCode: 200,
|
|
Header: make(http.Header),
|
|
Body: io.NopCloser(strings.NewReader(body)),
|
|
Request: req,
|
|
}, nil
|
|
}),
|
|
},
|
|
}
|
|
|
|
first, err := client.CheckTrackAvailability("cachedid", "")
|
|
if err != nil {
|
|
t.Fatalf("first CheckTrackAvailability() error = %v", err)
|
|
}
|
|
second, err := client.CheckTrackAvailability("cachedid", "")
|
|
if err != nil {
|
|
t.Fatalf("second CheckTrackAvailability() error = %v", err)
|
|
}
|
|
|
|
if got := atomic.LoadInt32(&calls); got != 1 {
|
|
t.Fatalf("expected 1 network call with caching, got %d", got)
|
|
}
|
|
if first == second {
|
|
t.Fatal("expected cache to return a distinct clone, got same pointer")
|
|
}
|
|
if second.DeezerID != "111" {
|
|
t.Fatalf("cached DeezerID = %q, want 111", second.DeezerID)
|
|
}
|
|
}
|
|
|
|
func TestCheckTrackAvailabilityNegativeCacheTTL(t *testing.T) {
|
|
resetTrackAvailabilityCache()
|
|
|
|
entry := trackAvailabilityCacheEntry{err: true, expiresAt: time.Now().Add(-time.Second)}
|
|
key := GetSongLinkRegion() + "|spotify:expiredneg"
|
|
trackAvailabilityCacheMu.Lock()
|
|
trackAvailabilityCache[key] = entry
|
|
trackAvailabilityCacheMu.Unlock()
|
|
|
|
if _, hit, _ := trackAvailabilityCacheLookup(key); hit {
|
|
t.Fatal("expired negative entry should not be a cache hit")
|
|
}
|
|
}
|
|
|
|
func TestCheckAvailabilityFromDeezerUsesSongLink(t *testing.T) {
|
|
origRetryConfig := songLinkRetryConfig
|
|
songLinkRetryConfig = func() RetryConfig {
|
|
return RetryConfig{MaxRetries: 0, InitialDelay: 0, MaxDelay: 0, BackoffFactor: 1}
|
|
}
|
|
defer func() { songLinkRetryConfig = origRetryConfig }()
|
|
|
|
client := &SongLinkClient{
|
|
client: &http.Client{
|
|
Transport: roundTripFunc(func(req *http.Request) (*http.Response, error) {
|
|
// Non-Spotify should go to SongLink, not resolve API
|
|
if req.URL.Host == "api.zarz.moe" {
|
|
t.Fatalf("non-Spotify URL should not hit resolve API, got: %s", req.URL.String())
|
|
return nil, nil
|
|
}
|
|
if req.URL.Host == "api.song.link" {
|
|
body := `{"linksByPlatform":{"spotify":{"url":"https://open.spotify.com/track/testid"},"deezer":{"url":"https://www.deezer.com/track/908604612"},"tidal":{"url":"https://listen.tidal.com/track/134858527"},"qobuz":{"url":"https://open.qobuz.com/track/195125822"},"youtubeMusic":{"url":"https://music.youtube.com/watch?v=testvid"}}}`
|
|
return &http.Response{
|
|
StatusCode: 200,
|
|
Header: make(http.Header),
|
|
Body: io.NopCloser(strings.NewReader(body)),
|
|
Request: req,
|
|
}, nil
|
|
}
|
|
t.Fatalf("unexpected request: %s %s", req.Method, req.URL.String())
|
|
return nil, nil
|
|
}),
|
|
},
|
|
}
|
|
|
|
availability, err := client.checkAvailabilityFromDeezerSongLink("908604612")
|
|
if err != nil {
|
|
t.Fatalf("checkAvailabilityFromDeezerSongLink() error = %v", err)
|
|
}
|
|
|
|
if !availability.Deezer || availability.DeezerID != "908604612" {
|
|
t.Fatalf("Deezer = %+v, want DeezerID 908604612", availability)
|
|
}
|
|
if availability.SpotifyID != "testid" {
|
|
t.Fatalf("SpotifyID = %q, want %q", availability.SpotifyID, "testid")
|
|
}
|
|
}
|