From fcd1fd20ae897c759fd419ec9d2f8c867fa4ffc5 Mon Sep 17 00:00:00 2001
From: fei <204683769+feiiiiii5@users.noreply.github.com>
Date: Sun, 16 Aug 2026 18:23:29 +0800
Subject: [PATCH] fix(circuit-breaker): reopen on failure during half-open
 probation

record_failure ignored the half_open state: the minimum-sample gate
(total >= 10) and the success counter meant a failure during
probation neither re-opened the circuit nor prevented it from
closing. One failure followed by three successes closed the circuit
with the failure forgotten. Trip back to open on the first half-open
failure, with fresh counters.
---
 agentic_security/executor/circuit_breaker.py |  9 ++++
 tests/unit/executor/test_circuit_breaker.py  | 45 ++++++++++++++++++++
 2 files changed, 54 insertions(+)

diff --git a/agentic_security/executor/circuit_breaker.py b/agentic_security/executor/circuit_breaker.py
index bc96825..79c90e9 100644
--- a/agentic_security/executor/circuit_breaker.py
+++ b/agentic_security/executor/circuit_breaker.py
@@ -51,6 +51,15 @@ class CircuitBreaker:
 
     def record_failure(self):
         """Record a failed request."""
+        if self.state == "half_open":
+            # A single failure during probation trips the circuit back open
+            # with fresh counters, so the failure is not diluted by the
+            # minimum-sample gate or forgiven by later successes.
+            self.state = "open"
+            self.last_failure_time = time.monotonic()
+            self.failures = 0
+            self.successes = 0
+            return
         self.failures += 1
         self.last_failure_time = time.monotonic()
 
diff --git a/tests/unit/executor/test_circuit_breaker.py b/tests/unit/executor/test_circuit_breaker.py
index 1c8213a..9f12a49 100644
--- a/tests/unit/executor/test_circuit_breaker.py
+++ b/tests/unit/executor/test_circuit_breaker.py
@@ -119,6 +119,51 @@ class TestCircuitBreaker:
         # Should transition to closed
         assert breaker.state == "closed"
 
+    def test_half_open_failure_reopens_circuit(self):
+        """Test that a failure during half-open probation reopens the circuit."""
+        breaker = CircuitBreaker(failure_threshold=0.5, recovery_timeout=1)
+
+        # Open the circuit
+        for _ in range(4):
+            breaker.record_success()
+        for _ in range(6):
+            breaker.record_failure()
+        assert breaker.state == "open"
+
+        # Enter half-open after recovery timeout
+        time.sleep(1.1)
+        assert breaker.is_open() is False
+        assert breaker.state == "half_open"
+
+        # A single failure during probation trips the circuit back open
+        breaker.record_failure()
+        assert breaker.state == "open"
+        assert breaker.is_open() is True
+
+    def test_half_open_failure_not_forgotten_by_successes(self):
+        """Test that a half-open failure is not forgotten by later successes."""
+        breaker = CircuitBreaker(failure_threshold=0.5, recovery_timeout=1)
+
+        # Open the circuit
+        for _ in range(4):
+            breaker.record_success()
+        for _ in range(6):
+            breaker.record_failure()
+        assert breaker.state == "open"
+
+        # Enter half-open after recovery timeout
+        time.sleep(1.1)
+        breaker.is_open()
+        assert breaker.state == "half_open"
+
+        # One failure followed by enough successes to close a healthy circuit
+        breaker.record_failure()
+        for _ in range(3):
+            breaker.record_success()
+
+        # The failure must keep the circuit open
+        assert breaker.state == "open"
+
     def test_get_state(self):
         """Test get_state method."""
         breaker = CircuitBreaker()