mirror of
https://github.com/tdurieux/anonymous_github.git
synced 2026-11-17 17:44:09 +01:00
fix(anonymize): one message and one next step when a source fails to load
A repository URL that could not be read produced a pile of messages: "Does not exist or is not accessible", a "Repository not listed?" label, two access notes, a private-content warning, an empty branch/commit grid with "The commit SHA is not valid", a toast, and an enabled-looking "Create anonymous link" whose reason pointed to the preview. - Under the URL, one error block per case (malformed URL, missing or no access, organization restriction or SSO, already anonymized), naming the source and giving its fix: Manage GitHub access and Try again. The preview shows the same wording and actions; no toast. - Drop "Repository not listed?". The landing picker gets a quiet "Don't see your repository? Manage GitHub access" link instead. - New anonymizations hide branch/commit, auto-update and the other sections until the source loads. Edit mode keeps them editable. - The publication warning shows only once a private source has loaded; the repository metadata now includes GitHub's `private` flag. - The primary button is disabled until the source loads, with a short local reason, and the draft line waits for a loaded source. - dev-mock: failing, slow, PR, gist and edit-mode fixtures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
3fbf2cbad7
commit
1412de9d9f
11 files changed
+219
-138
No files matched your search
+26
-1
@@ -277,6 +277,8 @@ app.get("/api/user/quota", (req, res) => res.json(quota));
|
||||
app.get("/api/user/anonymized_repositories", (req, res) => res.json(repositories));
|
||||
app.get("/api/user/anonymized_pull_requests", (req, res) => res.json(pullRequests));
|
||||
app.get("/api/user/anonymized_gists", (req, res) => res.json(gists));
|
||||
// The landing picker: repositories the GitHub App can read.
|
||||
app.get("/api/user/all_repositories", (req, res) => res.json(["jsmith/robust-repair", "jsmith/thesis-code", "tdurieux/anonymous_github", "acme-lab/benchmarks"].map((fullName, i) => ({ id: "r" + i, fullName }))));
|
||||
app.get("/api/user/default", (req, res) =>
|
||||
res.json({ terms: ["Jane Smith", "MIT CSAIL", "jsmith"], options: { link: true, image: true, pdf: true, notebook: true, loc: true, page: false, update: false, mode: "GitHubStream", expirationMode: "remove" } })
|
||||
);
|
||||
@@ -457,7 +459,7 @@ const sourceAccess = (req, res) => {
|
||||
const SOURCE_BASE = `/api/repo/${SOURCE.owner}/${SOURCE.repo}`;
|
||||
app.get(SOURCE_BASE + "/", (req, res) => res.json({
|
||||
id: "mock-source-1", externalId: "gh_910001", repo: SOURCE.repo, owner: SOURCE.owner,
|
||||
hasPage: false, fullName: `${SOURCE.owner}/${SOURCE.repo}`, defaultBranch: "main", size: 2048,
|
||||
hasPage: false, private: true, fullName: `${SOURCE.owner}/${SOURCE.repo}`, defaultBranch: "main", size: 2048,
|
||||
}));
|
||||
app.get(SOURCE_BASE + "/branches", (req, res) => res.json([
|
||||
{ name: "main", commit: SOURCE.commit, readme: sourceText["README.md"] },
|
||||
@@ -484,6 +486,29 @@ app.get(SOURCE_BASE + "/file", (req, res) => {
|
||||
res.type("text/plain; charset=utf-8").send(sourceText[file]);
|
||||
}, Number(process.env.MOCK_FILE_DELAY || 150));
|
||||
});
|
||||
// Source URLs that fail, for the workspace's source error states:
|
||||
// jsmith/missing-repo not found, or the GitHub App was not given access
|
||||
// acme-lab/restricted-tool the organization restricts third-party access
|
||||
// jsmith/slow-repo never answers within a capture (loading state)
|
||||
// plus a pull request and a gist that cannot be read.
|
||||
const failingSources = { "jsmith/missing-repo": [404, "repo_not_found"], "acme-lab/restricted-tool": [403, "repo_access_limited"] };
|
||||
app.get("/api/repo/:owner/:repo/{*rest}", (req, res, next) => {
|
||||
const name = `${req.params.owner}/${req.params.repo}`;
|
||||
if (name === "jsmith/slow-repo") return global.setTimeout(() => res.status(404).json({ error: "repo_not_found" }), 120000);
|
||||
const failure = failingSources[name];
|
||||
if (!failure) return next();
|
||||
res.status(failure[0]).json({ error: failure[1] });
|
||||
});
|
||||
app.get("/api/pr/jsmith/missing-repo/:id", (req, res) => res.status(404).json({ error: "pull_request_not_found" }));
|
||||
app.get("/api/gist/source/:id", (req, res) => res.status(404).json({ error: "gist_not_found" }));
|
||||
// Edit mode: one saved anonymization whose source loads, one whose source no longer does.
|
||||
const editFixture = (repoId, fullName) => ({
|
||||
repoId, status: "ready", role: "owner", connection: "github-app", anonymizeDate: ago(12), coauthors: [],
|
||||
source: { type: "GitHubStream", fullName, branch: "main", commit: SOURCE.commit },
|
||||
options: opts({ terms: ["Jane Smith", "MIT CSAIL", "jsmith"], expirationDate: ahead(160) }),
|
||||
});
|
||||
app.get("/api/repo/robust-repair-preview", (req, res) => res.json(editFixture("robust-repair-preview", `${SOURCE.owner}/${SOURCE.repo}`)));
|
||||
app.get("/api/repo/missing-repo-4F2A", (req, res) => res.json(editFixture("missing-repo-4F2A", "jsmith/missing-repo")));
|
||||
// Use the production anonymizer for both sides of the visual comparison.
|
||||
require("ts-node/register/transpile-only");
|
||||
const { ContentAnonimizer } = require("../src/core/anonymize-utils");
|
||||
|
||||
Reference in new issue
Block a user