fix: preserve local stream failure provenance

This commit is contained in:
Thomas Durieux committed 2026-11-15 13:36:34 +00:00
1 parent d2e3954d21
commit 42494debb9
3 files changed
+44 -6

No files matched your search

+3 -3
View File
@@ -1,4 +1,4 @@
import { recordUpstreamFailure } from "./request-evidence";
import { recordResponseFailure } from "./request-evidence";
import { rejectStreamerRedirects } from "./streamer-response";
import { isResponseCancellation } from "./response-cancellation";
import { canReadCachedRepository } from "./cached-repository-access";
@@ -586,9 +586,9 @@ export default class AnonymizedFile {
reject(error);
}
content
.on("error", error => { if (!res.destroyed) recordUpstreamFailure(res, error); handleStreamError(error); })
.on("error", error => { if (!res.destroyed) recordResponseFailure(res, "unknown", "local_abort"); handleStreamError(error); })
.pipe(anonymizer)
.on("error", handleStreamError)
.on("error", error => { if (!res.destroyed) recordResponseFailure(res, "api", "local_abort"); handleStreamError(error); })
.pipe(res)
.on("error", handleStreamError)
.on("finish", () => {
+3 -3
View File
@@ -1,4 +1,4 @@
import { recordUpstreamFailure } from "../core/request-evidence";
import { recordResponseFailure } from "../core/request-evidence";
import { sendSharedContent } from "../core/cached-response";
import * as express from "express";
import GitHubStream from "../core/source/GitHubStream";
@@ -126,9 +126,9 @@ router.post("/", async (req: express.Request, res: express.Response) => {
anonymizer.destroy();
}
content
.on("error", error => { if (!res.destroyed) recordUpstreamFailure(res, error); handleStreamError(error); })
.on("error", error => { if (!res.destroyed) recordResponseFailure(res, "unknown", "local_abort"); handleStreamError(error); })
.pipe(anonymizer)
.on("error", handleStreamError)
.on("error", error => { if (!res.destroyed) recordResponseFailure(res, "streamer", "local_abort"); handleStreamError(error); })
.pipe(res)
.on("error", handleStreamError)
.on("close", () => {