CalvinBackup/anonymous_github
1
0
Fork 0
mirror of https://github.com/tdurieux/anonymous_github.git synced 2026-09-12 13:48:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: restrict S3 deletion to exact keys and descendants

Browse Source
This commit is contained in:
tdurieux
2026-09-06 09:18:37 +02:00
parent 5e84bfaa5b
commit 6777537d44
2 changed files with 43 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/production-regressions.test.js
+14
View File
@@ -85,6 +85,20 @@ describe("production regressions", function () {
const storage = new S3(); storage.client = () => client; storage.repoPath = () => "repo";
return storage;
}
it("deletes only exact S3 keys and descendants across pages", async function () {
const deleted = []; const tokens = [];
const storage = s3({
listObjectsV2: async ({ ContinuationToken }) => {
tokens.push(ContinuationToken);
return ContinuationToken ? { Contents: [{ Key: "repo/data/a" }, { Key: "repo/database" }] } :
{ Contents: [{ Key: "repo/data.csv" }, { Key: "repo/data" }], IsTruncated: true, NextContinuationToken: "next" };
},
deleteObjects: async ({ Delete }) => { deleted.push(...Delete.Objects.map(x => x.Key)); return {}; },
});
await storage.rm("repo", "data");
expect(tokens).to.deep.equal([undefined, "next"]);
expect(deleted).to.deep.equal(["repo/data", "repo/data/a"]);
});
it("rejects S3 per-object deletion failures", async function () {
const storage = s3({
listObjectsV2: async () => ({ Contents: [{ Key: "repo/data" }] }),