diff --git a/src/core/source/GitHubRepository.ts b/src/core/source/GitHubRepository.ts index 41d9e52..92512a6 100644 --- a/src/core/source/GitHubRepository.ts +++ b/src/core/source/GitHubRepository.ts @@ -66,7 +66,7 @@ export class GitHubRepository { const status = (error as { status?: number }).status; if (status === 404) { // Distinguish: does the repo itself still exist? - let repoExists = false; + let repoExists: boolean; try { await oct.repos.get({ owner: this.owner, repo: this.repo }); repoExists = true; diff --git a/src/server/routes/admin.ts b/src/server/routes/admin.ts index 4f353b7..233b56e 100644 --- a/src/server/routes/admin.ts +++ b/src/server/routes/admin.ts @@ -5,7 +5,6 @@ import AnonymizedRepositoryModel from "../../core/model/anonymizedRepositories/a import ConferenceModel from "../../core/model/conference/conferences.model"; import UserModel from "../../core/model/users/users.model"; import { cacheQueue, downloadQueue, removeQueue } from "../../queue"; -import Repository from "../../core/Repository"; import User from "../../core/User"; import { ensureAuthenticated } from "./connection"; import { handleError, getUser, isOwnerOrAdmin, getRepo } from "./route-utils"; diff --git a/src/server/routes/repository-private.ts b/src/server/routes/repository-private.ts index ab865d9..fa0eb2b 100644 --- a/src/server/routes/repository-private.ts +++ b/src/server/routes/repository-private.ts @@ -13,7 +13,6 @@ import { getRepositoryFromGitHub } from "../../core/source/GitHubRepository"; import gh = require("parse-github-url"); import AnonymizedRepositoryModel from "../../core/model/anonymizedRepositories/anonymizedRepositories.model"; import { IAnonymizedRepositoryDocument } from "../../core/model/anonymizedRepositories/anonymizedRepositories.types"; -import Repository from "../../core/Repository"; import UserModel from "../../core/model/users/users.model"; import ConferenceModel from "../../core/model/conference/conferences.model"; import AnonymousError from "../../core/AnonymousError"; @@ -622,7 +621,7 @@ router.post( try { const r = await oct.users.getByUsername({ username }); ghUser = r.data; - } catch (e) { + } catch { throw new AnonymousError("github_user_not_found", { object: { username }, httpStatus: 404, diff --git a/test/lfs-detect.test.js b/test/lfs-detect.test.js index 3d048f0..631b81a 100644 --- a/test/lfs-detect.test.js +++ b/test/lfs-detect.test.js @@ -1,5 +1,4 @@ const { expect } = require("chai"); -const { Readable } = require("stream"); // Standalone test of the LFS-pointer detection shape used in // GitHubStream#resolveLfsPointer. We can't easily import that method (it's