Standardize error responses with consistent format and human-readable messages (#667)

src/core/PullRequest.ts

@@ -114,7 +114,7 @@ export default class PullRequest {
       this.status == "removing" ||
       this.status == "removed"
     ) {
-      throw new AnonymousError("pullRequest_expired", {
+      throw new AnonymousError("pull_request_expired", {
         object: this,
         httpStatus: 410,
       });
@@ -126,8 +126,9 @@ export default class PullRequest {
       this.status == "preparing" ||
       (this.status == "download" && this._model.statusDate > fiveMinuteAgo)
     ) {
-      throw new AnonymousError("pullRequest_not_ready", {
+      throw new AnonymousError("pull_request_not_ready", {
         object: this,
+        httpStatus: 503,
       });
     }
   }

src/core/Repository.ts

@@ -220,6 +220,7 @@ export default class Repository {
     ) {
       throw new AnonymousError("repository_not_ready", {
         object: this,
+        httpStatus: 503,
       });
     }
   }
@@ -356,6 +357,7 @@ export default class Repository {
           await this.resetSate();
           throw new AnonymousError("branch_not_found", {
             object: this,
+            httpStatus: 404,
           });
         }
         this._model.anonymizeDate = new Date();

src/core/storage/S3.ts

@@ -127,7 +127,7 @@ export default class S3Storage extends StorageBase {
       }
     } catch {
       try {
-        res.status(500);
+        res.status(500).json({ error: "file_not_found" });
       } catch (err) {
         console.error(`[ERROR] S3 send ${path}`, err);
       }