fix: record cached reader failures before pipeline teardown

This commit is contained in:
Thomas Durieux committed 2026-11-15 13:39:17 +00:00
1 parent 42494debb9
commit a4f441f097
4 files changed
+34 -4

No files matched your search

+7 -1
View File
@@ -1,3 +1,4 @@
import { recordResponseFailure } from "./request-evidence";
import { createGzip } from "zlib";
import { createHash } from "crypto";
import { Readable, PassThrough } from "stream";
@@ -49,9 +50,14 @@ async function sendCached(content: Readable, res: Response,
if (isText && !res.getHeader("Content-Type")) res.type("text/plain");
if (isText) res.setHeader("Accept-Ranges", "none");
else res.removeHeader("Accept-Ranges");
// Install evidence before pipeline's listeners destroy the response.
const localFailure = () => { if (!res.destroyed) recordResponseFailure(res, "unknown", "local_abort"); };
stream.once("error", localFailure);
if (record.encoding === "identity" && !res.req.acceptsEncodings("identity")) {
res.setHeader("Content-Encoding", "gzip"); res.removeHeader("Content-Length");
await pipeline(stream, createGzip(), res);
const gzip = createGzip();
gzip.once("error", localFailure);
await pipeline(stream, gzip, res);
} else await pipeline(stream, res);
return true;
};
+2
View File
@@ -785,6 +785,7 @@ export const LOG_SOURCE_FUNCTIONS: Record<string, readonly string[]> = {
"abort",
"assertActive",
"decisionKey",
"localFailure",
"send",
"sendCached",
"sendSharedContent"
@@ -794,6 +795,7 @@ export const LOG_SOURCE_FUNCTIONS: Record<string, readonly string[]> = {
"abort",
"assertActive",
"decisionKey",
"localFailure",
"send",
"sendCached",
"sendSharedContent"