CalvinBackup/anonymous_github
1
0
Fork 0
mirror of https://github.com/tdurieux/anonymous_github.git synced 2026-09-15 07:05:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: sanitize Org previews before trusting rendered HTML

Browse Source
This commit is contained in:
tdurieux
2026-09-06 10:46:44 +02:00
parent cf58aa330b
commit b2dfda1838
4 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/asset-manifest.json
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"core.min.js": "core.6332b3c288.min.js", "core.min.js": "core.6332b3c288.min.js",
"vendor.min.js": "vendor.a5d94d956f.min.js", "vendor.min.js": "vendor.1020f4867e.min.js",
"mermaid.min.js": "mermaid.f848a72d16.min.js", "mermaid.min.js": "mermaid.f848a72d16.min.js",
"all.min.css": "all.99ce8f3e14.min.css" "all.min.css": "all.99ce8f3e14.min.css"
} }
public/script/app.js
+1 -1
View File
@@ -2961,7 +2961,7 @@ angular
suppressSubScriptHandling: true, suppressSubScriptHandling: true,
suppressAutoLink: false, suppressAutoLink: false,
}); });
$scope.content = $sce.trustAsHtml(orgHTMLDocument.toString()); $scope.content = $sce.trustAsHtml(DOMPurify.sanitize(orgHTMLDocument.toString()));
$scope.type = "html"; $scope.type = "html";
} }
if ( if (
public/script/vendor.min.js
Vendored
+1 -1
View File
File diff suppressed because one or more lines are too long
test/frontend-regressions.test.js
+8
View File
@@ -66,4 +66,12 @@ describe("frontend production regressions", function () {
expect(template).to.include("treeNodes"); expect(template).to.include("treeNodes");
expect(h.scope.treeNodes[0].path).to.equal("/constructor/index.js"); expect(h.scope.treeNodes[0].path).to.equal("/constructor/index.js");
}); });
it("sanitizes Org output before trusting it", async function () {
const h = explorer(); let untrusted;
h.context.Org = { Parser: function () { this.parse = () => ({ convert: () => ({ toString: () => '<img onerror="probe()">' }) }); }, ConverterHTML: {} };
h.context.contentAbs2Relative = x => x;
h.context.DOMPurify = { sanitize: html => { untrusted = html; return "sanitized"; } };
h.navigate("file.org"); h.requests.at(-1).resolve({ data: "org source", headers: () => "text/plain" }); await h.flush();
expect(untrusted).to.include("onerror"); expect(h.scope.content).to.equal("sanitized");
});
}); });