Merge remote-tracking branch 'origin/main' into integrate/source-errors

# Conflicts:
#	public/asset-manifest.json
#	public/css/all.min.css
#	public/script/vendor.min.js
This commit is contained in:
Thomas Durieux committed 2026-11-14 23:23:19 +00:00
commit bc44879b43
24 files changed
+3370 -73

No files matched your search

+73
View File
@@ -0,0 +1,73 @@
const {expect}=require('chai');
const path=require('path');
const {Response}=globalThis;
require('ts-node/register/transpile-only');
const {errorDiagnostics,safeDiagnosticFields}=require('../src/core/log-diagnostics');
const {serializeError}=require('../src/core/logger');
const {logRecord}=require('../src/core/log-record');
const {logContext}=require('../src/core/log-context');
const {requestReproduction,safeReproductionPath}=require('../src/core/log-reproduction');
const {requestRoute}=require('../src/core/request-monitoring');
const {safeRedisLog,investigateLogs,logOptions}=require('../src/server/admin-log-investigation');
const secret='PRIVATE_TOKEN_owner_filename';
const frame='at printError (src/server/routes/route-utils.ts:200:7)';
function failure(){ const error=new TypeError('https://user:'+secret+'@github.com/private/repo?token='+secret); error.stack=error.message+'\n at printError ('+path.resolve('src/server/routes/route-utils.ts')+':200:7)\n at '+secret+' ('+path.resolve('src/server/routes/route-utils.ts')+':201:9)\n at secret (/home/private/'+secret+':1:2)\n at fn (https://private/'+secret+':1:2)';return error; }
describe('safe actionable exception diagnostics',()=>{
it('keeps bounded anonymous file request context for failures without queries or unsafe paths',()=>{
const requestPath='/api/repo/demo-123/file/docs/reproduce%20issue.md';
expect(requestReproduction(requestPath+'?token=SECRET')).deep.equal({requestPath,repoId:'demo-123'});
for(const value of ['/api/repo/owner/name/readme','https://example.test'+requestPath,requestPath+'?token=SECRET','/api/repo/demo-123/file/%0aSECRET','/api/repo/demo-123/file/../secret','/api/repo/demo-123/file/%252e%252e/secret','/api/repo/demo-123/file/https%3a%2f%2fuser:token@example.test','/api/repo/demo-123/file/'+ 'x'.repeat(2048)]) expect(safeReproductionPath(value),value).equal(undefined);
expect(logContext.run({requestPath},()=>logRecord('info','route',['request',{status:200}]))).not.have.property('requestPath');
const record=logContext.run({requestPath},()=>logRecord('error','route',['failure',{httpStatus:500}]));
expect(record).include({requestPath,repoId:'demo-123'});
expect(safeRedisLog({ts:record.timestamp,level:'error',module:'route',raw:[record]}).raw[0]).include({requestPath,repoId:'demo-123'});
});
it('preserves dotted allowlisted source files and anonymous/named async frames',()=>{
const error=new Error(secret);
error.stack='Error: '+secret+'\n at async '+path.resolve('src/server/routes/repository-public.ts')+':224:23\n at async printError ('+path.resolve('src/server/routes/route-utils.ts')+':200:7)\n at '+path.resolve('src/core/model/owner-alert-lifecycle.schema.ts')+':12:3\n at async https://'+secret+':1:2';
const record=logRecord('error','route',['',serializeError(error)]);
expect(record.errorStack).include('at <anonymous> (src/server/routes/repository-public.ts:224:23)').and.include(frame).and.include('at <anonymous> (src/core/model/owner-alert-lifecycle.schema.ts:12:3)');
const redis=safeRedisLog({ts:record.timestamp,level:'error',module:'route',raw:[record]});expect(redis.raw[0].errorStack).equal(record.errorStack);
expect(safeDiagnosticFields({errorStack:'at <anonymous> (src/core/model/not-allowlisted.schema.ts:12:3)'})).deep.equal({});
expect(JSON.stringify(record)).not.include(secret);
error.stack='Error: '+secret+'\n at external ('+path.resolve('node_modules/dependency/index.js')+':1:2)\n at async '+path.resolve('src/server/routes/repository-public.ts')+':224:23';
expect(errorDiagnostics(error).errorStack).equal('at <anonymous> (src/server/routes/repository-public.ts:224:23)');
});
it('retains only recognized source frames and types, never messages, URLs or roots',()=>{
const result=errorDiagnostics(failure());
expect(result.errorType).equal('TypeError'); expect(result.errorStack).include(frame).and.include('at <anonymous>');
expect(JSON.stringify(result)).not.include(secret).and.not.include(process.cwd()).and.not.include('https:');
const payload=serializeError(failure()); expect(logRecord('error','route',['failure',payload]).errorStack).include(frame);
});
it('bounds nested causes and frames, tolerates cycles/getters and rejects forged diagnostics',()=>{
const error=failure();error.cause=failure();error.cause.cause=error;
const result=errorDiagnostics(error);expect(result.causeType).equal('TypeError');expect(result.causeStack).include(frame);
error.cause.cause={name:secret,cause:error};
expect(errorDiagnostics(error)).include({causeType:'UnknownError'}).and.not.have.property('causeStack');
error.stack='Error\n'+Array(40).fill(' at printError ('+path.resolve('src/server/routes/route-utils.ts')+':200:7)').join('\n');
expect(errorDiagnostics(error).errorStack.split('\n')).length(8);
const hostile={};Object.defineProperty(hostile,'stack',{get(){throw Error('must not run')}});
expect(errorDiagnostics(hostile)).deep.equal({errorType:'UnknownError'});
expect(safeDiagnosticFields({errorType:secret,errorStack:frame+'\n'+secret+'\r\n at unknown (src/private.ts:1:2)',causeStack:'x'.repeat(5000)})).deep.equal({errorStack:frame});
});
it('carries normalized method/route through route errors and safe Redis projection',()=>{
const route=requestRoute('/api/repo/'+secret+'/file/private.txt?token='+secret,'api');
expect(route).equal('/api/repo/:repoId/file/:path');
const record=logContext.run({method:'GET',route},()=>logRecord('error','route',['failure',{...serializeError(failure()),httpStatus:500}]));
expect(record).include({route,method:'GET',httpStatus:500,errorType:'TypeError'});
const row=safeRedisLog({ts:new Date().toISOString(),level:'error',module:'route',raw:[record]});
expect(row.raw[0]).include({route,method:'GET',httpStatus:500,errorType:'TypeError',errorStack:record.errorStack});
expect(JSON.stringify(row)).not.include(secret);
expect(logRecord('error','route',['',{route:'/private/'+secret,method:'GET\n'+secret}])).not.have.property('route');
});
it('preserves the same diagnostics in correlated central events and rejects unsafe fields',async()=>{
const oldFetch=global.fetch, oldUrl=process.env.ADMIN_LOG_URL;
try{
process.env.ADMIN_LOG_URL='http://logs.test:9428';
global.fetch=async()=>new Response(JSON.stringify({_time:new Date().toISOString(),service:'api',event:'application_log',module:'route',severity:'error',route:'/api/repo/:repoId',method:'GET',errorType:'TypeError',errorStack:frame,causeType:secret,stack:secret,url:secret,httpStatus:500}));
const result=await investigateLogs(logOptions({kind:'requestId',id:'aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa'},true),true);
expect(result.events[0]).include({route:'/api/repo/:repoId',method:'GET',errorType:'TypeError',errorStack:frame,httpStatus:500});
expect(JSON.stringify(result)).not.include(secret);
}finally{global.fetch=oldFetch;if(oldUrl===undefined)delete process.env.ADMIN_LOG_URL;else process.env.ADMIN_LOG_URL=oldUrl;}
});
});
+12
View File
@@ -35,6 +35,18 @@ describe("bounded request monitoring", function () {
});
async function listen() { server = await new Promise(resolve => { const s = app.listen(0, "127.0.0.1", () => resolve(s)); }); }
it("captures failed file reproduction context without changing metric labels or retaining queries", async function () {
const {logRecord}=require('../src/core/log-record');
const records=[];
app.get('/api/repo/:repoId/file/*path',(req,res)=>{
records.push(logRecord('error','route',['failure',{httpStatus:500}]));res.status(500).end();
});
await listen(); await fetch(server,'/api/repo/demo-123/file/docs/reproduce%20issue.md?token=NEVER_CAPTURE');
expect(records[0]).include({repoId:'demo-123',requestPath:'/api/repo/demo-123/file/docs/reproduce%20issue.md',route:'/api/repo/:repoId/file/:path'});
expect(JSON.stringify(records)).not.include('NEVER_CAPTURE');
expect(metrics.drain().every(row=>!JSON.stringify(row).includes('demo-123'))).equal(true);
});
it("keeps labels bounded and removes source identities and query values", function () {
expect(requestRoute("/api/repo/private-name/file/secret.txt?token=abc", "api")).to.equal("/api/repo/:repoId/file/:path");
expect(requestRoute("/api/repo/secret-owner/secret-repo/readme?branch=secret", "api")).to.equal("/api/repo/:owner/:repo/readme");
+13
View File
@@ -98,6 +98,19 @@ describe('structured logging privacy and context', function () {
`], {env: {...process.env, LOG_REDIS_MIRROR: 'on'}, encoding: 'utf8', timeout: 10000});
expect(child.status, child.stderr).to.equal(0);
});
it('keeps exact reproduction and a frame when Redis payload clamping reduces diagnostics', () => {
const child = spawnSync(process.execPath, ['-r','ts-node/register/transpile-only','-e', `
const assert=require('node:assert/strict'),redis=require('redis');let payload;
const tx={lPush(key,value){payload=value;return tx;},lTrim(){return tx;},hIncrBy(){return tx;},expire(){return tx;},exec(){return Promise.resolve([]);}};
redis.createClient=()=>({isReady:true,isOpen:true,on(){},connect(){return Promise.resolve();},multi(){return tx;}});
const requestPath='/api/repo/demo-123/file/'+ 'a'.repeat(1950);
const frame='at <anonymous> (src/core/model/owner-alert-lifecycle.schema.ts:123456:12345)';
const stack=Array(8).fill(frame).join('\\n');
require('./src/core/logger').createLogger('route').error('failure',{...Object.fromEntries(['ms','firstByteMs','responseMs','bytes','bytesPerSecond','attempt','rss','memoryLimitBytes','memoryRatio','uptime','activeRequests','waiting','active','delayed','failed','oldestWaitingMs','droppedLogs','loopP95Ms','upstreamStatus'].map(key=>[key,Number.MAX_VALUE])),requestPath,errorType:'TypeError',errorStack:stack,causeType:'Error',causeStack:stack,httpStatus:500});
assert(payload.length<=4096);const row=JSON.parse(payload).raw[0];assert.equal(row.requestPath,requestPath);assert.equal(row.repoId,'demo-123');assert.equal(row.errorStack,frame);
`],{env:{...process.env,LOG_REDIS_MIRROR:'on'},encoding:'utf8',timeout:10000});
expect(child.status,child.stderr).equal(0);
});
it('writes JSON without Redis and bounds a blocked stdout pipe', () => {
const child = spawnSync(process.execPath, ['-r', 'ts-node/register/transpile-only', '-e', `
const { createLogger, getDroppedOutput } = require('./src/core/logger');
+45
View File
@@ -81,6 +81,51 @@ describe("Vue 3 UI", function () {
let ui;
afterEach(() => ui?.close());
it("renders useful history occurrences with visible times and selected tabs", async () => {
const entries=[0,2,1].map(n=>({ts:new Date(Date.UTC(2026,10,14,12,n)).toISOString(),level:'error',module:'route',message:'application_log',raw:[{event:'application_log',service:'api',httpStatus:500,...(n===2?{method:'GET',route:'/api/repo/:repoId/file/:path'}:{})}]}));
ui=await browser('/',{'/api/user':{username:'admin',isAdmin:true,status:'ready'},'/api/admin/errors':{available:true,total:3,entries},'/api/admin/errors/investigation':{state:'disabled',groups:[]}});
await ui.go('/admin/errors'); const doc=ui.window.document;
doc.querySelector('#error-source-history').click();await delay(20);
doc.querySelector('button.errors-row-main').click();await delay(20);
const tab=[...doc.querySelectorAll('.history-source .detail-tabs button')].find(b=>b.textContent.startsWith('Occurrences'));
tab.click();await delay(20);
expect(tab.getAttribute('aria-pressed')).equal('true');expect(tab.classList.contains('active')).equal(true);
const items=[...doc.querySelectorAll('.history-occurrence-list li')];expect(items).length(3);
expect(items.map(item=>item.querySelector('time').getAttribute('datetime'))).deep.equal([entries[1].ts,entries[2].ts,entries[0].ts]);
expect(items[0].textContent).include('GET /api/repo/:repoId/file/:path');
expect(items[1].textContent).include('Request route was not captured.').and.include('Exception frames were not captured.');
expect(items[0].querySelector('time').classList.contains('when-abs')).equal(false);
const record=items[0].querySelector('details');record.querySelector('summary').click();expect(record.open).equal(true);
expect(record.querySelector('.history-occurrence-record pre').textContent).include('application_log');expect(ui.errors).deep.equal([]);
});
it("shows normalized request routes and exception frames in both admin sources", async () => {
const now=new Date().toISOString(), requestId='aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa';
const sample={event:'application_log',service:'api',module:'route',severity:'error',httpStatus:500,method:'GET',route:'/api/repo/:repoId/file/:path',repoId:'demo-123',requestPath:'/api/repo/demo-123/file/docs/reproduce%20issue.md',errorType:'TypeError',errorStack:'at printError (build/server/routes/route-utils.js:200:7)',causeType:'RangeError',causeStack:'at <anonymous> (build/core/repository.js:410:9)',requestId};
ui=await browser('/',{
'/api/user':{username:'admin',isAdmin:true,status:'ready'},
'/api/admin/errors/investigation':{state:'ready',window:'1h',groups:[{fingerprint:'diagnostic',count:1,sample,first:now,last:now}]},
'/api/admin/errors/correlation':{state:'ready',events:[{...sample,timestamp:now}]},
'/api/admin/errors':{available:true,total:1,entries:[{ts:now,level:'error',module:'route',message:'TypeError',raw:[sample]}]},
});
await ui.go('/admin/errors');const doc=ui.window.document;
doc.querySelector('.log-event-button').click();await delay(30);
expect(doc.querySelector('#log-detail-title').textContent).equal('TypeError');
expect(doc.querySelector('.log-timeline .log-request-route').textContent).include('GET '+sample.requestPath);
expect(doc.querySelector('.log-reproduction').textContent).include('demo-123').and.include(sample.requestPath);
let copiedPath;Object.defineProperty(ui.window.navigator,'clipboard',{configurable:true,value:{writeText:async value=>{copiedPath=value;}}});
doc.querySelector('.log-reproduction button').click();await delay(10);expect(copiedPath).equal(sample.requestPath);
const frames=doc.querySelector('.log-timeline .log-error-stack');expect(frames.open).equal(false);
frames.querySelector('summary').click();expect(frames.open).equal(true);
expect(frames.textContent).include(sample.errorStack).and.include('RangeError').and.include(sample.causeStack);
doc.querySelector('#error-source-history').click();await delay(20);
doc.querySelector('button.errors-row-main').click();await delay(20);
expect(doc.querySelector('.history-source .log-request-route').textContent).include(sample.route);
[...doc.querySelectorAll('.history-source .detail-tabs button')].find(b=>b.textContent==='Stack').click();await delay(20);
expect(doc.querySelector('.stack-pre').textContent).include(sample.errorStack).and.include(sample.causeStack);
expect(ui.errors).deep.equal([]);
});
it("investigates grouped admin logs with bounded filters and a safe correlated timeline", async () => {
const requestId = "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa";
const now = new Date().toISOString();