fix: send one access alert per repository until owner action

This commit is contained in:
Thomas Durieux committed 2026-10-09 07:38:52 +00:00
1 parent c55efd14ed
commit d519a0a9bb
19 files changed
+172 -116

No files matched your search

+2
View File
@@ -1,3 +1,4 @@
import { resetOwnerAccessAlerts } from "../../core/owner-notifications";
import { createClient } from "redis";
import * as passport from "passport";
import * as session from "express-session";
@@ -120,6 +121,7 @@ export const verify = async (
return;
}
await setCredential(String(user!._id), accessToken);
await resetOwnerAccessAlerts(String(user!._id));
done(null, { username: user!.username, user });
} catch (error) {
logger.error("verify failed", serializeError(error));
+4
View File
@@ -1,3 +1,4 @@
import { resetOwnerAccessAlerts } from "../../core/owner-notifications";
import * as express from "express";
import { ensureAuthenticated } from "./connection";
@@ -29,6 +30,7 @@ router.post(
const user = await getUser(req);
isOwnerOrAdmin([gist.owner.id], user);
if (user.id === gist.owner.id) await resetOwnerAccessAlerts(user.id, { kind: "gist", id: String(gist.model._id) });
await gist.updateIfNeeded({ force: true });
res.json({ status: gist.status });
} catch (error) {
@@ -68,6 +70,7 @@ router.post(
{ $set: { "options.expirationDate": newExpiration } }
).exec();
if (user.id === gist.owner.id) await resetOwnerAccessAlerts(user.id, { kind: "gist", id: String(gist.model._id) });
await gist.updateIfNeeded({ force: true });
res.json({ status: gist.status, expirationDate: newExpiration });
} catch (error) {
@@ -222,6 +225,7 @@ router.post(
}
).exec();
await gist.updateStatus(RepositoryStatus.PREPARING);
if (user.id === gist.owner.id) await resetOwnerAccessAlerts(user.id, { kind: "gist", id: String(gist.model._id) });
await gist.updateIfNeeded({ force: true });
res.json(gist.toJSON());
} catch (error) {
+3 -1
View File
@@ -1,4 +1,4 @@
import { notificationEmail, normalizeEmail } from "../../core/owner-notifications";
import { notificationEmail, normalizeEmail, resetOwnerAccessAlerts } from "../../core/owner-notifications";
import * as express from "express";
import { createHmac, randomBytes, randomUUID, timingSafeEqual } from "crypto";
import config from "../../config";
@@ -94,6 +94,7 @@ router.get("/app/callback", enabled, async (req, res) => {
}
if (isDisabledAccount(user.status)) throw appError("not_connected", 403);
await saveAppGrant(user.id, tokens);
await resetOwnerAccessAlerts(user.id);
await new Promise<void>((resolve, reject) => req.login({ username: user!.username, user }, err => err ? reject(err) : resolve()));
res.redirect(flow.install ? `/github/app/install?returnTo=${encodeURIComponent(flow.returnTo)}&repository=${encodeURIComponent(flow.repository || "")}` : flow.returnTo);
} catch (error) { handleError(error, res, req); }
@@ -251,6 +252,7 @@ router.post("/connections/migrate", async (req, res) => {
} };
const result = isRepo ? await RepositoryModel.updateOne(filter, change) : await PullRequestModel.updateOne(filter, change);
if (!result.modifiedCount) throw appError("connection_changed", 409);
await resetOwnerAccessAlerts(user.id, { kind: isRepo ? "repository" : "pull-request", id: String(model._id) });
res.json({ connection });
} catch (error) { handleError(error, res, req); }
});
+4
View File
@@ -1,3 +1,4 @@
import { resetOwnerAccessAlerts } from "../../core/owner-notifications";
import { selectRepositoryAccess } from "../../core/github-app";
import * as express from "express";
import { ensureAuthenticated } from "./connection";
@@ -30,6 +31,7 @@ router.post(
const user = await getUser(req);
isOwnerOrAdmin([pullRequest.owner.id], user);
if (user.id === pullRequest.owner.id) await resetOwnerAccessAlerts(user.id, { kind: "pull-request", id: String(pullRequest.model._id) });
await pullRequest.updateIfNeeded({ force: true });
res.json({ status: pullRequest.status });
} catch (error) {
@@ -71,6 +73,7 @@ router.post(
{ $set: { "options.expirationDate": newExpiration } }
).exec();
if (user.id === pullRequest.owner.id) await resetOwnerAccessAlerts(user.id, { kind: "pull-request", id: String(pullRequest.model._id) });
await pullRequest.updateIfNeeded({ force: true });
res.json({ status: pullRequest.status, expirationDate: newExpiration });
} catch (error) {
@@ -242,6 +245,7 @@ router.post(
}
).exec();
await pullRequest.updateStatus(RepositoryStatus.PREPARING);
if (user.id === pullRequest.owner.id) await resetOwnerAccessAlerts(user.id, { kind: "pull-request", id: String(pullRequest.model._id) });
await pullRequest.updateIfNeeded({ force: true });
res.json({ ...pullRequest.toJSON(), connection: pullRequest.model.githubAccess?.kind || "oauth" });
} catch (error) {
+3
View File
@@ -1,3 +1,4 @@
import { resetOwnerAccessAlerts } from "../../core/owner-notifications";
import { randomUUID } from "crypto";
import { githubQuotaKey } from "../../core/github-token-context";
import { selectRepositoryAccess, boundAppToken, appError } from "../../core/github-app";
@@ -146,6 +147,7 @@ router.post(
throw new AnonymousError("invalid_status", { httpStatus: 409 });
}
if (user.id === repo.owner.id) await resetOwnerAccessAlerts(user.id, { kind: "repository", id: String(repo.model._id) });
await repo.refresh();
res.json({ status: repo.status });
} catch (error) {
@@ -621,6 +623,7 @@ router.post(
}
).exec();
if (!saved.matchedCount) throw appError("connection_changed", 409);
if (user.id === repo.owner.id) await resetOwnerAccessAlerts(user.id, { kind: "repository", id: String(repo.model._id) });
if (!sourceChanged && !reactivating) {
return res.json({ status: repo.status });
}