From f7a994b6dcb15e5cf2989e81b7e96e6a3b9f7ff4 Mon Sep 17 00:00:00 2001 From: tdurieux Date: Tue, 4 Oct 2022 13:25:36 +0200 Subject: [PATCH] fix: improve error management file download --- src/AnonymizedFile.ts | 3 ++- src/routes/route-utils.ts | 7 ++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/AnonymizedFile.ts b/src/AnonymizedFile.ts index 96a4a38..645e27f 100644 --- a/src/AnonymizedFile.ts +++ b/src/AnonymizedFile.ts @@ -192,7 +192,8 @@ export default class AnonymizedFile { try { await pipe(await this.anonymizedContent(), res); } catch (error) { - handleError(error, res); + handleError(error); + res.end(); } } } diff --git a/src/routes/route-utils.ts b/src/routes/route-utils.ts index 0bc7c72..57cc8e6 100644 --- a/src/routes/route-utils.ts +++ b/src/routes/route-utils.ts @@ -62,7 +62,7 @@ function printError(error: any, req?: express.Request) { export function handleError( error: any, - res: express.Response, + res?: express.Response, req?: express.Request ) { printError(error, req); @@ -78,8 +78,9 @@ export function handleError( } else if (message && message.indexOf("not_connected") > -1) { status = 401; } - - res.status(status).send({ error: message }); + if (res) { + res.status(status).send({ error: message }); + } return; }