Files
claude-howto/scripts/tests/test_check_markdown_rendering.py
T
Luong NGUYENandGitHub 4f3fa85d7e docs: follow-ups from the v2.1.220 accuracy review (#161)
* fix(ci): move the EPUB build out of pre-commit into CI

The build-epub hooks called scripts/build_epub.py, which raises when the
mmdc binary is missing, while check_mermaid.py skips with a warning in the
same situation. On arm64 — where @mermaid-js/mermaid-cli has no working
build — that made 'pre-commit run --all-files' impossible to satisfy for a
docs-only change without --no-verify.

Remove the build-epub, vietnamese-build-epub and japanese-build-epub hooks
and widen the CI build-epub job to a language matrix so PR-time coverage is
not reduced: it previously built en only, and now builds en, vi, zh and ja.
zh was covered by neither the hooks nor this job, so a broken zh diagram
could only surface at release time.

Closes #156

* docs: replace the stale Kroki narrative with local mmdc rendering

Commit e76bbe4 swapped the Kroki HTTP dependency for local mmdc rendering
but left the docs describing the old design. The claim appeared in seven
live files, not the two originally reported: CLAUDE.md, scripts/README.md
and their ja/uk/vi copies.

Also corrects what the same staleness dragged along:
- scripts/README.md documented --timeout and --max-concurrent, which no
  longer exist, and omitted --mmdc-path, --lang and --puppeteer-config
- 'Async concurrent fetching' described a render_all() that is now a plain
  sequential loop with a dedupe cache
- the network-error/rate-limiting troubleshooting entries are replaced with
  the failures that actually occur now (missing mmdc, Chromium sandbox)

CHANGELOG entries recording the Kroki-to-mmdc switch are left alone; they
describe the past accurately.

Closes #157

* fix(scripts): make the ruff config match files that exist

Ruff resolves include/per-file-ignores patterns relative to the directory
holding pyproject.toml. Since the config lives in scripts/, the pattern
"scripts/**/*.py" meant scripts/scripts/**/*.py, which matches nothing —
'ruff check scripts/' printed 'warning: No Python files found under the
given path(s)' and then 'All checks passed!'. per-file-ignores had the same
mistake. Both are now relative to scripts/, so ruff sees all 14 files.

This silently disabled the pre-commit ruff hooks too, not just the
documented command, and two test files had drifted out of format as a
result. Reformatting them exposed a second problem: the pre-commit hook
pinned ruff v0.8.2 while the CI lint job installs unpinned latest and this
venv has 0.15.10. The versions disagree on formatting, so each reverted the
other's output, and CI would have started failing on a file the local hook
kept rewriting. Bump the hook pin and the requirements-dev floor to 0.15.10
so all three agree.

Verified: 'pre-commit run --all-files' is stable across consecutive runs,
'ruff format --check scripts/' and 'ruff check scripts/' both pass, 92
tests pass.

Closes #160

* docs: point localized module links at their own trees

Files at the root of a language directory used ../NN-module/, which from
uk/CATALOG.md resolves to the English 05-mcp/ at the repo root rather than
uk/05-mcp/. Readers following a count stated about the localized tree
landed in the English one. The link checker never caught it because the
English target does exist.

Files one level deeper (uk/04-subagents/README.md and friends) were already
correct — ../06-hooks/ from there resolves to uk/06-hooks/ — so this is
scoped to the 7 depth-1 files that actually escape: CATALOG.md in uk, vi,
ja and zh, LEARNING-ROADMAP.md in uk and vi, and ja/claude_concepts_guide.md.
119 links in total.

The ../NN- occurrences left in STYLE_GUIDE.md and TRANSLATION_NOTES.md are
inside fenced examples showing what a module page should contain, where the
../ form is the correct convention. All 119 rewritten targets were verified
to exist.

Closes #158

* docs(hooks): stop conflating hook types with hook event categories

'**Hook Types** (5 types, 31 events)' sat above four bullets, so the count
read as wrong. It was not — the two numbers describe different axes that
had been merged into one label.

06-hooks/README.md:126 documents five hook *types*: command, http, prompt,
mcp_tool and agent. Those describe how a hook runs. The four bullets are
event *categories* — Tool, Session, Task, Lifecycle — holding 31 events
(6+7+6+12), and describe when it runs.

Split the label so each number belongs to the axis it counts, in all nine
affected files: README.md and INDEX.md plus the ja, uk, vi and zh copies.
QUICK_REFERENCE.md and LEARNING-ROADMAP.md already stated '5 types' with
the handler names attached and needed no change.

Closes #159

* chore(scripts): drop the unused httpx dependency

httpx was the HTTP client for Kroki rendering. Nothing has imported it
since e76bbe4 moved diagram rendering to a local mmdc subprocess —
check_links.py, the only other network caller, uses stdlib urllib.request.
The PEP 723 blocks in build_epub.py and build_website.py had already
dropped it; only the manifests and docs still declared it.

Removes it from requirements.txt, pyproject.toml dependencies, the
dependency tables and uv --with lines in scripts/README.md and its ja/uk
copies, and the .cspell.json word list. Also drops the B113 bandit
suppression, which existed solely for an httpx timeout false positive —
bandit reports no issues without it.

Also corrects two Requirements lines missed in the previous pass: the ja
and uk script READMEs still listed an internet connection rather than mmdc.

Note: tenacity is now dead for the same reason and is left in place.

* chore(scripts): drop the unused tenacity dependency

Nothing imports tenacity — the retry logic it was added for went away
with the Kroki HTTP fetching in e76bbe4. It was still declared in
requirements.txt, pyproject.toml, both `uv run --with` lines and all
three dependency tables.

* docs(i18n): sync the localized pre-commit check lists

The ja/uk/vi CLAUDE.md files still listed build-epub as pre-commit
check #5, stale since 6da8184 moved the EPUB build to CI. They also
omitted markdown-rendering, and the ja/uk stated counts disagreed with
their own lists. Now matches the English CLAUDE.md.

* fix(scripts): silence PLR0917 now stable in ruff 0.16

CI installs the latest ruff (uv pip install ruff, unpinned), and 0.16.1
promoted too-many-positional-arguments from preview to stable, hard-failing
the Code Quality check on build_epub.py's long-signature draw/helper
functions. These sit in the same family as PLR0913, which is already
ignored. Add PLR0917 so the local 0.15.10 pin and unpinned CI lint agree
again.
2026-08-06 07:58:46 +07:00

186 lines
6.1 KiB
Python

"""Tests for check_markdown_rendering.py — positive + negative per rule."""
from __future__ import annotations
import sys
from pathlib import Path
import pytest
sys.path.insert(0, str(Path(__file__).parent.parent))
import check_markdown_rendering as cmr
@pytest.fixture
def repo(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> Path:
monkeypatch.chdir(tmp_path)
return tmp_path
# ----- rule_backtick_in_inline_code -----------------------------------------
def test_backtick_in_inline_code_flagged(repo: Path) -> None:
(repo / "README.md").write_text("Use `!`command`` for shell substitution.\n")
errors = cmr.rule_backtick_in_inline_code(
Path("README.md"), (repo / "README.md").read_text()
)
assert any("backtick-in-inline-code" in e for e in errors)
def test_double_backtick_idiom_passes(repo: Path) -> None:
(repo / "README.md").write_text("Use `` `!command` `` for shell substitution.\n")
errors = cmr.rule_backtick_in_inline_code(
Path("README.md"), (repo / "README.md").read_text()
)
assert errors == []
def test_backtick_inside_fence_ignored(repo: Path) -> None:
content = "Before\n\n```\nfoo `!`command`` bar\n```\n\nAfter\n"
(repo / "README.md").write_text(content)
errors = cmr.rule_backtick_in_inline_code(Path("README.md"), content)
assert errors == []
def test_backtick_inside_blockquote_fence_ignored(repo: Path) -> None:
content = (
'> note\n>\n> ```json\n> { "key": "value with `inner` backtick" }\n> ```\n'
)
(repo / "README.md").write_text(content)
errors = cmr.rule_backtick_in_inline_code(Path("README.md"), content)
assert errors == []
def test_backtick_line_number_reported(repo: Path) -> None:
content = "line 1\nline 2 with `a`b` content\nline 3\n"
errors = cmr.rule_backtick_in_inline_code(Path("README.md"), content)
assert errors and ":2:" in errors[0]
# ----- rule_unescaped_pipe_in_table -----------------------------------------
def test_unescaped_pipe_in_table_flagged(repo: Path) -> None:
content = "| col1 | col2 |\n|------|------|\n| a | b | c |\n"
errors = cmr.rule_unescaped_pipe_in_table(Path("README.md"), content)
assert any("unescaped-pipe-in-table" in e for e in errors)
def test_escaped_pipe_passes(repo: Path) -> None:
content = "| col1 | col2 |\n|------|------|\n| [color\\|default] | b |\n"
errors = cmr.rule_unescaped_pipe_in_table(Path("README.md"), content)
assert errors == []
def test_pipe_inside_inline_code_in_cell_passes(repo: Path) -> None:
content = "| col1 | col2 |\n|------|------|\n| `a \\| b` | text |\n"
errors = cmr.rule_unescaped_pipe_in_table(Path("README.md"), content)
assert errors == []
def test_pipe_outside_table_ignored(repo: Path) -> None:
content = "This is | a sentence with a pipe in prose.\n"
errors = cmr.rule_unescaped_pipe_in_table(Path("README.md"), content)
assert errors == []
# ----- rule_stray_argument_placeholder --------------------------------------
def test_stray_arguments_in_prose_flagged(repo: Path) -> None:
content = "Run the command and pass $ARGUMENTS to the script.\n"
errors = cmr.rule_stray_argument_placeholder(Path("README.md"), content)
assert any("stray-argument-placeholder" in e for e in errors)
def test_arguments_in_inline_code_passes(repo: Path) -> None:
content = "Pass `$ARGUMENTS` and `$0` to the script.\n"
errors = cmr.rule_stray_argument_placeholder(Path("README.md"), content)
assert errors == []
def test_arguments_in_fenced_code_passes(repo: Path) -> None:
content = "Example:\n\n```bash\nfix-issue $ARGUMENTS\n```\n"
errors = cmr.rule_stray_argument_placeholder(Path("README.md"), content)
assert errors == []
def test_dollar_digit_not_flagged(repo: Path) -> None:
# `$N` is intentionally not flagged — see rule docstring.
content = "The script reads $0 from the prompt.\n"
errors = cmr.rule_stray_argument_placeholder(Path("README.md"), content)
assert errors == []
def test_currency_dollar_amounts_pass(repo: Path) -> None:
cases = [
"Pay $5 today.",
"Costs $5/month.",
"Total: $1,000 plan.",
"Refund: $5.99 fee.",
]
for case in cases:
errors = cmr.rule_stray_argument_placeholder(Path("README.md"), case)
assert errors == [], f"false-positive on prose currency: {case!r}"
# ----- rule_unmatched_fence -------------------------------------------------
def test_matched_fences_pass() -> None:
content = "```\ncode\n```\n\n```python\nmore\n```\n"
errors = cmr.rule_unmatched_fence(Path("README.md"), content)
assert errors == []
def test_unmatched_fence_flagged() -> None:
content = "```bash\nthis fence never closes\n"
errors = cmr.rule_unmatched_fence(Path("README.md"), content)
assert any("unmatched-fence" in e for e in errors)
# ----- main() integration ---------------------------------------------------
def test_main_clean_repo_returns_zero(
repo: Path, capsys: pytest.CaptureFixture[str]
) -> None:
(repo / "README.md").write_text("# Doc\n\nClean content.\n")
assert cmr.main() == 0
assert "Markdown rendering clean" in capsys.readouterr().out
def test_main_dirty_repo_returns_one(
repo: Path, capsys: pytest.CaptureFixture[str]
) -> None:
(repo / "README.md").write_text("Bad: `a`b` here.\n")
assert cmr.main() == 1
assert "Markdown rendering errors" in capsys.readouterr().out
def test_main_ignores_excluded_dirs(
repo: Path, capsys: pytest.CaptureFixture[str]
) -> None:
(repo / "README.md").write_text("# Clean\n")
bad_dir = repo / ".venv"
bad_dir.mkdir()
(bad_dir / "README.md").write_text("Bad: `a`b` here.\n")
assert cmr.main() == 0
assert "Markdown rendering clean" in capsys.readouterr().out
def test_main_scans_translation_dirs(
repo: Path, capsys: pytest.CaptureFixture[str]
) -> None:
(repo / "README.md").write_text("# Clean\n")
for lang in ("ja", "uk", "vi", "zh"):
d = repo / lang
d.mkdir()
(d / "README.md").write_text("Bad: `a`b` here.\n")
assert cmr.main() == 1
out = capsys.readouterr().out
for lang in ("ja", "uk", "vi", "zh"):
assert lang in out