From 6a01aa52e653b50c92219e47fb01ddaf82e3f085 Mon Sep 17 00:00:00 2001 From: YeonGyu-Kim Date: Thu, 2 Apr 2026 15:01:20 +0900 Subject: [PATCH] fix(tools): pass provider runtime model by reference Resolves clippy::needless_pass_by_value in tools/lib.rs. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus --- rust/crates/tools/src/lib.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/crates/tools/src/lib.rs b/rust/crates/tools/src/lib.rs index f37c636..03cf671 100644 --- a/rust/crates/tools/src/lib.rs +++ b/rust/crates/tools/src/lib.rs @@ -1632,7 +1632,7 @@ fn build_agent_runtime( .clone() .unwrap_or_else(|| DEFAULT_AGENT_MODEL.to_string()); let allowed_tools = job.allowed_tools.clone(); - let api_client = ProviderRuntimeClient::new(model, allowed_tools.clone())?; + let api_client = ProviderRuntimeClient::new(&model, allowed_tools.clone())?; let tool_executor = SubagentToolExecutor::new(allowed_tools); Ok(ConversationRuntime::new( Session::new(), @@ -1809,8 +1809,8 @@ struct ProviderRuntimeClient { } impl ProviderRuntimeClient { - fn new(model: String, allowed_tools: BTreeSet) -> Result { - let model = resolve_model_alias(&model).to_string(); + fn new(model: &str, allowed_tools: BTreeSet) -> Result { + let model = resolve_model_alias(model).to_string(); let client = ProviderClient::from_model(&model).map_err(|error| error.to_string())?; Ok(Self { runtime: tokio::runtime::Runtime::new().map_err(|error| error.to_string())?,