all: do not listen on 0.0.0.0 on desktop clients

Since this may create security vulnerabilities such as DNS amplification
or abusing because the listener was exposed to the entire local network.
This commit is contained in:
Cuong Manh Le authored and Cuong Manh Le committed 2025-05-15 16:59:24 +07:00
1 parent ace3b1e66e
commit 00e9d2bdd3
5 files changed
+34 -4

No files matched your search

+3 -1
View File
@@ -1042,8 +1042,10 @@ func (p *prog) queryFromSelf(ip string) bool {
return false
}
// needRFC1918Listeners reports whether ctrld need to spawn listener for RFC 1918 addresses.
// This is helpful for non-desktop platforms to receive queries from LAN clients.
func needRFC1918Listeners(lc *ctrld.ListenerConfig) bool {
return lc.IP == "127.0.0.1" && lc.Port == 53
return lc.IP == "127.0.0.1" && lc.Port == 53 && !ctrld.IsDesktopPlatform()
}
// ipFromARPA parses a FQDN arpa domain and return the IP address if valid.