From 1012bf063f4d5191ca60997c462fb3db9ba7035c Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Wed, 8 May 2024 23:43:26 +0700 Subject: [PATCH] cmd/cli: do not remove forwarders when set DNS on Windows It seems to be a Windows bug when removing a forwarder and adding a new one immediately then causing both of them to be added to forwarders list. This could be verified easily using powershell commands. Since the forwarder will be removed when ctrld stop/uninstall, ctrld run could avoid that action, not only help mitigate above bug, but also not waste host resources. --- cmd/cli/os_windows.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/cmd/cli/os_windows.go b/cmd/cli/os_windows.go index d2f1dd2..3b245b1 100644 --- a/cmd/cli/os_windows.go +++ b/cmd/cli/os_windows.go @@ -41,13 +41,6 @@ func setDNS(iface *net.Interface, nameservers []string) error { // Configuring the Dns server to forward queries to ctrld instead. if windowsHasLocalDnsServerRunning() { file := absHomeDir(forwardersFilename) - if data, _ := os.ReadFile(file); len(data) > 0 { - if err := removeDnsServerForwarders(strings.Split(string(data), ",")); err != nil { - mainLog.Load().Error().Err(err).Msg("could not remove current forwarders settings") - } else { - mainLog.Load().Debug().Msg("removed current forwarders settings.") - } - } if err := os.WriteFile(file, []byte(strings.Join(nameservers, ",")), 0600); err != nil { mainLog.Load().Warn().Err(err).Msg("could not save forwarders settings") }