refactor: improve ServiceManager initialization with cleaner API

- Split initializeServiceManager into two methods:
  * initializeServiceManager(): Simple method using default configuration
  * initializeServiceManagerWithServiceConfig(): Advanced method for custom config
- Simplify NewServiceCommand() to return *ServiceCommand without error
- Update all service command methods to use appropriate initialization:
  * Start: Uses initializeServiceManagerWithServiceConfig() for custom args
  * Stop/Restart/Reload/Status/Uninstall: Use simple initializeServiceManager()
- Remove direct access to sc.serviceManager.svc/prog in favor of lazy initialization
- Improve separation of concerns and reduce code duplication
This commit is contained in:
Cuong Manh Le
2025-07-30 15:52:56 +07:00
committed by Cuong Manh Le
parent 76e602afc3
commit 33dd720d80
7 changed files with 54 additions and 22 deletions
+6 -2
View File
@@ -21,8 +21,6 @@ import (
// Start implements the logic from cmdStart.Run
func (sc *ServiceCommand) Start(cmd *cobra.Command, args []string) error {
s := sc.serviceManager.svc
p := sc.serviceManager.prog
checkStrFlagEmpty(cmd, cdUidFlagName)
checkStrFlagEmpty(cmd, cdOrgFlagName)
validateCdAndNextDNSFlags()
@@ -36,6 +34,12 @@ func (sc *ServiceCommand) Start(cmd *cobra.Command, args []string) error {
setDependencies(svcConfig)
svcConfig.Arguments = append([]string{"run"}, osArgs...)
// Initialize service manager with proper configuration
s, p, err := sc.initializeServiceManagerWithServiceConfig(svcConfig)
if err != nil {
return err
}
p.cfg = &cfg
p.preRun()