CalvinBackup/ctrld
1
0
Fork 0
mirror of https://github.com/Control-D-Inc/ctrld.git synced 2026-07-29 01:18:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove incorrect transport close on DoH3 error

Browse Source 
Remove the transport Close() call from DoH3 error handling path.
The transport is shared and reused across requests, and closing it
on error would break subsequent requests. The transport lifecycle
is already properly managed by the http.Client and the finalizer
set in newDOH3Transport().
This commit is contained in:
Cuong Manh Le
2026-04-30 19:19:19 +07:00
committed by Cuong Manh Le
parent ba3dd3a4b0
commit 43d4e1957c
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
doh.go
-5
View File
@@ -137,11 +137,6 @@ func (r *dohResolver) Resolve(ctx context.Context, msg *dns.Msg) (*dns.Msg, erro
} }
if err != nil { if err != nil {
err = wrapUrlError(err) err = wrapUrlError(err)
if r.isDoH3 {
if closer, ok := c.Transport.(io.Closer); ok {
closer.Close()
}
}
Log(ctx, logger.Error().Err(err), "DoH request failed") Log(ctx, logger.Error().Err(err), "DoH request failed")
return nil, fmt.Errorf("could not perform request: %w", err) return nil, fmt.Errorf("could not perform request: %w", err)
} }