From 72507f3e2c0b145c868c543aaac86f0c1cecf7de Mon Sep 17 00:00:00 2001 From: Dev Scribe Date: Mon, 21 Sep 2026 12:29:10 -0400 Subject: [PATCH] test(cli): verify closed log files portably on Windows Use Write rather than Stat to verify retained file handles are closed. Windows Stat returns ERROR_INVALID_HANDLE instead of os.ErrClosed. Retain final-cleanup content assertions and strict closed-error matching. --- cmd/cli/internal_log_shutdown_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/cli/internal_log_shutdown_test.go b/cmd/cli/internal_log_shutdown_test.go index 5616105..8f7b0e1 100644 --- a/cmd/cli/internal_log_shutdown_test.go +++ b/cmd/cli/internal_log_shutdown_test.go @@ -36,7 +36,7 @@ func TestFinishRunClosesInternalFilesWithoutServiceStop(t *testing.T) { close(p.runDone) p.finishRun() for i, f := range files { - if _, err := f.Stat(); !errors.Is(err, os.ErrClosed) { + if _, err := f.Write([]byte("unexpected write\n")); !errors.Is(err, os.ErrClosed) { t.Errorf("file %d is not closed: %v", i, err) } b, err := os.ReadFile(paths[i])