From a582195cec5ac4aa6f04228506b68156250a5359 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Thu, 20 Feb 2025 01:30:01 +0700 Subject: [PATCH] internal/controld: bump default http client timeout While at it, also converting them to global constants. --- internal/controld/config.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/controld/config.go b/internal/controld/config.go index 73bdf6b..5bedb04 100644 --- a/internal/controld/config.go +++ b/internal/controld/config.go @@ -32,6 +32,8 @@ const ( logURLCom = apiURLCom + "/logs" logURLDev = apiURLDev + "/logs" InvalidConfigCode = 40402 + defaultTimeout = 20 * time.Second + sendLogTimeout = 300 * time.Second ) // ResolverConfig represents Control D resolver data. @@ -135,7 +137,7 @@ func postUtilityAPI(version string, cdDev, lastUpdatedFailed bool, body io.Reade req.Header.Add("Content-Type", "application/json") transport := apiTransport(cdDev) client := http.Client{ - Timeout: 10 * time.Second, + Timeout: defaultTimeout, Transport: transport, } resp, err := client.Do(req) @@ -176,7 +178,7 @@ func SendLogs(lr *LogsRequest, cdDev bool) error { req.Header.Add("Content-Type", "application/x-www-form-urlencoded") transport := apiTransport(cdDev) client := http.Client{ - Timeout: 300 * time.Second, + Timeout: sendLogTimeout, Transport: transport, } resp, err := client.Do(req)