From c401c4ef871642ac8ba74575a555dd6a0c5d6111 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Fri, 17 Mar 2023 21:52:34 +0700 Subject: [PATCH] cmd/ctrld: do not set default iface value for uninstall command Fixed #30 --- cmd/ctrld/cli.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/cmd/ctrld/cli.go b/cmd/ctrld/cli.go index bea5161..ec33ac6 100644 --- a/cmd/ctrld/cli.go +++ b/cmd/ctrld/cli.go @@ -351,7 +351,10 @@ func initCLI() { PreRun: checkHasElevatedPrivilege, Use: "uninstall", Short: "Stop and uninstall the ctrld service", - Args: cobra.NoArgs, + Long: `Stop and uninstall the ctrld service. + +NOTE: Uninstalling will set DNS to values provided by DHCP.`, + Args: cobra.NoArgs, Run: func(cmd *cobra.Command, args []string) { prog := &prog{} s, err := service.New(prog, svcConfig) @@ -365,13 +368,16 @@ func initCLI() { } initLogging() if doTasks(tasks) { + if iface == "" { + iface = "auto" + } prog.resetDNS() mainLog.Info().Msg("Service uninstalled") return } }, } - uninstallCmd.Flags().StringVarP(&iface, "iface", "", "auto", `Reset DNS setting for iface, "auto" means the default interface gateway`) + uninstallCmd.Flags().StringVarP(&iface, "iface", "", "", `Reset DNS setting for iface, use "auto" for the default gateway interface`) listIfacesCmd := &cobra.Command{ Use: "list",