From ce1a16534899fd991f21935cf6d1065fdd33182e Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Fri, 15 Aug 2025 23:09:08 +0700 Subject: [PATCH] .github/workflows: bump go version to 1.24.x --- .github/workflows/ci.yml | 4 ++-- internal/clientinfo/mdns.go | 1 - internal/clientinfo/ptr_lookup.go | 1 - 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b4b44d4..5bd4d27 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,7 +9,7 @@ jobs: fail-fast: false matrix: os: ["windows-latest", "ubuntu-latest", "macOS-latest"] - go: ["1.23.x"] + go: ["1.24.x"] runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v3 @@ -21,6 +21,6 @@ jobs: - run: "go test -race ./..." - uses: dominikh/staticcheck-action@v1.3.1 with: - version: "2024.1.1" + version: "2025.1" install-go: false cache-key: ${{ matrix.go }} diff --git a/internal/clientinfo/mdns.go b/internal/clientinfo/mdns.go index e009e01..a09d729 100644 --- a/internal/clientinfo/mdns.go +++ b/internal/clientinfo/mdns.go @@ -74,7 +74,6 @@ func (m *mdns) lookupIPByHostname(name string, v6 bool) string { if value == name { if addr, err := netip.ParseAddr(key.(string)); err == nil && addr.Is6() == v6 { ip = addr.String() - //lint:ignore S1008 This is used for readable. if addr.IsLoopback() { // Continue searching if this is loopback address. return true } diff --git a/internal/clientinfo/ptr_lookup.go b/internal/clientinfo/ptr_lookup.go index 29ed84f..9a1d10c 100644 --- a/internal/clientinfo/ptr_lookup.go +++ b/internal/clientinfo/ptr_lookup.go @@ -104,7 +104,6 @@ func (p *ptrDiscover) lookupIPByHostname(name string, v6 bool) string { if value == name { if addr, err := netip.ParseAddr(key.(string)); err == nil && addr.Is6() == v6 { ip = addr.String() - //lint:ignore S1008 This is used for readable. if addr.IsLoopback() { // Continue searching if this is loopback address. return true }