use real node id for pending uploads, more camera -> node

2026-07-07 05:07:54 +02:00 · 2025-09-28 20:20:00 -05:00
parent 4ad33d17e0
commit 4053c9b39b
10 changed files with 231 additions and 101 deletions
@@ -0,0 +1,103 @@
+import 'package:latlong2/latlong.dart';
+import '../models/osm_camera_node.dart';
+import 'package:flutter_map/flutter_map.dart' show LatLngBounds;
+
+class NodeCache {
+  // Singleton instance
+  static final NodeCache instance = NodeCache._internal();
+  factory NodeCache() => instance;
+  NodeCache._internal();
+
+  final Map<int, OsmCameraNode> _nodes = {};
+
+  /// Add or update a batch of nodes in the cache.
+  void addOrUpdate(List<OsmCameraNode> nodes) {
+    for (var node in nodes) {
+      final existing = _nodes[node.id];
+      if (existing != null) {
+        // Preserve any tags starting with underscore when updating existing nodes
+        final mergedTags = Map<String, String>.from(node.tags);
+        for (final entry in existing.tags.entries) {
+          if (entry.key.startsWith('_')) {
+            mergedTags[entry.key] = entry.value;
+          }
+        }
+        _nodes[node.id] = OsmCameraNode(
+          id: node.id,
+          coord: node.coord,
+          tags: mergedTags,
+        );
+      } else {
+        _nodes[node.id] = node;
+      }
+    }
+  }
+
+  /// Query for all cached nodes currently within the given LatLngBounds.
+  List<OsmCameraNode> queryByBounds(LatLngBounds bounds) {
+    return _nodes.values
+        .where((node) => _inBounds(node.coord, bounds))
+        .toList();
+  }
+
+  /// Retrieve all cached nodes.
+  List<OsmCameraNode> getAll() => _nodes.values.toList();
+
+  /// Optionally clear the cache (rarely needed)
+  void clear() => _nodes.clear();
+
+  /// Remove the _pending_edit marker from a specific node
+  void removePendingEditMarker(int nodeId) {
+    final node = _nodes[nodeId];
+    if (node != null && node.tags.containsKey('_pending_edit')) {
+      final cleanTags = Map<String, String>.from(node.tags);
+      cleanTags.remove('_pending_edit');
+      
+      _nodes[nodeId] = OsmCameraNode(
+        id: node.id,
+        coord: node.coord,
+        tags: cleanTags,
+      );
+    }
+  }
+  
+  /// Remove temporary nodes (negative IDs) with _pending_upload marker at the given coordinate
+  /// This is used when a real node ID is assigned to clean up temp placeholders
+  void removeTempNodesByCoordinate(LatLng coord, {double tolerance = 0.00001}) {
+    final nodesToRemove = <int>[];
+    
+    for (final entry in _nodes.entries) {
+      final nodeId = entry.key;
+      final node = entry.value;
+      
+      // Only consider temp nodes (negative IDs) with pending upload marker
+      if (nodeId < 0 && 
+          node.tags.containsKey('_pending_upload') &&
+          _coordsMatch(node.coord, coord, tolerance)) {
+        nodesToRemove.add(nodeId);
+      }
+    }
+    
+    for (final nodeId in nodesToRemove) {
+      _nodes.remove(nodeId);
+    }
+    
+    if (nodesToRemove.isNotEmpty) {
+      print('[NodeCache] Removed ${nodesToRemove.length} temp nodes at coordinate ${coord.latitude}, ${coord.longitude}');
+    }
+  }
+  
+  /// Check if two coordinates match within tolerance
+  bool _coordsMatch(LatLng coord1, LatLng coord2, double tolerance) {
+    return (coord1.latitude - coord2.latitude).abs() < tolerance &&
+           (coord1.longitude - coord2.longitude).abs() < tolerance;
+  }
+
+  /// Utility: point-in-bounds for coordinates
+  bool _inBounds(LatLng coord, LatLngBounds bounds) {
+    return coord.latitude >= bounds.southWest.latitude &&
+        coord.latitude <= bounds.northEast.latitude &&
+        coord.longitude >= bounds.southWest.longitude &&
+        coord.longitude <= bounds.northEast.longitude;
+  }
+}