CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-23 04:04:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: optimize DB calls with frappe.get_all (backport #45289) (#45391)

Browse Source 
perf: optimize DB calls with frappe.get_all (#45289)

* perf: reduce multiple db queries

* fix: use frappe._dict instread of extra iteration

---------

Co-authored-by: Sanket322 <shahsanket322003.com>
(cherry picked from commit 2a400dd3f8)

Co-authored-by: Sanket Shah <113279972+Sanket322@users.noreply.github.com>
This commit is contained in:
mergify[bot]
2025-01-23 13:01:12 +05:30
committed by GitHub
parent 412e22fb4e
commit 04f5a72e08
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/controllers/selling_controller.py
View File

@@ -714,6 +714,16 @@ class SellingController(StockController):
if self.doctype == "POS Invoice": if self.doctype == "POS Invoice":
return return
items = [item.item_code for item in self.get("items")]
item_stock_map = frappe._dict(
frappe.get_all(
"Item",
filters={"item_code": ["in", items]},
fields=["item_code", "is_stock_item"],
as_list=True,
)
)
for d in self.get("items"): for d in self.get("items"):
if self.doctype == "Sales Invoice": if self.doctype == "Sales Invoice":
stock_items = [ stock_items = [
@@ -747,7 +757,7 @@ class SellingController(StockController):
frappe.bold(_("Allow Item to Be Added Multiple Times in a Transaction")), frappe.bold(_("Allow Item to Be Added Multiple Times in a Transaction")),
get_link_to_form("Selling Settings", "Selling Settings"), get_link_to_form("Selling Settings", "Selling Settings"),
) )
if frappe.db.get_value("Item", d.item_code, "is_stock_item") == 1: if item_stock_map.get(d.item_code):
if stock_items in check_list: if stock_items in check_list:
frappe.throw(duplicate_items_msg) frappe.throw(duplicate_items_msg)
else: else: