From 064ce4bf6d933d6e803d0980ce2274402a22a458 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Wed, 27 Aug 2025 16:51:19 +0000 Subject: [PATCH] fix: hide is_cumulative for apply_on is set to Transaction (backport #49243) (#49257) * fix: hide is_cumulative for apply_on is set to Transaction (cherry picked from commit 699d42b26c77166dc11d1d5e499f1c5f51d447fa) # Conflicts: # erpnext/accounts/doctype/promotional_scheme/promotional_scheme.json * chore: update modified date for promotional_scheme.json --------- Co-authored-by: Navin-S-R Co-authored-by: Mihir Kandoi --- erpnext/accounts/doctype/pricing_rule/pricing_rule.json | 3 ++- .../doctype/promotional_scheme/promotional_scheme.json | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/erpnext/accounts/doctype/pricing_rule/pricing_rule.json b/erpnext/accounts/doctype/pricing_rule/pricing_rule.json index c4825a6d519..7a5c6d7713b 100644 --- a/erpnext/accounts/doctype/pricing_rule/pricing_rule.json +++ b/erpnext/accounts/doctype/pricing_rule/pricing_rule.json @@ -174,6 +174,7 @@ }, { "default": "0", + "depends_on": "eval:doc.apply_on != 'Transaction'", "fieldname": "is_cumulative", "fieldtype": "Check", "label": "Is Cumulative" @@ -656,7 +657,7 @@ "icon": "fa fa-gift", "idx": 1, "links": [], - "modified": "2025-02-17 18:15:39.824639", + "modified": "2025-08-20 11:40:07.096854", "modified_by": "Administrator", "module": "Accounts", "name": "Pricing Rule", diff --git a/erpnext/accounts/doctype/promotional_scheme/promotional_scheme.json b/erpnext/accounts/doctype/promotional_scheme/promotional_scheme.json index 1d68b23d6c7..c55b0a7d7ff 100644 --- a/erpnext/accounts/doctype/promotional_scheme/promotional_scheme.json +++ b/erpnext/accounts/doctype/promotional_scheme/promotional_scheme.json @@ -93,12 +93,14 @@ }, { "default": "0", + "depends_on": "eval:doc.apply_on != 'Transaction'", "fieldname": "mixed_conditions", "fieldtype": "Check", "label": "Mixed Conditions" }, { "default": "0", + "depends_on": "eval:doc.apply_on != 'Transaction'", "fieldname": "is_cumulative", "fieldtype": "Check", "label": "Is Cumulative" @@ -278,7 +280,7 @@ } ], "links": [], - "modified": "2021-05-06 16:20:22.039078", + "modified": "2025-08-20 11:48:23.231081", "modified_by": "Administrator", "module": "Accounts", "name": "Promotional Scheme", @@ -336,4 +338,4 @@ "sort_field": "modified", "sort_order": "DESC", "track_changes": 1 -} \ No newline at end of file +}