From d14799a9fa9034c581017f46a5e7f310f0f9b9a4 Mon Sep 17 00:00:00 2001 From: Charles-Henri Decultot Date: Wed, 24 Apr 2019 18:06:14 +0200 Subject: [PATCH 1/2] fix: verbose error message when api keys are not setup --- .../doctype/plaid_settings/plaid_settings.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js index 76205e6c823..1f6499ec98a 100644 --- a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js +++ b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js @@ -22,6 +22,10 @@ erpnext.integrations.plaidLink = class plaidLink { frappe.xcall('erpnext.erpnext_integrations.doctype.plaid_settings.plaid_settings.plaid_configuration') .then(result => { if (result !== "disabled") { + console.log(result) + if (result.plaid_env == undefined || result.plaid_public_key == undefined) { + frappe.throw(__("Please add valid Plaid api keys in site_config.json first")); + } me.plaid_env = result.plaid_env; me.plaid_public_key = result.plaid_public_key; me.client_name = result.client_name; From 97842ca8048d0a357824b429b537f62b25df54c8 Mon Sep 17 00:00:00 2001 From: Charles-Henri Decultot Date: Wed, 24 Apr 2019 18:15:46 +0200 Subject: [PATCH 2/2] fix: cleanup development --- .../doctype/plaid_settings/plaid_settings.js | 1 - 1 file changed, 1 deletion(-) diff --git a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js index 1f6499ec98a..ace4fbf9e30 100644 --- a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js +++ b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js @@ -22,7 +22,6 @@ erpnext.integrations.plaidLink = class plaidLink { frappe.xcall('erpnext.erpnext_integrations.doctype.plaid_settings.plaid_settings.plaid_configuration') .then(result => { if (result !== "disabled") { - console.log(result) if (result.plaid_env == undefined || result.plaid_public_key == undefined) { frappe.throw(__("Please add valid Plaid api keys in site_config.json first")); }