From 100d8e200787c3bfa190678a41f2d98e60215e15 Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Thu, 20 Jun 2024 14:32:01 +0200
Subject: [PATCH] fix: move condition for shipment

---
 erpnext/stock/doctype/delivery_note/delivery_note.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/erpnext/stock/doctype/delivery_note/delivery_note.js b/erpnext/stock/doctype/delivery_note/delivery_note.js
index eba41d97c6e..1f6816e3fed 100644
--- a/erpnext/stock/doctype/delivery_note/delivery_note.js
+++ b/erpnext/stock/doctype/delivery_note/delivery_note.js
@@ -188,8 +188,8 @@ erpnext.stock.DeliveryNoteController = class DeliveryNoteController extends (
 			);
 		}
 
-		if (!doc.is_return && doc.status != "Closed" && frappe.model.can_create("Shipment")) {
-			if (doc.docstatus == 1) {
+		if (!doc.is_return && doc.status != "Closed") {
+			if (doc.docstatus == 1 && frappe.model.can_create("Shipment")) {
 				this.frm.add_custom_button(
 					__("Shipment"),
 					function () {