From 11a6db32ae2e124b3c357fc6f24f8b7dd2e26efd Mon Sep 17 00:00:00 2001 From: diptanilsaha Date: Sat, 7 Mar 2026 13:30:36 +0530 Subject: [PATCH] refactor(`leaderboard`): type annotations for whitelisted methods --- erpnext/startup/leaderboard.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/erpnext/startup/leaderboard.py b/erpnext/startup/leaderboard.py index f5a5216b51d..22cf179d2c0 100644 --- a/erpnext/startup/leaderboard.py +++ b/erpnext/startup/leaderboard.py @@ -54,7 +54,7 @@ def get_leaderboards(): @frappe.whitelist() -def get_all_customers(date_range, company, field, limit=None): +def get_all_customers(date_range: str, company: str, field: str, limit: int | None = None): filters = [["docstatus", "=", "1"], ["company", "=", company]] from_date, to_date = parse_date_range(date_range) if field == "outstanding_amount": @@ -89,7 +89,7 @@ def get_all_customers(date_range, company, field, limit=None): @frappe.whitelist() -def get_all_items(date_range, company, field, limit=None): +def get_all_items(date_range: str, company: str, field: str, limit: int | None = None): if field in ("available_stock_qty", "available_stock_value"): sum_field = "actual_qty" if field == "available_stock_qty" else "stock_value" results = frappe.db.get_all( @@ -135,7 +135,7 @@ def get_all_items(date_range, company, field, limit=None): @frappe.whitelist() -def get_all_suppliers(date_range, company, field, limit=None): +def get_all_suppliers(date_range: str, company: str, field: str, limit: int | None = None): filters = [["docstatus", "=", "1"], ["company", "=", company]] from_date, to_date = parse_date_range(date_range) @@ -171,7 +171,7 @@ def get_all_suppliers(date_range, company, field, limit=None): @frappe.whitelist() -def get_all_sales_partner(date_range, company, field, limit=None): +def get_all_sales_partner(date_range: str, company: str, field: str, limit: int | None = None): if field == "total_sales_amount": select_field = "base_net_total" elif field == "total_commission": @@ -196,7 +196,7 @@ def get_all_sales_partner(date_range, company, field, limit=None): @frappe.whitelist() -def get_all_sales_person(date_range, company, field=None, limit=0): +def get_all_sales_person(date_range: str, company: str, field: str | None = None, limit: int | None = None): filters = [ ["docstatus", "=", "1"], ["company", "=", company],