From da6eea77437cffce628a08ef2ce5e6da2afdf193 Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Thu, 8 Aug 2024 12:05:08 +0200 Subject: [PATCH 1/2] fix(Exchange Rate Revaluation): translatable strings (cherry picked from commit dc29fb8759bed1e6bb3da3cd7e009b51d8d0254b) --- .../exchange_rate_revaluation/exchange_rate_revaluation.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.js b/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.js index 741039acae6..db3c284ca8d 100644 --- a/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.js +++ b/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.js @@ -91,12 +91,12 @@ frappe.ui.form.on("Exchange Rate Revaluation", { method: "make_jv_entries", doc: frm.doc, freeze: true, - freeze_message: "Making Journal Entries...", + freeze_message: __("Creating Journal Entries..."), callback: function (r) { if (r.message) { let response = r.message; if (response["revaluation_jv"] || response["zero_balance_jv"]) { - frappe.msgprint(__("Journals have been created")); + frappe.msgprint(__("Journal entries have been created")); } } }, From 13f6f3259d49c317ce465bc01c0b7c7fb46fa1ab Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Thu, 8 Aug 2024 12:05:25 +0200 Subject: [PATCH 2/2] refactor(Exchange Rate Revaluation): remove unused variables (cherry picked from commit 8bd84e9d51d21f8e22dd540d734c2c4778a843a2) --- .../exchange_rate_revaluation/exchange_rate_revaluation.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.js b/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.js index db3c284ca8d..eeda531c4d6 100644 --- a/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.js +++ b/erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.js @@ -85,8 +85,6 @@ frappe.ui.form.on("Exchange Rate Revaluation", { }, make_jv: function (frm) { - let revaluation_journal = null; - let zero_balance_journal = null; frappe.call({ method: "make_jv_entries", doc: frm.doc,