From 1622fc8728d0b854013db610cfdd0a09745b5a63 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Thu, 23 Jan 2025 11:15:13 +0530 Subject: [PATCH] fix: set preferred email in Employee via backend controller (backport #45320) (#45378) fix: set preferred email in Employee via backend controller (#45320) fix: set preferred email in Employee (backend) Set "Preferred Email" for Employee via validate. Unset value when prefered_contact_email is also unset. (cherry picked from commit 4481ca83ff8d616cee416851f497af9fbaeb6b13) Co-authored-by: gavin --- erpnext/setup/doctype/employee/employee.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/erpnext/setup/doctype/employee/employee.py b/erpnext/setup/doctype/employee/employee.py index 9f8f3861cf3..3dc6f4b73e8 100755 --- a/erpnext/setup/doctype/employee/employee.py +++ b/erpnext/setup/doctype/employee/employee.py @@ -42,6 +42,7 @@ class Employee(NestedSet): self.validate_email() self.validate_status() self.validate_reports_to() + self.set_preferred_email() self.validate_preferred_email() if self.user_id: @@ -184,9 +185,7 @@ class Employee(NestedSet): def set_preferred_email(self): preferred_email_field = frappe.scrub(self.prefered_contact_email) - if preferred_email_field: - preferred_email = self.get(preferred_email_field) - self.prefered_email = preferred_email + self.prefered_email = self.get(preferred_email_field) if preferred_email_field else None def validate_status(self): if self.status == "Left":