CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-27 23:21:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Do not deduct TCS for opening invoices

Browse Source 
(cherry picked from commit eb9f579b8f)
This commit is contained in:
Deepesh Garg
2024-05-03 11:47:43 +05:30
committed by Mergify
parent b3736d6c6c
commit 1999b7a6c5
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/accounts/doctype/sales_invoice/sales_invoice.py
View File

@@ -388,6 +388,9 @@ class SalesInvoice(SellingController):
validate_account_head(item.idx, item.income_account, self.company, "Income") validate_account_head(item.idx, item.income_account, self.company, "Income")
def set_tax_withholding(self): def set_tax_withholding(self):
if self.get("is_opening") == "Yes":
return
tax_withholding_details = get_party_tax_withholding_details(self) tax_withholding_details = get_party_tax_withholding_details(self)
if not tax_withholding_details: if not tax_withholding_details:

3
erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py
View File

@@ -9,6 +9,8 @@ from frappe.query_builder import Criterion
from frappe.query_builder.functions import Abs, Sum from frappe.query_builder.functions import Abs, Sum
from frappe.utils import cint, flt, getdate from frappe.utils import cint, flt, getdate
from erpnext.controllers.accounts_controller import validate_account_head
class TaxWithholdingCategory(Document): class TaxWithholdingCategory(Document):
# begin: auto-generated types # begin: auto-generated types
@@ -53,6 +55,7 @@ class TaxWithholdingCategory(Document):
if d.get("account") in existing_accounts: if d.get("account") in existing_accounts:
frappe.throw(_("Account {0} added multiple times").format(frappe.bold(d.get("account")))) frappe.throw(_("Account {0} added multiple times").format(frappe.bold(d.get("account"))))
validate_account_head(d.idx, d.get("account"), d.get("company"))
existing_accounts.append(d.get("account")) existing_accounts.append(d.get("account"))
def validate_thresholds(self): def validate_thresholds(self):