CalvinBackup/erpnext
1
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-03-03 10:35:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't duplicate default income account to Item (#50413)

Browse Source 
* fix: don't duplicate default income account to Item

Only store _Default Income Account_ in **Item** if it's different from the **Company**'s  _Default Income Account_.

Resolves #48231

* refactor: move db call out of loop

* docs: add docstring

(cherry picked from commit b6cb9d4799)
This commit is contained in:
Raffael Meyer
2025-12-25 10:22:37 +01:00
committed by Mergify
parent 88e305f5a2
commit 1cb22f9d05
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
erpnext/controllers/selling_controller.py
View File

@@ -1004,10 +1004,19 @@ class SellingController(StockController):
def set_default_income_account_for_item(obj): def set_default_income_account_for_item(obj):
for d in obj.get("items"): """Set income account as default for items in the transaction.
if d.item_code:
if getattr(d, "income_account", None): Updates the item default income account for each item in the transaction
set_item_default(d.item_code, obj.company, "income_account", d.income_account) if it differs from the company's default income account.
Args:
obj: Transaction document containing items table with income_account field
"""
company_default = frappe.get_cached_value("Company", obj.company, "default_income_account")
for d in obj.get("items", default=[]):
income_account = getattr(d, "income_account", None)
if d.item_code and income_account and income_account != company_default:
set_item_default(d.item_code, obj.company, "income_account", income_account)
def get_serial_and_batch_bundle(child, parent, delivery_note_child=None): def get_serial_and_batch_bundle(child, parent, delivery_note_child=None):